Summary:	ASTERISK-27904: [patch] testsuite: Enable asttest in (Red Hat) Fedora.
Reporter:	Alexander Traud (traud)	Labels:	patch
Date Opened:	2018-06-07 11:21:19	Date Closed:	2018-06-08 01:46:04
Priority:	Minor	Regression?
Status:	Closed/Complete	Components:	Tests/testsuite
Versions:	GIT	Frequency of Occurrence
Related Issues:
Environment:	Fedora 20 (and newer)	Attachments:	( 0) fedora_lua_asterisk.patch ( 1) fedora_lua_asttest.patch
Description:	asttest of the Asterisk Test Suite was introduced while Lua was in version 5.1. asttest was never updated. It still requires Lua 5.1 today. For best test results, Asterisk itself should be built not with Lua 5.3 but Lua 5.1 as well. Since Fedora 20 (Bug [815263|https://bugzilla.redhat.com/show_bug.cgi?id=815263]), the shared libraries for for Lua are called * {{liblua.so}} which is Lua 5.2; since Fedora 22: Lua 5.3 * {{liblua-5.1.so}} (package {{compat-lua-devel}}) The header file {{lua.h}} is in * {{/usr/unclude/lua.h}} which is Lua 5.2; since Fedora 22: Lua 5.3 * {{/usr/unclude/lua-5.1/lua.h}} (package {{compat-lua-devel}}) This is in contrast to Debian/Ubuntu which has * {{liblua5.3.so}} * {{liblua5.1.so}} The header file {{lua.h}} is in * {{/usr/include/lua5.3/lua.h}} * {{/usr/include/lua5.1/lua.h}} Because of that hyphen-minus, Lua 5.1 is not detected by the script {{./configure}} automatically in Fedora. Thanks to the changes in Commit [66f13ed|https://github.com/asterisk/asterisk/commit/66f13ed69471c819f0e4e5068aef9ca74aabac5f#diff-67e997bcfdac55191033d57a16d1408a] the attached one-line patch for Asterisk was possible. However, again that is just a workaround and the approach of ASTERISK-27638 should be taken. Furthermore, that patch would precedence Lua 5.1 over 5.3. Although this is fine for the Asterisk Test Suite, it is not for the general audience. Furthermore, the tool asttest searches for 'lua5.1' while compiling. Again, the hyphen-minus is missing for Fedora. Therefore, the other attached patch changes asttest to look for 'lua-5.1' and use the Lua Compiler in version 5.1 (package {{compat-lua}}). All this is a workaround. And because of ASTERISK-23293, this issue here gets a Won't Fix. However, those two patches help those who are interested to use the Asterisk Test Suite in Fedora. Instead, if you want a out-of-the-box experience, consider Debian/Ubuntu for the Asterisk Test Suite. For such, installation steps can be found in ASTERISK-27897.
Comments:	By: Asterisk Team (asteriskteam) 2018-06-07 11:21:20.957-0500 Thanks for creating a report! The issue has entered the triage process. That means the issue will wait in this status until a Bug Marshal has an opportunity to review the issue. Once the issue has been reviewed you will receive comments regarding the next steps towards resolution. A good first step is for you to review the [Asterisk Issue Guidelines|https://wiki.asterisk.org/wiki/display/AST/Asterisk+Issue+Guidelines] if you haven't already. The guidelines detail what is expected from an Asterisk issue report. Then, if you are submitting a patch, please review the [Patch Contribution Process|https://wiki.asterisk.org/wiki/display/AST/Patch+Contribution+Process].