Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Channels/chan_sip/T.38
    • Labels:
      None
    • SVN Revision Number:
      89114
    • Mantis ID:
      11239
    • Regression:
      No

      Description

      Initial issue was: t38.t38support flag field which is checked for SIP_PAGE2_T38SUPPORT_UDPTL when doing fax detection (+ switch to T38) in sip_rtp_read was never initialized. As result fax detection had no chance to work.

      Attachef patch fixes initialization of the flag field + moves some common code into the function.

                • ADDITIONAL INFORMATION ******

      NOTE: even after this patch fax detection won't work - this is because DSP_FEATURE_FAX_DETECT is not passed to ast_dsp_set_features. While I managed to fix all these issues in the lab and make fax detection + automatic switchover to T38 work in my lab, after some thoughts I consider it a misfeature and will propose removing it from chan_sip (will fill another issue about that).

      So despite initial intent to fix fax detection, this patch is pure cleanup not adding anything new.

        Activity

        Hide
        Olle Johansson added a comment -

        Assigning this to the "FAXman" (file) since he's doing a lot of changes to the t.38 support.

        Show
        Olle Johansson added a comment - Assigning this to the "FAXman" (file) since he's doing a lot of changes to the t.38 support.
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 97154

        U trunk/channels/chan_sip.c

        ------------------------------------------------------------------------
        r97154 | file | 2008-01-08 14:03:04 -0600 (Tue, 08 Jan 2008) | 6 lines

        Move common code for setting T38 capabilities and fix a bug with fax detection in the SIP RTP read callback. It's still sort of silly... but more on that later.
        (closes issue ASTERISK-10758)
        Reported by: dimas
        Patches:
        sipt38prop.patch uploaded by dimas (license 88)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=97154

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 97154 U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r97154 | file | 2008-01-08 14:03:04 -0600 (Tue, 08 Jan 2008) | 6 lines Move common code for setting T38 capabilities and fix a bug with fax detection in the SIP RTP read callback. It's still sort of silly... but more on that later. (closes issue ASTERISK-10758 ) Reported by: dimas Patches: sipt38prop.patch uploaded by dimas (license 88) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=97154
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 97535

        _U team/murf/bug11210/
        U team/murf/bug11210/CHANGES
        U team/murf/bug11210/apps/app_queue.c
        U team/murf/bug11210/apps/app_voicemail.c
        U team/murf/bug11210/channels/chan_console.c
        U team/murf/bug11210/channels/chan_mgcp.c
        U team/murf/bug11210/channels/chan_sip.c
        U team/murf/bug11210/configs/queues.conf.sample
        U team/murf/bug11210/funcs/func_groupcount.c
        U team/murf/bug11210/main/asterisk.c
        U team/murf/bug11210/main/autoservice.c
        U team/murf/bug11210/main/utils.c
        U team/murf/bug11210/res/res_jabber.c

        ------------------------------------------------------------------------
        r97535 | murf | 2008-01-09 12:20:51 -0600 (Wed, 09 Jan 2008) | 140 lines

        Merged revisions 97125,97153-97154,97193,97196-97200,97203,97208,97248 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r97125 | tilghman | 2008-01-08 12:06:27 -0700 (Tue, 08 Jan 2008) | 11 lines

        Merged revisions 97077 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r97077 | tilghman | 2008-01-08 12:02:13 -0600 (Tue, 08 Jan 2008) | 3 lines

        Apply multiple crash fixes, found in issue ASTERISK-10897, but not completely
        closing that issue.

        ........

        ................
        r97153 | file | 2008-01-08 12:55:56 -0700 (Tue, 08 Jan 2008) | 12 lines

        Merged revisions 97152 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r97152 | file | 2008-01-08 15:53:52 -0400 (Tue, 08 Jan 2008) | 4 lines

        If no group has been provided to the GROUP_COUNT dialplan function then use the first one specific to the channel.
        (closes issue ASTERISK-10610)
        Reported by: m4him

        ........

        ................
        r97154 | file | 2008-01-08 13:06:52 -0700 (Tue, 08 Jan 2008) | 6 lines

        Move common code for setting T38 capabilities and fix a bug with fax detection in the SIP RTP read callback. It's still sort of silly... but more on that later.
        (closes issue ASTERISK-10758)
        Reported by: dimas
        Patches:
        sipt38prop.patch uploaded by dimas (license 88)

        ................
        r97193 | mmichelson | 2008-01-08 13:45:59 -0700 (Tue, 08 Jan 2008) | 17 lines

        Merged revisions 97192 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r97192 | mmichelson | 2008-01-08 14:42:07 -0600 (Tue, 08 Jan 2008) | 9 lines

        Making some changes designed to not allow for a corrupted mailstream for a vm_state.

        1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs.
        2. Make sure to always grab the persistent vm_state when mailstream access is necessary.
        3. Correct an incorrect return value in the init_mailstream function.

        (closes issue ASTERISK-10818, reported by dwhite)

        ........

        ................
        r97196 | file | 2008-01-08 13:50:57 -0700 (Tue, 08 Jan 2008) | 14 lines

        Merged revisions 97195 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r97195 | file | 2008-01-08 16:48:20 -0400 (Tue, 08 Jan 2008) | 6 lines

        Fix various DTMF issues in chan_mgcp.
        (closes issue ASTERISK-10954)
        Reported by: eferro
        Patches:
        dtmf_control_hybrid-inband-mode.patch uploaded by eferro (license 337)

        ........

        ................
        r97197 | file | 2008-01-08 13:52:07 -0700 (Tue, 08 Jan 2008) | 2 lines

        One line documentation ftw!

        ................
        r97198 | tilghman | 2008-01-08 13:56:38 -0700 (Tue, 08 Jan 2008) | 11 lines

        Merged revisions 97194 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r97194 | tilghman | 2008-01-08 14:47:07 -0600 (Tue, 08 Jan 2008) | 3 lines

        Increase constants to where we're less likely to hit them while debugging.
        (Closes issue ASTERISK-11165)

        ........

        ................
        r97199 | oej | 2008-01-08 13:58:56 -0700 (Tue, 08 Jan 2008) | 2 lines

        Iksemel is alive in a new home. Release 1.3 is out with bug fixes.

        ................
        r97200 | oej | 2008-01-08 14:01:46 -0700 (Tue, 08 Jan 2008) | 4 lines

        Change reference to external library so it appears on the extref listing
        http://www.asterisk.org/doxygen/trunk/extref.html

        ................
        r97203 | mmichelson | 2008-01-08 14:18:32 -0700 (Tue, 08 Jan 2008) | 8 lines

        Adding the option of specifying a second interface in a member definition for a queue. app_queue
        will monitor this second device's state for the member, even though it actually calls the first
        interface. This ability has been added for statically defined queue members, realtime queue members,
        and dynamic queue members added through the CLI, dialplan, or manager.

        (closes issue ASTERISK-11085, reported by acidv)

        ................
        r97208 | mmichelson | 2008-01-08 14:28:04 -0700 (Tue, 08 Jan 2008) | 10 lines

        Blocked revisions 97206 via svnmerge

        ........
        r97206 | mmichelson | 2008-01-08 15:24:48 -0600 (Tue, 08 Jan 2008) | 3 lines

        Some coding guidelines-related cleanup

        ........

        ................
        r97248 | twilson | 2008-01-08 14:56:57 -0700 (Tue, 08 Jan 2008) | 2 lines

        Initialize new variable to NULL

        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=97535

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 97535 _U team/murf/bug11210/ U team/murf/bug11210/CHANGES U team/murf/bug11210/apps/app_queue.c U team/murf/bug11210/apps/app_voicemail.c U team/murf/bug11210/channels/chan_console.c U team/murf/bug11210/channels/chan_mgcp.c U team/murf/bug11210/channels/chan_sip.c U team/murf/bug11210/configs/queues.conf.sample U team/murf/bug11210/funcs/func_groupcount.c U team/murf/bug11210/main/asterisk.c U team/murf/bug11210/main/autoservice.c U team/murf/bug11210/main/utils.c U team/murf/bug11210/res/res_jabber.c ------------------------------------------------------------------------ r97535 | murf | 2008-01-09 12:20:51 -0600 (Wed, 09 Jan 2008) | 140 lines Merged revisions 97125,97153-97154,97193,97196-97200,97203,97208,97248 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r97125 | tilghman | 2008-01-08 12:06:27 -0700 (Tue, 08 Jan 2008) | 11 lines Merged revisions 97077 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97077 | tilghman | 2008-01-08 12:02:13 -0600 (Tue, 08 Jan 2008) | 3 lines Apply multiple crash fixes, found in issue ASTERISK-10897 , but not completely closing that issue. ........ ................ r97153 | file | 2008-01-08 12:55:56 -0700 (Tue, 08 Jan 2008) | 12 lines Merged revisions 97152 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97152 | file | 2008-01-08 15:53:52 -0400 (Tue, 08 Jan 2008) | 4 lines If no group has been provided to the GROUP_COUNT dialplan function then use the first one specific to the channel. (closes issue ASTERISK-10610 ) Reported by: m4him ........ ................ r97154 | file | 2008-01-08 13:06:52 -0700 (Tue, 08 Jan 2008) | 6 lines Move common code for setting T38 capabilities and fix a bug with fax detection in the SIP RTP read callback. It's still sort of silly... but more on that later. (closes issue ASTERISK-10758 ) Reported by: dimas Patches: sipt38prop.patch uploaded by dimas (license 88) ................ r97193 | mmichelson | 2008-01-08 13:45:59 -0700 (Tue, 08 Jan 2008) | 17 lines Merged revisions 97192 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97192 | mmichelson | 2008-01-08 14:42:07 -0600 (Tue, 08 Jan 2008) | 9 lines Making some changes designed to not allow for a corrupted mailstream for a vm_state. 1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs. 2. Make sure to always grab the persistent vm_state when mailstream access is necessary. 3. Correct an incorrect return value in the init_mailstream function. (closes issue ASTERISK-10818 , reported by dwhite) ........ ................ r97196 | file | 2008-01-08 13:50:57 -0700 (Tue, 08 Jan 2008) | 14 lines Merged revisions 97195 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97195 | file | 2008-01-08 16:48:20 -0400 (Tue, 08 Jan 2008) | 6 lines Fix various DTMF issues in chan_mgcp. (closes issue ASTERISK-10954 ) Reported by: eferro Patches: dtmf_control_hybrid-inband-mode.patch uploaded by eferro (license 337) ........ ................ r97197 | file | 2008-01-08 13:52:07 -0700 (Tue, 08 Jan 2008) | 2 lines One line documentation ftw! ................ r97198 | tilghman | 2008-01-08 13:56:38 -0700 (Tue, 08 Jan 2008) | 11 lines Merged revisions 97194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r97194 | tilghman | 2008-01-08 14:47:07 -0600 (Tue, 08 Jan 2008) | 3 lines Increase constants to where we're less likely to hit them while debugging. (Closes issue ASTERISK-11165 ) ........ ................ r97199 | oej | 2008-01-08 13:58:56 -0700 (Tue, 08 Jan 2008) | 2 lines Iksemel is alive in a new home. Release 1.3 is out with bug fixes. ................ r97200 | oej | 2008-01-08 14:01:46 -0700 (Tue, 08 Jan 2008) | 4 lines Change reference to external library so it appears on the extref listing http://www.asterisk.org/doxygen/trunk/extref.html ................ r97203 | mmichelson | 2008-01-08 14:18:32 -0700 (Tue, 08 Jan 2008) | 8 lines Adding the option of specifying a second interface in a member definition for a queue. app_queue will monitor this second device's state for the member, even though it actually calls the first interface. This ability has been added for statically defined queue members, realtime queue members, and dynamic queue members added through the CLI, dialplan, or manager. (closes issue ASTERISK-11085 , reported by acidv) ................ r97208 | mmichelson | 2008-01-08 14:28:04 -0700 (Tue, 08 Jan 2008) | 10 lines Blocked revisions 97206 via svnmerge ........ r97206 | mmichelson | 2008-01-08 15:24:48 -0600 (Tue, 08 Jan 2008) | 3 lines Some coding guidelines-related cleanup ........ ................ r97248 | twilson | 2008-01-08 14:56:57 -0700 (Tue, 08 Jan 2008) | 2 lines Initialize new variable to NULL ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=97535

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development