Summary: | ASTERISK-11009: unanswered=no (cdr.conf) has no effect. | ||
Reporter: | Yuri (ys) | Labels: | |
Date Opened: | 2007-12-11 05:51:58.000-0600 | Date Closed: | 2008-03-10 09:34:08 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | CDR/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) branch_1.4_cdr.diff | |
Description: | This is feedback issue. In asterisk 1.4.15, murf, added new "unanswered" variabe to cdr.conf and make some changes in apps/app_dial.c Now, cdr logs all line attempted what marked as NO ANSWER, with no destination channel name, independently of "unanswered" value. For example, dial: exten => 100,1,Dial(SIP/3100|SIP/3101|SIP/3102,300,To) put in cdr at least 2 empty entry in all cases. ****** ADDITIONAL INFORMATION ****** http://svn.digium.com/view/asterisk/branches/1.4/apps/app_dial.c?r1=84166&r2=89622 | ||
Comments: | By: Yuri (ys) 2007-12-11 05:57:30.000-0600 Also, unanswered call from queue make "empty" cdr record too. By: Yuri (ys) 2007-12-11 06:08:10.000-0600 And, I think, what apps/app_dial.c is not best choise set. How about unanswered cdr record from other apps? May be better move this checking to main/cdr.c ? By: Yuri (ys) 2007-12-11 06:25:16.000-0600 I upload patch, that I use to resolve this problem. By: anest (anest) 2007-12-11 13:33:46.000-0600 thank you ys, we was waiting for this fix so loooong time! i hope it will be added to trunk. By: Yuri (ys) 2007-12-22 12:06:11.000-0600 ping() By: Jim Capp (jcapp) 2008-02-01 10:11:07.000-0600 I have verified this patch works on 1.4.18-rc4 as described. I tested various combinations of unanswered=yes, unanswered=no, and ;unanswered=no, all worked as expected. Good job folks! By: Marco Cintolesi (dartvader) 2008-02-15 09:44:20.000-0600 The patch is working also for us...anyone can merge this to the branch 14. or trunk ? By: Yuri (ys) 2008-02-17 14:08:23.000-0600 "assigned to murf" I wait him comment. By: anest (anest) 2008-03-08 02:08:41.000-0600 patch working well, please add it to trunk! By: Digium Subversion (svnbot) 2008-03-10 09:29:10 Repository: asterisk Revision: 107016 U branches/1.4/apps/app_dial.c U branches/1.4/include/asterisk/cdr.h U branches/1.4/main/cdr.c ------------------------------------------------------------------------ r107016 | file | 2008-03-10 09:29:07 -0500 (Mon, 10 Mar 2008) | 7 lines Move where unanswered CDRs are dropped to the CDR core, not everything uses app_dial. (closes issue ASTERISK-11009) Reported by: ys Patches: branch_1.4_cdr.diff uploaded by ys (license 281) Tested by: anest, jcapp, dartvader ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107016 By: Digium Subversion (svnbot) 2008-03-10 09:32:25 Repository: asterisk Revision: 107017 _U trunk/ U trunk/apps/app_dial.c U trunk/include/asterisk/cdr.h U trunk/main/cdr.c ------------------------------------------------------------------------ r107017 | file | 2008-03-10 09:32:24 -0500 (Mon, 10 Mar 2008) | 15 lines Merged revisions 107016 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r107016 | file | 2008-03-10 11:33:02 -0300 (Mon, 10 Mar 2008) | 7 lines Move where unanswered CDRs are dropped to the CDR core, not everything uses app_dial. (closes issue ASTERISK-11009) Reported by: ys Patches: branch_1.4_cdr.diff uploaded by ys (license 281) Tested by: anest, jcapp, dartvader ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107017 By: Digium Subversion (svnbot) 2008-03-10 09:34:08 Repository: asterisk Revision: 107018 _U branches/1.6.0/ U branches/1.6.0/apps/app_dial.c U branches/1.6.0/include/asterisk/cdr.h U branches/1.6.0/main/cdr.c ------------------------------------------------------------------------ r107018 | file | 2008-03-10 09:34:08 -0500 (Mon, 10 Mar 2008) | 23 lines Merged revisions 107017 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r107017 | file | 2008-03-10 11:36:16 -0300 (Mon, 10 Mar 2008) | 15 lines Merged revisions 107016 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r107016 | file | 2008-03-10 11:33:02 -0300 (Mon, 10 Mar 2008) | 7 lines Move where unanswered CDRs are dropped to the CDR core, not everything uses app_dial. (closes issue ASTERISK-11009) Reported by: ys Patches: branch_1.4_cdr.diff uploaded by ys (license 281) Tested by: anest, jcapp, dartvader ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=107018 |