Asterisk
  1. Asterisk
  2. ASTERISK-11033

chan_sip updates route set on re-invites, which is not allowed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • SVN Revision Number:
      92855
    • Mantis ID:
      11545
    • Regression:
      No

      Description

      We sometimes get calls disconnected when reinvite is enabled.

      Our provider suggested a patch (attached).

                • ADDITIONAL INFORMATION ******

      We have calls coming in from and going out to the same provider.

      We identified reinvite as a Good Thing in that it lets us drop out of the RTP stream.

      All worked well until our provider got extra machines so more IP addresses were involved in the conversation - we started to get some calls drop when the reinvite kicked in.

      Attached is a sample disconnected call (pre-patch), and the patch that fixed the problem.

      I'm not a SIP expert, so I apologise if this is a dupe bug, or if the patch is not SIP compliant. It does seem to work though, and the nice people on #asterisk suggested I post it.

      Our provider does think the current implementation is broken - "it certainly appears that Asterisk has broken re-invites and ignores the record route when sending the ACK."

      Hope this helps.

      1. broken-reinvite.txt
        41 kB
      2. reinvite-patch.txt
        0.6 kB
        Matt King, M.A. Oxon.

        Activity

        Hide
        Ronald Chan added a comment -

        reinvite-patch.txt patch appears to be missing?

        Show
        Ronald Chan added a comment - reinvite-patch.txt patch appears to be missing?
        Hide
        Jared Smith added a comment -

        loloski,

        The reinvite-patch.txt file has been uploaded, but his license is pending, so it won't show up until his license has been approved.

        Show
        Jared Smith added a comment - loloski, The reinvite-patch.txt file has been uploaded, but his license is pending, so it won't show up until his license has been approved.
        Hide
        Olle Johansson added a comment -

        There are related bug reports about not updating the route table after the initial call setup. This is a duplicate.

        A very good catch though. Propably needs fixing in 1.4 too.

        Show
        Olle Johansson added a comment - There are related bug reports about not updating the route table after the initial call setup. This is a duplicate. A very good catch though. Propably needs fixing in 1.4 too.
        Hide
        Matt King, M.A. Oxon. added a comment -

        Yes I can confirm it's broken in 1.4 (which is what we run in production).

        Show
        Matt King, M.A. Oxon. added a comment - Yes I can confirm it's broken in 1.4 (which is what we run in production).
        Hide
        Joshua Colp added a comment -

        Fixed in 1.4 as of revision 98955 and trunk as of revision 98956.

        Show
        Joshua Colp added a comment - Fixed in 1.4 as of revision 98955 and trunk as of revision 98956.

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development