[Home]

Summary:ASTERISK-11323: [PATCH] Device state is incorrect on incoming call on FXO channel
Reporter:Julian J. M. (julianjm)Labels:
Date Opened:2008-01-29 12:04:37.000-0600Date Closed:2008-02-19 12:36:15.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_zap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_zap.c-1.4-devicestate-v1.diff
Description:On an incoming call over an FXO port (FXS signalling), the device state is always Idle until the PBX answers the call. It should show "InUse".
The problem is that the channel is created directly with AST_STATE_RING state. Because ast_setstate() is not called again for this channel until answered (or hung up), the device state isn't updated accordingly.

The attached patch fixes this.

A phone with BLF will show a solid led as soon as a call enters the watched channel.

****** ADDITIONAL INFORMATION ******

[default]
exten => 9994,hint,Zap/4

[from-zaptel]
exten => s,1,Wait(15)
exten => s,n,Playback(demo-congrats)
exten => s,n,Hangup

During Wait(15) execution:

Before applying the patch
=========================
CLI> show hints
9994@default     : Zap/4                 State:Idle            Watchers  0

After applyting the patch
=========================
CLI> show hints
9994@default     : Zap/4                 State:InUse           Watchers  0
Comments:By: Digium Subversion (svnbot) 2008-02-19 12:11:28.000-0600

Repository: asterisk
Revision: 103818

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r103818 | jpeeler | 2008-02-19 12:11:27 -0600 (Tue, 19 Feb 2008) | 5 lines

(closes issue ASTERISK-11323)
Reported by: julianjm
Patches:
     chan_zap.c-1.4-devicestate-v1.diff uploaded by julianjm (license 99)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103818
By: Digium Subversion (svnbot) 2008-02-19 12:36:15.000-0600

Repository: asterisk
Revision: 103818

U   trunk/channels/chan_zap.c

------------------------------------------------------------------------
r103818 | jpeeler | 2008-02-19 12:14:56 -0600 (Tue, 19 Feb 2008) | 6 lines

(closes issue ASTERISK-11323)
Reported by: julianjm
Patches:
     chan_zap.c-1.4-devicestate-v1.diff uploaded by julianjm (license 99)
Patch fixes problem of device state incorrectly reporting idle before PBX answers incoming call on FXO channel. Device status is updated now during new channel creation.

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=103818
By: Richard Mudgett (rmudgett) 2011-06-28 12:40:21.790-0500

Committed to trunk -r325213

Merged revisions 325212 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r325212 | rmudgett | 2011-06-28 12:30:16 -0500 (Tue, 28 Jun 2011) | 7 lines

 Use the device name and not the channel name to initialize the device state.

 Correct ASTERISK-11323 implementation as I don't see how it ever worked as
 claimed when it used the channel name and not the device name.

 (issue ASTERISK-11323)
........