[Home]

Summary:ASTERISK-11473: [patch] Add the ability to forward a message with comment using IMAP storage.
Reporter:James Rothenberger (jaroth)Labels:
Date Opened:2008-02-19 09:58:17.000-0600Date Closed:2008-04-27 23:27:14
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Applications/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) forward_with_comment_v2.patch
( 1) forward_with_comment.patch
Description:This patch adds the ability to forward a message with comment using IMAP storage.  The IMAP message will contain two attachments - the first is the forwarding comment, and the second is the forwarded message.  When forwarding a forwarded message, the message and comment are concatenated, which allows for another forwarding comment (and still only two attachments in the IMAP email).  The email notifications also contain two attachments.
Comments:By: James Rothenberger (jaroth) 2008-02-19 09:58:47.000-0600

Patch is included.
By: Mark Michelson (mmichelson) 2008-04-02 10:17:48

I had been putting this off until the urgent message support was finished. That patch is now at the point where we just need to get sounds recorded, so I have now moved on to this patch.

I was attempting to update the attached patch so that it would apply cleanly to the current revision of trunk, but some of the failed hunks seemed as if they may have been made against a previously patched version of app_voicemail and so it was not clear how to modify trunk's app_voicemail to accommodate the failed hunks. If you could please upload an updated version of the patch, it would be much appreciated. Thank you.
By: James Rothenberger (jaroth) 2008-04-15 14:10:25

New patch uploaded.
By: Mark Michelson (mmichelson) 2008-04-22 18:21:17

This note is here to simply state that progress is being made on this issue. I have looked over the new patch and fixed a couple of compilation errors I was encountering. I will get this merged in as soon as possible.
By: Digium Subversion (svnbot) 2008-04-25 13:13:12

Repository: asterisk
Revision: 114656

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r114656 | mmichelson | 2008-04-25 13:13:12 -0500 (Fri, 25 Apr 2008) | 13 lines

This patch allows for forwarding a message with a "comment" attachment
if using IMAP storage for voicemail. The comment will be recorded and attached
as a second attachment in addition to the original message. This will be invoked
if you choose to prepend a message the way you would with file or ODBC storage


(closes issue ASTERISK-11473)
Reported by: jaroth
Patches:
     forward_with_comment_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114656
By: Digium Subversion (svnbot) 2008-04-25 13:14:48

Repository: asterisk
Revision: 114658

_U  branches/1.6.0/

------------------------------------------------------------------------
r114658 | mmichelson | 2008-04-25 13:14:47 -0500 (Fri, 25 Apr 2008) | 20 lines

Blocked revisions 114656 via svnmerge

........
r114656 | mmichelson | 2008-04-25 13:18:30 -0500 (Fri, 25 Apr 2008) | 13 lines

This patch allows for forwarding a message with a "comment" attachment
if using IMAP storage for voicemail. The comment will be recorded and attached
as a second attachment in addition to the original message. This will be invoked
if you choose to prepend a message the way you would with file or ODBC storage


(closes issue ASTERISK-11473)
Reported by: jaroth
Patches:
     forward_with_comment_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114658
By: Digium Subversion (svnbot) 2008-04-25 15:38:27

Repository: asterisk
Revision: 114669

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/apps/app_chanspy.c
U   team/seanbright/resolve-shadow-warnings/apps/app_dial.c
U   team/seanbright/resolve-shadow-warnings/apps/app_directed_pickup.c
U   team/seanbright/resolve-shadow-warnings/apps/app_externalivr.c
U   team/seanbright/resolve-shadow-warnings/apps/app_followme.c
U   team/seanbright/resolve-shadow-warnings/apps/app_minivm.c
U   team/seanbright/resolve-shadow-warnings/apps/app_parkandannounce.c
D   team/seanbright/resolve-shadow-warnings/apps/app_pickupchan.c
U   team/seanbright/resolve-shadow-warnings/apps/app_playback.c
U   team/seanbright/resolve-shadow-warnings/apps/app_queue.c
U   team/seanbright/resolve-shadow-warnings/apps/app_rpt.c
U   team/seanbright/resolve-shadow-warnings/apps/app_sms.c
U   team/seanbright/resolve-shadow-warnings/apps/app_speech_utils.c
U   team/seanbright/resolve-shadow-warnings/apps/app_voicemail.c
U   team/seanbright/resolve-shadow-warnings/apps/app_waitforring.c
U   team/seanbright/resolve-shadow-warnings/apps/app_zapscan.c
U   team/seanbright/resolve-shadow-warnings/main/app.c
U   team/seanbright/resolve-shadow-warnings/main/features.c

------------------------------------------------------------------------
r114669 | seanbright | 2008-04-25 15:38:05 -0500 (Fri, 25 Apr 2008) | 97 lines

Merged revisions 114650-114651,114655-114656,114660,114663,114665,114667 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r114650 | tilghman | 2008-04-25 11:58:36 -0400 (Fri, 25 Apr 2008) | 13 lines

Blocked revisions 114649 via svnmerge

........
r114649 | tilghman | 2008-04-25 10:53:52 -0500 (Fri, 25 Apr 2008) | 6 lines

Reference documentation files that actually exist.
(closes issue ASTERISK-11913)
Reported by: linuxmaniac
Patches:
      diff_rev114611.patch uploaded by linuxmaniac (license 472)

........

................
r114651 | mmichelson | 2008-04-25 12:25:17 -0400 (Fri, 25 Apr 2008) | 4 lines

Fix a memory leak and protect against potential dereferences of a NULL
pointer.


................
r114655 | russell | 2008-04-25 14:18:27 -0400 (Fri, 25 Apr 2008) | 10 lines

Merge code from team/russell/parking_updates

Add some additional features to the core park_call_full() function, and expose
them as options to the Park() application.  The functionality being added is the
ability to specify a custom return extension/context/priority, a custom timeout,
and a couple of options.  The options are to play ringing instead of MOH to the
parked caller, and to randomize parking spot selection.

(code inspired by the patch in AST-17, code from switchvox)

................
r114656 | mmichelson | 2008-04-25 14:18:30 -0400 (Fri, 25 Apr 2008) | 13 lines

This patch allows for forwarding a message with a "comment" attachment
if using IMAP storage for voicemail. The comment will be recorded and attached
as a second attachment in addition to the original message. This will be invoked
if you choose to prepend a message the way you would with file or ODBC storage


(closes issue ASTERISK-11473)
Reported by: jaroth
Patches:
     forward_with_comment_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth


................
r114660 | qwell | 2008-04-25 14:32:22 -0400 (Fri, 25 Apr 2008) | 12 lines

Merge app_pickupchan with app_directed_pickup, for AST-27.

Initially, this was to be a new feature, with a patch from Switchvox,
but after discussions, it was noted that this feature already existed in trunk.

The resulting discussions ended in a comment that was along the lines of
"the patch provided here is a lot smaller than what is already in trunk,
because it doesn't create a new application and duplicate existing code"

It was decided that these two applications could be easily merged to reduce
code duplication.  SO, that's what this does.

................
r114663 | mmichelson | 2008-04-25 15:33:27 -0400 (Fri, 25 Apr 2008) | 12 lines

Merged revisions 114662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114662 | mmichelson | 2008-04-25 14:32:02 -0500 (Fri, 25 Apr 2008) | 4 lines

Move the unlock of the spyee channel to outside the start_spying() function so that
the channel is not unlocked twice when using whisper mode.


........

................
r114665 | tilghman | 2008-04-25 15:39:26 -0400 (Fri, 25 Apr 2008) | 2 lines

Oops, this isn't necessarily AGI that is forking anymore

................
r114667 | tilghman | 2008-04-25 16:20:10 -0400 (Fri, 25 Apr 2008) | 2 lines

Whitespace changes only

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114669
By: Digium Subversion (svnbot) 2008-04-25 22:49:50

Repository: asterisk
Revision: 114686

_U  team/seanbright/res-jabber-astobj2/
U   team/seanbright/res-jabber-astobj2/CHANGES
U   team/seanbright/res-jabber-astobj2/apps/app_chanspy.c
U   team/seanbright/res-jabber-astobj2/apps/app_dial.c
U   team/seanbright/res-jabber-astobj2/apps/app_directed_pickup.c
U   team/seanbright/res-jabber-astobj2/apps/app_externalivr.c
U   team/seanbright/res-jabber-astobj2/apps/app_followme.c
U   team/seanbright/res-jabber-astobj2/apps/app_minivm.c
U   team/seanbright/res-jabber-astobj2/apps/app_parkandannounce.c
D   team/seanbright/res-jabber-astobj2/apps/app_pickupchan.c
U   team/seanbright/res-jabber-astobj2/apps/app_playback.c
U   team/seanbright/res-jabber-astobj2/apps/app_queue.c
U   team/seanbright/res-jabber-astobj2/apps/app_rpt.c
U   team/seanbright/res-jabber-astobj2/apps/app_sms.c
U   team/seanbright/res-jabber-astobj2/apps/app_speech_utils.c
U   team/seanbright/res-jabber-astobj2/apps/app_voicemail.c
U   team/seanbright/res-jabber-astobj2/apps/app_waitforring.c
U   team/seanbright/res-jabber-astobj2/apps/app_zapscan.c
U   team/seanbright/res-jabber-astobj2/channels/chan_iax2.c
U   team/seanbright/res-jabber-astobj2/channels/chan_sip.c
U   team/seanbright/res-jabber-astobj2/main/app.c
U   team/seanbright/res-jabber-astobj2/main/features.c
U   team/seanbright/res-jabber-astobj2/pbx/pbx_lua.c

------------------------------------------------------------------------
r114686 | seanbright | 2008-04-25 22:49:48 -0500 (Fri, 25 Apr 2008) | 146 lines

Merged revisions 114650-114651,114655-114656,114660,114663,114665,114667,114674,114676,114678,114683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r114650 | tilghman | 2008-04-25 11:58:36 -0400 (Fri, 25 Apr 2008) | 13 lines

Blocked revisions 114649 via svnmerge

........
r114649 | tilghman | 2008-04-25 10:53:52 -0500 (Fri, 25 Apr 2008) | 6 lines

Reference documentation files that actually exist.
(closes issue ASTERISK-11913)
Reported by: linuxmaniac
Patches:
      diff_rev114611.patch uploaded by linuxmaniac (license 472)

........

................
r114651 | mmichelson | 2008-04-25 12:25:17 -0400 (Fri, 25 Apr 2008) | 4 lines

Fix a memory leak and protect against potential dereferences of a NULL
pointer.


................
r114655 | russell | 2008-04-25 14:18:27 -0400 (Fri, 25 Apr 2008) | 10 lines

Merge code from team/russell/parking_updates

Add some additional features to the core park_call_full() function, and expose
them as options to the Park() application.  The functionality being added is the
ability to specify a custom return extension/context/priority, a custom timeout,
and a couple of options.  The options are to play ringing instead of MOH to the
parked caller, and to randomize parking spot selection.

(code inspired by the patch in AST-17, code from switchvox)

................
r114656 | mmichelson | 2008-04-25 14:18:30 -0400 (Fri, 25 Apr 2008) | 13 lines

This patch allows for forwarding a message with a "comment" attachment
if using IMAP storage for voicemail. The comment will be recorded and attached
as a second attachment in addition to the original message. This will be invoked
if you choose to prepend a message the way you would with file or ODBC storage


(closes issue ASTERISK-11473)
Reported by: jaroth
Patches:
     forward_with_comment_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth


................
r114660 | qwell | 2008-04-25 14:32:22 -0400 (Fri, 25 Apr 2008) | 12 lines

Merge app_pickupchan with app_directed_pickup, for AST-27.

Initially, this was to be a new feature, with a patch from Switchvox,
but after discussions, it was noted that this feature already existed in trunk.

The resulting discussions ended in a comment that was along the lines of
"the patch provided here is a lot smaller than what is already in trunk,
because it doesn't create a new application and duplicate existing code"

It was decided that these two applications could be easily merged to reduce
code duplication.  SO, that's what this does.

................
r114663 | mmichelson | 2008-04-25 15:33:27 -0400 (Fri, 25 Apr 2008) | 12 lines

Merged revisions 114662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114662 | mmichelson | 2008-04-25 14:32:02 -0500 (Fri, 25 Apr 2008) | 4 lines

Move the unlock of the spyee channel to outside the start_spying() function so that
the channel is not unlocked twice when using whisper mode.


........

................
r114665 | tilghman | 2008-04-25 15:39:26 -0400 (Fri, 25 Apr 2008) | 2 lines

Oops, this isn't necessarily AGI that is forking anymore

................
r114667 | tilghman | 2008-04-25 16:20:10 -0400 (Fri, 25 Apr 2008) | 2 lines

Whitespace changes only

................
r114674 | russell | 2008-04-25 18:00:35 -0400 (Fri, 25 Apr 2008) | 11 lines

Merged revisions 114673 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114673 | russell | 2008-04-25 16:54:40 -0500 (Fri, 25 Apr 2008) | 3 lines

Use consistent logic for checking to see if a call number has been chosen yet.
Also, remove some redundant logic I recently added in a fix.

........

................
r114676 | russell | 2008-04-25 18:04:46 -0400 (Fri, 25 Apr 2008) | 7 lines

Lock the channel around datastore access

(closes issue ASTERISK-11922)
Reported by: mnicholson
Patches:
     pbx_lua4.diff uploaded by mnicholson (license 96)

................
r114678 | mmichelson | 2008-04-25 18:24:32 -0400 (Fri, 25 Apr 2008) | 11 lines

Adding a new option, 'B' to app_chanspy. This option allows the spy to
barge on the call. It is like the existing whisper option, except that
it allows the spy to talk to both sides of the conversation on which
he is spying.

This feature has existed in Switchvox, and this merges the functionality
into Asterisk.

(AST-32)


................
r114683 | tilghman | 2008-04-25 22:48:56 -0400 (Fri, 25 Apr 2008) | 8 lines

Add 'sip qualify peer <peer>' command (with AMI SIPqualifypeer)
(closes issue ASTERISK-11920)
Reported by: ctooley
Patches:
      sip_qualify_peer.diff.2 uploaded by ctooley (license 136)
      some modifications for trunk by Corydon76
Tested by: Corydon76

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114686
By: Digium Subversion (svnbot) 2008-04-27 23:24:44

Repository: asterisk
Revision: 114706

U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r114706 | tilghman | 2008-04-27 23:24:42 -0500 (Sun, 27 Apr 2008) | 2 lines

Fix breakage caused by ASTERISK-11473.  (Closes issue ASTERISK-11928)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114706
By: Digium Subversion (svnbot) 2008-04-27 23:27:14

Repository: asterisk
Revision: 114707

_U  branches/1.6.0/

------------------------------------------------------------------------
r114707 | tilghman | 2008-04-27 23:27:13 -0500 (Sun, 27 Apr 2008) | 9 lines

Blocked revisions 114706 via svnmerge

........
r114706 | tilghman | 2008-04-27 23:30:02 -0500 (Sun, 27 Apr 2008) | 2 lines

Fix breakage caused by ASTERISK-11473.  (Closes issue ASTERISK-11928)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114707