Asterisk
  1. Asterisk
  2. ASTERISK-11556

menuselect - CORE-SOUNDS-EN-GSM cannot be replaced

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/BuildSystem
    • Labels:
      None
    • Mantis ID:
      12117
    • Regression:
      No

      Description

      If you build menuselect, and select CORE-SOUNDS-EN-WAV, then copy this into your .asterisk.makeopts file, then build Asterisk later from scratch, CORE-SOUNDS-EN-GSM always gets included anyway, even if you already have a core sound.

      If you do a "make distclean", then build again, your menuselect.makeopts file will contain:

      MENUSELECT_CORE_SOUNDS=CORE-SOUNDS-EN-GSM ...

      even if your ~/.asterisk.makeopts contained:

      MENUSELECT_CORE_SOUNDS=CORE-SOUNDS-EN-WAV

                • ADDITIONAL INFORMATION ******

      After investigation, it's because of the sequence in sounds/sounds.xml:

      <category name="MENUSELECT_CORE_SOUNDS" displayname="Core Sound Packages
      " positive_output="yes">
      ...
      <member name="CORE-SOUNDS-EN-GSM" displayname="English, GSM form
      at" >
      <defaultenabled>yes</defaultenabled>
      </member>
      ...

      which pretty much precludes any possibility of de-selecting CORE-SOUNDS-EN-GSM.

      Two possible solutions:

      1. provide a means of specifying in sounds/sounds.xml that several files belong to a group, and that one member of that group is mandatory;
      2. allow a user to specify:

      MENUSELECT_CORE_SOUNDS=CORE-SOUNDS-EN-WAV -CORE-SOUNDS-EN-GSM

      to prune the latter from the default inclusion explicitly.

        Activity

        Hide
        Tilghman Lesher added a comment -

        When you type 'make distclean', you are telling Asterisk to discard your choices and return to defaults. GSM sound files are a perfectly fine default.

        I don't see this as a bug.

        Show
        Tilghman Lesher added a comment - When you type 'make distclean', you are telling Asterisk to discard your choices and return to defaults. GSM sound files are a perfectly fine default. I don't see this as a bug.
        Hide
        Philip Prindeville added a comment -

        They are fine as a default, yes.

        But if you explicitly specify:

        MENUSELECT_CORE_SOUNDS=CORE-SOUNDS-EN-WAV

        you should get what you asked for, and not that plus the default. Defaults are exactly that: what you get when you don't specify a choice.

        Here, a choice was clearly indicated.

        Show
        Philip Prindeville added a comment - They are fine as a default, yes. But if you explicitly specify: MENUSELECT_CORE_SOUNDS=CORE-SOUNDS-EN-WAV you should get what you asked for, and not that plus the default. Defaults are exactly that: what you get when you don't specify a choice. Here, a choice was clearly indicated.
        Hide
        Philip Prindeville added a comment -

        Can the menuselect logic be changed to only add the default if a member of the same group (category::name) hasn't already been selected?

        Show
        Philip Prindeville added a comment - Can the menuselect logic be changed to only add the default if a member of the same group (category::name) hasn't already been selected?
        Hide
        Jason Parker added a comment -

        echo "MENUSELECT_CORE_SOUNDS=-CORE-SOUNDS-EN-GSM CORE-SOUNDS-EN-WAV" > menuselect.makeopts-test

        make USER_MAKEOPTS="menuselect.makeopts-test" menuselect.makeopts

        Something like the patch I just added should do the trick.. it worked when I tested it anyways.

        Show
        Jason Parker added a comment - echo "MENUSELECT_CORE_SOUNDS=-CORE-SOUNDS-EN-GSM CORE-SOUNDS-EN-WAV" > menuselect.makeopts-test make USER_MAKEOPTS="menuselect.makeopts-test" menuselect.makeopts Something like the patch I just added should do the trick.. it worked when I tested it anyways.
        Hide
        Philip Prindeville added a comment -

        I've backported this to 1.4.18 and tested it. Works well.

        Would be nice to see it in 1.6.

        Show
        Philip Prindeville added a comment - I've backported this to 1.4.18 and tested it. Works well. Would be nice to see it in 1.6.
        Hide
        Digium Subversion added a comment -

        Repository: menuselect
        Revision: 316

        U branches/1.0/menuselect.c

        ------------------------------------------------------------------------
        r316 | tilghman | 2008-05-05 15:05:50 -0500 (Mon, 05 May 2008) | 8 lines

        Support de-selecting default selections.
        (closes issue ASTERISK-11556)
        Reported by: pprindeville
        Patches:
        12117-menuselect-allownegation.diff uploaded by qwell (license 4)
        12117-menuselect-port-1.4.18.diff.txt uploaded by pprindeville (license 347)
        Tested by: pprindeville, qwell

        ------------------------------------------------------------------------

        http://svn.digium.com/view/menuselect?view=rev&revision=316

        Show
        Digium Subversion added a comment - Repository: menuselect Revision: 316 U branches/1.0/menuselect.c ------------------------------------------------------------------------ r316 | tilghman | 2008-05-05 15:05:50 -0500 (Mon, 05 May 2008) | 8 lines Support de-selecting default selections. (closes issue ASTERISK-11556 ) Reported by: pprindeville Patches: 12117-menuselect-allownegation.diff uploaded by qwell (license 4) 12117-menuselect-port-1.4.18.diff.txt uploaded by pprindeville (license 347) Tested by: pprindeville, qwell ------------------------------------------------------------------------ http://svn.digium.com/view/menuselect?view=rev&revision=316
        Hide
        Digium Subversion added a comment -

        Repository: menuselect
        Revision: 317

        _U trunk/
        U trunk/menuselect.c

        ------------------------------------------------------------------------
        r317 | tilghman | 2008-05-05 15:11:06 -0500 (Mon, 05 May 2008) | 21 lines

        Merged revisions 299,316 via svnmerge from
        https://origsvn.digium.com/svn/menuselect/branches/1.0

        ........
        r299 | kpfleming | 2008-03-26 11:12:24 -0500 (Wed, 26 Mar 2008) | 2 lines

        there is no need to generate this warning message

        ........
        r316 | tilghman | 2008-05-05 15:11:34 -0500 (Mon, 05 May 2008) | 8 lines

        Support de-selecting default selections.
        (closes issue ASTERISK-11556)
        Reported by: pprindeville
        Patches:
        12117-menuselect-allownegation.diff uploaded by qwell (license 4)
        12117-menuselect-port-1.4.18.diff.txt uploaded by pprindeville (license 347)
        Tested by: pprindeville, qwell

        ........

        ------------------------------------------------------------------------

        http://svn.digium.com/view/menuselect?view=rev&revision=317

        Show
        Digium Subversion added a comment - Repository: menuselect Revision: 317 _U trunk/ U trunk/menuselect.c ------------------------------------------------------------------------ r317 | tilghman | 2008-05-05 15:11:06 -0500 (Mon, 05 May 2008) | 21 lines Merged revisions 299,316 via svnmerge from https://origsvn.digium.com/svn/menuselect/branches/1.0 ........ r299 | kpfleming | 2008-03-26 11:12:24 -0500 (Wed, 26 Mar 2008) | 2 lines there is no need to generate this warning message ........ r316 | tilghman | 2008-05-05 15:11:34 -0500 (Mon, 05 May 2008) | 8 lines Support de-selecting default selections. (closes issue ASTERISK-11556 ) Reported by: pprindeville Patches: 12117-menuselect-allownegation.diff uploaded by qwell (license 4) 12117-menuselect-port-1.4.18.diff.txt uploaded by pprindeville (license 347) Tested by: pprindeville, qwell ........ ------------------------------------------------------------------------ http://svn.digium.com/view/menuselect?view=rev&revision=317

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development