[Home]

Summary:ASTERISK-11881: IAX2 dial string behavior patch
Reporter:jeffery palmer (darren1713)Labels:
Date Opened:2008-04-18 17:02:45Date Closed:2008-06-02 15:02:24
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) exten_dial_fix_chan_iax2.c.patch
Description:The dial string handling of IAX2 calls entirely ignores the incoming exten passed in the chan struct. Instead of falling down to the default "s" exten if nothing is in the "dest" pointer, first check if the chan struct has a valid extension to try, then fallback to the default "s" exten.

****** ADDITIONAL INFORMATION ******

This fixes a behavior problem between the handling of dialing strings coming through the Queues application, whereas zap and sip channels behave differently than iax channels.
Comments:By: Digium Subversion (svnbot) 2008-04-22 12:58:27

Repository: asterisk
Revision: 114537

U   branches/1.4/channels/chan_iax2.c

------------------------------------------------------------------------
r114537 | russell | 2008-04-22 12:58:25 -0500 (Tue, 22 Apr 2008) | 9 lines

If the dial string passed to the call channel callback does not indicate an
extension, then consider the extension on the channel before falling back
to the default.

(closes issue ASTERISK-11881)
Reported by: darren1713
Patches:
     exten_dial_fix_chan_iax2.c.patch uploaded by darren1713 (license 116)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114537

By: Digium Subversion (svnbot) 2008-04-22 12:59:22

Repository: asterisk
Revision: 114538

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r114538 | russell | 2008-04-22 12:59:21 -0500 (Tue, 22 Apr 2008) | 17 lines

Merged revisions 114537 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114537 | russell | 2008-04-22 13:03:33 -0500 (Tue, 22 Apr 2008) | 9 lines

If the dial string passed to the call channel callback does not indicate an
extension, then consider the extension on the channel before falling back
to the default.

(closes issue ASTERISK-11881)
Reported by: darren1713
Patches:
     exten_dial_fix_chan_iax2.c.patch uploaded by darren1713 (license 116)

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114538

By: Digium Subversion (svnbot) 2008-04-22 13:01:19

Repository: asterisk
Revision: 114539

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_iax2.c

------------------------------------------------------------------------
r114539 | russell | 2008-04-22 13:01:18 -0500 (Tue, 22 Apr 2008) | 25 lines

Merged revisions 114538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r114538 | russell | 2008-04-22 13:04:39 -0500 (Tue, 22 Apr 2008) | 17 lines

Merged revisions 114537 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114537 | russell | 2008-04-22 13:03:33 -0500 (Tue, 22 Apr 2008) | 9 lines

If the dial string passed to the call channel callback does not indicate an
extension, then consider the extension on the channel before falling back
to the default.

(closes issue ASTERISK-11881)
Reported by: darren1713
Patches:
     exten_dial_fix_chan_iax2.c.patch uploaded by darren1713 (license 116)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114539

By: Digium Subversion (svnbot) 2008-04-22 18:31:19

Repository: asterisk
Revision: 114570

_U  team/seanbright/resolve-shadow-warnings/
U   team/seanbright/resolve-shadow-warnings/apps/app_queue.c
U   team/seanbright/resolve-shadow-warnings/channels/chan_iax2.c
U   team/seanbright/resolve-shadow-warnings/include/asterisk/pbx.h
U   team/seanbright/resolve-shadow-warnings/main/channel.c
U   team/seanbright/resolve-shadow-warnings/main/pbx.c

------------------------------------------------------------------------
r114570 | seanbright | 2008-04-22 18:31:18 -0500 (Tue, 22 Apr 2008) | 113 lines

Merged revisions 114538,114540,114543,114546,114548,114551,114553,114559 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r114538 | russell | 2008-04-22 14:04:39 -0400 (Tue, 22 Apr 2008) | 17 lines

Merged revisions 114537 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114537 | russell | 2008-04-22 13:03:33 -0500 (Tue, 22 Apr 2008) | 9 lines

If the dial string passed to the call channel callback does not indicate an
extension, then consider the extension on the channel before falling back
to the default.

(closes issue ASTERISK-11881)
Reported by: darren1713
Patches:
     exten_dial_fix_chan_iax2.c.patch uploaded by darren1713 (license 116)

........

................
r114540 | qwell | 2008-04-22 14:14:09 -0400 (Tue, 22 Apr 2008) | 8 lines

Allow setqueuevar=yes (et al) to work, after changes to pbx_builtin_setvar()

(closes issue ASTERISK-11888)
Reported by: bcnit
Patches:
     12490-queuevars-3.diff uploaded by qwell (license 4)
Tested by: qwell

................
r114543 | russell | 2008-04-22 14:30:47 -0400 (Tue, 22 Apr 2008) | 10 lines

Blocked revisions 114542 via svnmerge

........
r114542 | russell | 2008-04-22 13:29:56 -0500 (Tue, 22 Apr 2008) | 3 lines

After a parked call times out, allow the call back to the parker to time out.
(closes issue ASTERISK-10449)

........

................
r114546 | russell | 2008-04-22 15:45:12 -0400 (Tue, 22 Apr 2008) | 9 lines

Blocked revisions 114545 via svnmerge

........
r114545 | russell | 2008-04-22 14:45:00 -0500 (Tue, 22 Apr 2008) | 2 lines

Trivial change to read the number of samples from a frame before calling ast_write()

........

................
r114548 | russell | 2008-04-22 16:25:56 -0400 (Tue, 22 Apr 2008) | 2 lines

re-add a fix that got lost with a recent change

................
r114551 | russell | 2008-04-22 17:15:41 -0400 (Tue, 22 Apr 2008) | 11 lines

Blocked revisions 114550 via svnmerge

........
r114550 | russell | 2008-04-22 16:14:55 -0500 (Tue, 22 Apr 2008) | 4 lines

I thought I was going to be able to leave 1.4 alone, but that was not the case.
I ran into some problems with G.722 in 1.4, so I have merged in all of the fixes
in this area that I have made in trunk/1.6.0, and things are happy again.

........

................
r114553 | murf | 2008-04-22 17:57:57 -0400 (Tue, 22 Apr 2008) | 14 lines


(closes issue ASTERISK-11872)
Reported by: triccyx

I had a bit a problem reproducing this in my setup (trying not to disturb my other stuff)
but finally, I got it. The problem appears to be that the extension is being added in
replace mode, which kinda assumes that the pattern trie has been formed, when in fact,
in this case, it was not. The checks being done are not nec. when the tree is not yet
formed, as changes like this will be summarized when the trie is formed in the future.

I tested the fix, and the crash no longer happens. Feel free to open the bug again if
this fix doesn't cure the problem.


................
r114559 | russell | 2008-04-22 18:17:31 -0400 (Tue, 22 Apr 2008) | 13 lines

Merged revisions 114558 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114558 | russell | 2008-04-22 17:15:36 -0500 (Tue, 22 Apr 2008) | 5 lines

When we receive a full frame that is supposed to contain our call number,
ensure that it has the correct one.
(closes issue ASTERISK-9772)
(AST-2008-006)

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=114570

By: Digium Subversion (svnbot) 2008-06-02 15:01:39

Repository: asterisk
Revision: 119838

U   branches/1.4/channels/chan_iax2.c

------------------------------------------------------------------------
r119838 | russell | 2008-06-02 15:01:37 -0500 (Mon, 02 Jun 2008) | 7 lines

Revert a change made for issue ASTERISK-11881.  This change caused a regression such that
a dial string such as (IAX2/foo) did not automatically fall back to dialing the 's'
extension anymore.

(closes issue ASTERISK-12133)
Reported by: dagmoller

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=119838

By: Digium Subversion (svnbot) 2008-06-02 15:02:02

Repository: asterisk
Revision: 119839

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r119839 | russell | 2008-06-02 15:02:01 -0500 (Mon, 02 Jun 2008) | 15 lines

Merged revisions 119838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r119838 | russell | 2008-06-02 15:08:04 -0500 (Mon, 02 Jun 2008) | 7 lines

Revert a change made for issue ASTERISK-11881.  This change caused a regression such that
a dial string such as (IAX2/foo) did not automatically fall back to dialing the 's'
extension anymore.

(closes issue ASTERISK-12133)
Reported by: dagmoller

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=119839

By: Digium Subversion (svnbot) 2008-06-02 15:02:24

Repository: asterisk
Revision: 119840

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_iax2.c

------------------------------------------------------------------------
r119840 | russell | 2008-06-02 15:02:22 -0500 (Mon, 02 Jun 2008) | 23 lines

Merged revisions 119839 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r119839 | russell | 2008-06-02 15:08:24 -0500 (Mon, 02 Jun 2008) | 15 lines

Merged revisions 119838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r119838 | russell | 2008-06-02 15:08:04 -0500 (Mon, 02 Jun 2008) | 7 lines

Revert a change made for issue ASTERISK-11881.  This change caused a regression such that
a dial string such as (IAX2/foo) did not automatically fall back to dialing the 's'
extension anymore.

(closes issue ASTERISK-12133)
Reported by: dagmoller

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=119840