Summary: | ASTERISK-11951: [patch] Manager SIPnotify command | ||
Reporter: | Michael FIG (michael-fig) | Labels: | |
Date Opened: | 2008-04-30 19:16:42 | Date Closed: | 2008-06-06 15:18:44 |
Priority: | Major | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_sip/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) 20080515__bug12562.diff.txt ( 1) asterisk-1.4.18.1-sip_notify-Content.diff | |
Description: | The attached patch allows dynamic sip NOTIFY packets to be sent from Asterisk. It changes the "sip notify" command to allow channel names to be specified, then uses the channel variables to expand a new "Content" field in the sip_notify.conf. ****** ADDITIONAL INFORMATION ****** Here is a sample sip_notify.conf stanza that uses the new features: [aastra-xml-push] Event=>aastra-xml Content-Type=>application-xml Content=>${AASTRA-XML} Then, a manager API application or dialplan rules can set the AASTRA-XML channel variable, followed by issuing a "sip notify ${CHANNEL-NAME}" to send the XML to the phone. I've made the patch against 1.4.18.1, and am hoping it will apply cleanly to trunk. It works for me, so I probably won't update it for trunk and hope somebody else can if it needs updating. | ||
Comments: | By: Tilghman Lesher (tilghman) 2008-05-15 10:52:12 I'm afraid I can't accept this patch, because you're using the Asterisk CLI for a manager command. The proper way to do something like this would be to invent a manager command for the purpose of sending a SIP notify. By: Tilghman Lesher (tilghman) 2008-05-15 11:37:01 Here is what I would propose instead: a standard Manager command that permits all fields in the notify to be customized, instead of relying on a template. By: Digium Subversion (svnbot) 2008-06-06 15:17:31 Repository: asterisk Revision: 121042 U trunk/CHANGES U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r121042 | tilghman | 2008-06-06 15:17:29 -0500 (Fri, 06 Jun 2008) | 6 lines Added a facility for sending arbitrary SIP notify commands from AMI. (closes issue ASTERISK-11951) Reported by: michael-fig Patches: 20080515__bug12562.diff.txt uploaded by Corydon76 (license 14) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=121042 By: Digium Subversion (svnbot) 2008-06-06 15:18:44 Repository: asterisk Revision: 121047 _U branches/1.6.0/ ------------------------------------------------------------------------ r121047 | tilghman | 2008-06-06 15:18:44 -0500 (Fri, 06 Jun 2008) | 13 lines Blocked revisions 121042 via svnmerge ........ r121042 | tilghman | 2008-06-06 15:24:11 -0500 (Fri, 06 Jun 2008) | 6 lines Added a facility for sending arbitrary SIP notify commands from AMI. (closes issue ASTERISK-11951) Reported by: michael-fig Patches: 20080515__bug12562.diff.txt uploaded by Corydon76 (license 14) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=121047 |