Summary:	ASTERISK-11976: Segmentation faults, looks to be related to issue 9520 (expire_register)
Reporter:	Andrew Smith (eurodrew555)	Labels:
Date Opened:	2008-05-06 06:39:29	Date Closed:	2008-06-27 17:36:22
Priority:	Critical	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Registration
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) backtrace.tar.gz ( 1) backtrace2.tar.gz
Description:	After upgrading to Asterisk SVN-branch-1.4-r114522M we get a 'Program terminated with signal 11, Segmentation fault' every 2-5 minutes. This does not happen on r114521M (which installs as r114322M).
Comments:	By: Andrew Smith (eurodrew555) 2008-05-06 06:48:38 backtrace.tar.gz uploaded gdb commands applied were: bt thread apply all bt By: Andrew Smith (eurodrew555) 2008-05-06 06:58:35 backtrace2.tar.gz uploaded - this is from a different core dump, and is a lot smaller. gdb commands applied were: bt bt full By: Andrew Smith (eurodrew555) 2008-05-06 07:01:16 /var/log/asterisk/debug just before backtrace2 crash [May  6 12:49:10] DEBUG[4698] res_config_mysql.c: MySQL RealTime: Everything is fine. [May  6 12:49:10] DEBUG[4698] res_config_mysql.c: MySQL RealTime: Retrieve SQL: SELECT * FROM sip2 WHERE name = 'asc63-c8119990' [May  6 12:49:12] DEBUG[4815] res_config_mysql.c: MySQL RealTime: Everything is fine. [May  6 12:49:12] DEBUG[4815] res_config_mysql.c: MySQL RealTime: Retrieve SQL: SELECT * FROM sip2 WHERE name = '2814' AND host = 'd ynamic' By: Andrew Smith (eurodrew555) 2008-05-06 07:03:18 /var/log/asterisk/messages just before backtrace2 crash [May  6 12:46:21] NOTICE[4815] chan_sip.c: Registration from 'sip:jak@local.com' failed for '10.30.0.81' - No matching peer foun d [May  6 12:47:08] WARNING[9270] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now [May  6 12:47:13] WARNING[9276] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now [May  6 12:47:13] WARNING[9277] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now [May  6 12:47:13] WARNING[9277] chan_sip.c: This function can only be used on SIP channels. [May  6 12:47:13] WARNING[9277] app_voicemail.c: No entry in voicemail config file for 'eu_voip_13' [May  6 12:47:18] NOTICE[4815] chan_sip.c: Call from 'nwh-trunk-sip-openser' to extension '1000kjj' rejected because extension not f ound. [May  6 12:47:21] WARNING[9289] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now [May  6 12:47:22] WARNING[9289] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now [May  6 12:48:47] NOTICE[4815] chan_sip.c: Received SIP subscribe for peer without mailbox: hianz [May  6 12:48:53] WARNING[10540] app_addon_sql_mysql.c: aMYSQL_query: mysql_query failed. Error: Commands out of sync; you can't run this command now By: Andrew Smith (eurodrew555) 2008-05-06 07:05:43 I have also noticed hundreds of messages like below in /var/log/messages, but this is NOT directly related to the two core dumps above, but may be related to others (not posted here as yet) [May  6 12:30:52] ERROR[10998] /usr/src/asterisk-svn-1.4/include/asterisk/lock.h: chan_iax2.c line 8344 (iax2_process_thread_cleanup ): Error destroying mutex &thread->lock: Device or resource busy By: Russell Bryant (russell) 2008-05-06 10:42:24 What activity is happening on the system when this crash occurs?  Is it just a bunch of SIP registrations using realtime? By: callguy (callguy) 2008-05-06 10:57:05 russell: this looks pretty similar to what we're seeing in bug 12555, in our case it happens when there are no calls processing at all - just sip registration activity that is always going on in the background. By: Andrew Smith (eurodrew555) 2008-05-06 11:32:05 On the second backtrace2.tar.gz the system is essentially idle with only registrations coming in (via an OpenSER SIP proxy) By: Andrew Smith (eurodrew555) 2008-05-06 11:33:32 Also excuse the MySQL errors, I am testing against another Asterisk 1.6 system hence the errors. I believe they are unrelated to this issue. By: Russell Bryant (russell) 2008-05-06 13:30:01 I am attempting to replicate the issue.  How many registrations do you guys have?  Also, what realtime related options are you using in sip.conf? By: Andrew Smith (eurodrew555) 2008-05-06 14:16:08 We have about 120 SIP peers, online each registering every 5 minutes. SIP peers register to a front-end OpenSER proxy, which then registers each SIP peer to 5x Asterisk servers (4x production-1.4, 1x test-1.6) I have seen as high as 30 to 40 simultaneous registrations queued for delivery to the Asterisk servers at one time. sip.conf realtime settings (or settings related to this issue) rtptimeout=60 rtpholdtimeout=300 rtcachefriends=yes rtupdate=no rtautoclear=yes ignoreregexpire=yes By: dtyoo (dtyoo) 2008-05-06 15:20:03 russell- I work with callguy and am responding on his behalf.  When we last experienced this issue it was on a server with roughly 1000 registered sip peers.  Endpoint registrations are set for 360 sec (mostly polycom ip endpoints).  Qualify is turned on for most of these peers.  Registrations are hitting the asterisk server directly, not going through an intervening proxy. The only relevant settings in sip.conf are: limitonpeers=yes rtcachefriends=yes Let me know if you need any other information. By: Russell Bryant (russell) 2008-05-07 10:50:14 Thanks for the feedback guys.  I will let you know how my testing goes.  I will be sure to resolve this issue before the release of 1.4.20. By: Digium Subversion (svnbot) 2008-05-07 13:11:34 Repository: asterisk Revision: 115517 U   branches/1.4/channels/chan_sip.c ------------------------------------------------------------------------ r115517 | russell | 2008-05-07 13:11:34 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription.  This fixes some realtime related crashes. (closes issue ASTERISK-11976) (closes issue ASTERISK-11945) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115517 By: Digium Subversion (svnbot) 2008-05-07 13:12:09 Repository: asterisk Revision: 115518 _U  trunk/ ------------------------------------------------------------------------ r115518 | russell | 2008-05-07 13:12:08 -0500 (Wed, 07 May 2008) | 12 lines Blocked revisions 115517 via svnmerge ........ r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription.  This fixes some realtime related crashes. (closes issue ASTERISK-11976) (closes issue ASTERISK-11945) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115518 By: Russell Bryant (russell) 2008-05-07 13:12:22 Please give those changes a test and let me know if it works for you.  I was able to reproduce the crashes, and those changes fixed it for me. By: Digium Subversion (svnbot) 2008-05-08 19:10:56 Repository: asterisk Revision: 115574 _U  team/seanbright/res-jabber-astobj2/ U   team/seanbright/res-jabber-astobj2/channels/chan_h323.c U   team/seanbright/res-jabber-astobj2/channels/chan_iax2.c U   team/seanbright/res-jabber-astobj2/channels/chan_sip.c U   team/seanbright/res-jabber-astobj2/channels/chan_zap.c U   team/seanbright/res-jabber-astobj2/contrib/init.d/rc.debian.asterisk U   team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldap-schema U   team/seanbright/res-jabber-astobj2/contrib/scripts/asterisk.ldif D   team/seanbright/res-jabber-astobj2/contrib/scripts/postgres_cdr.sql _U  team/seanbright/res-jabber-astobj2/include/asterisk/dlinkedlists.h U   team/seanbright/res-jabber-astobj2/main/pbx.c U   team/seanbright/res-jabber-astobj2/main/sched.c U   team/seanbright/res-jabber-astobj2/res/res_config_ldap.c U   team/seanbright/res-jabber-astobj2/res/res_odbc.c U   team/seanbright/res-jabber-astobj2/sounds/Makefile ------------------------------------------------------------------------ r115574 | seanbright | 2008-05-08 19:10:45 -0500 (Thu, 08 May 2008) | 243 lines Merged revisions 115507,115509,115513,115515,115518-115519,115521,115523,115525,115535,115537,115546,115548,115552,115555,115558,115562,115566,115569 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r115507 | file | 2008-05-07 09:41:25 -0400 (Wed, 07 May 2008) | 4 lines Remove redundant header getting. (closes issue ASTERISK-11984) Reported by: hooi ................ r115509 | tilghman | 2008-05-07 09:49:15 -0400 (Wed, 07 May 2008) | 6 lines Update typos in description fields (closes issue ASTERISK-11985) Reported by: suretec Patches:       asterisk_schema_changes.patch uploaded by suretec (license 70) ................ r115513 | russell | 2008-05-07 13:28:19 -0400 (Wed, 07 May 2008) | 19 lines Merged revisions 115512 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r115512 | russell | 2008-05-07 11:24:09 -0500 (Wed, 07 May 2008) | 11 lines Merged revisions 115511 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r115511 | russell | 2008-05-07 11:22:49 -0500 (Wed, 07 May 2008) | 3 lines Remove remnants of dlinkedlists.  I didn't actually use them in the final version of my IAX2 improvements. ........ ................ ................ r115515 | russell | 2008-05-07 13:38:36 -0400 (Wed, 07 May 2008) | 2 lines re-add dlinkedlists.h to trunk, oops! ................ r115518 | russell | 2008-05-07 14:17:43 -0400 (Wed, 07 May 2008) | 12 lines Blocked revisions 115517 via svnmerge ........ r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription.  This fixes some realtime related crashes. (closes issue ASTERISK-11976) (closes issue ASTERISK-11945) ........ ................ r115519 | russell | 2008-05-07 14:24:51 -0400 (Wed, 07 May 2008) | 2 lines Let chan_h323 build in dev mode ................ r115521 | russell | 2008-05-07 14:30:12 -0400 (Wed, 07 May 2008) | 7 lines Use the default that the log output claims will be used for the basedn (closes issue ASTERISK-11986) Reported by: suretec Patches:      12599.patch uploaded by juggie (license 24) ................ r115523 | russell | 2008-05-07 14:33:50 -0400 (Wed, 07 May 2008) | 6 lines Only save a password if a username exists. (closes issue ASTERISK-11987) Reported By: suretec Patch by me ................ r115525 | tilghman | 2008-05-07 14:40:21 -0400 (Wed, 07 May 2008) | 2 lines Don't free the object on destroy, as astobj2 takes care of that for you ................ r115535 | tilghman | 2008-05-07 16:22:09 -0400 (Wed, 07 May 2008) | 2 lines Advance to next sounds release ................ r115537 | russell | 2008-05-07 17:11:33 -0400 (Wed, 07 May 2008) | 10 lines Fix up a problem that was introduced into the scheduler when it was converted to use doubly linked lists.  The schedule() function had an optimization that had it try to guess which direction would be better for the traversal to insert the task into the scheduler queue.  However, if the code chose the path where it traversed the queue in reverse, and the result was that the task should be at the head of the queue, then the code would actually put it at the tail, instead. (Problem found by bbryant, debugged and fixed by bbryant and me) ................ r115546 | russell | 2008-05-08 10:41:12 -0400 (Thu, 08 May 2008) | 12 lines Merged revisions 115545 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115545 | russell | 2008-05-08 09:40:53 -0500 (Thu, 08 May 2008) | 4 lines Use the same method for executing Asterisk as the rest of the script. (closes issue ASTERISK-11997) Reported by: b_plessis ........ ................ r115548 | mattf | 2008-05-08 11:04:45 -0400 (Thu, 08 May 2008) | 1 line Remove unused code as well as demote an error message to a debug message ................ r115552 | russell | 2008-05-08 11:26:49 -0400 (Thu, 08 May 2008) | 12 lines Merged revisions 115551 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115551 | russell | 2008-05-08 10:24:54 -0500 (Thu, 08 May 2008) | 4 lines Don't use a channel before checking for channel allocation failure. (closes issue ASTERISK-11995) Reported by: edantie ........ ................ r115555 | russell | 2008-05-08 11:32:48 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115554 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115554 | russell | 2008-05-08 10:32:08 -0500 (Thu, 08 May 2008) | 3 lines Don't exit the script if Asterisk is not running. (closes issue ASTERISK-11997) ........ ................ r115558 | russell | 2008-05-08 11:38:27 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115557 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115557 | russell | 2008-05-08 10:37:49 -0500 (Thu, 08 May 2008) | 3 lines remove postgres_cdr.sql, as the CDR schema is in realtime_pgsql.sql, as well (closes issue ASTERISK-9393) ........ ................ r115562 | russell | 2008-05-08 12:14:08 -0400 (Thu, 08 May 2008) | 11 lines Merged revisions 115561 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115561 | russell | 2008-05-08 11:11:33 -0500 (Thu, 08 May 2008) | 3 lines Don't give up on attempting an outbound registration if we receive a 408 Timeout. (closes issue ASTERISK-11744) ........ ................ r115566 | russell | 2008-05-08 15:17:04 -0400 (Thu, 08 May 2008) | 41 lines Merged revisions 115565 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r115565 | russell | 2008-05-08 14:15:25 -0500 (Thu, 08 May 2008) | 33 lines Merged revisions 115564 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r115564 | russell | 2008-05-08 14:14:04 -0500 (Thu, 08 May 2008) | 25 lines Fix a race condition that bbryant just found while doing some IAX2 testing. He was running Asterisk trunk running IAX2 calls through a few Asterisk boxes, however, the audio was extremely choppy.  We looked at a packet trace and saw a storm of INVAL and VNAK frames being sent from one box to another. It turned out that what had happened was that one box tried to send a CONTROL frame before the 3 way handshake had completed.  So, that frame did not include the destination call number, because it didn't have it yet.  Part of our recent work for security issues included an additional check to ensure that frames that are supposed to include the destination call number have the correct one.  This caused the frame to be rejected with an INVAL.  The frame would get retransmitted for forever, rejected every time ... This race condition exists in all versions that got the security changes, in theory.  However, it is really only likely that this would cause a problem in Asterisk trunk.  There was a control frame being sent (SRCUPDATE) at the _very_ beginning of the call, which does not exist in 1.2 or 1.4.  However, I am fixing all versions that could potentially be affected by the introduced race condition. These changes are what bbryant and I came up with to fix the issue.  Instead of simply dropping control frames that get sent before the handshake is complete, the code attempts to wait a little while, since in most cases, the handshake will complete very quickly.  If it doesn't complete after yielding for a little while, then the frame gets dropped. ........ ................ ................ r115569 | russell | 2008-05-08 15:20:35 -0400 (Thu, 08 May 2008) | 10 lines Merged revisions 115568 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r115568 | russell | 2008-05-08 14:19:50 -0500 (Thu, 08 May 2008) | 2 lines Remove debug output. ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115574 By: Digium Subversion (svnbot) 2008-05-13 13:31:28 Repository: asterisk Revision: 115885 _U  team/group/newcdr/ U   team/group/newcdr/channels/chan_h323.c U   team/group/newcdr/channels/chan_iax2.c U   team/group/newcdr/channels/chan_sip.c U   team/group/newcdr/contrib/scripts/asterisk.ldap-schema U   team/group/newcdr/contrib/scripts/asterisk.ldif _U  team/group/newcdr/include/asterisk/dlinkedlists.h U   team/group/newcdr/main/sched.c U   team/group/newcdr/res/res_config_ldap.c U   team/group/newcdr/res/res_odbc.c U   team/group/newcdr/sounds/Makefile ------------------------------------------------------------------------ r115885 | murf | 2008-05-13 13:31:15 -0500 (Tue, 13 May 2008) | 110 lines Merged revisions 115507,115509,115513,115515,115518-115519,115521,115523,115525,115535,115537 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r115507 | file | 2008-05-07 07:41:25 -0600 (Wed, 07 May 2008) | 4 lines Remove redundant header getting. (closes issue ASTERISK-11984) Reported by: hooi ................ r115509 | tilghman | 2008-05-07 07:49:15 -0600 (Wed, 07 May 2008) | 6 lines Update typos in description fields (closes issue ASTERISK-11985) Reported by: suretec Patches:       asterisk_schema_changes.patch uploaded by suretec (license 70) ................ r115513 | russell | 2008-05-07 11:28:19 -0600 (Wed, 07 May 2008) | 19 lines Merged revisions 115512 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r115512 | russell | 2008-05-07 11:24:09 -0500 (Wed, 07 May 2008) | 11 lines Merged revisions 115511 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r115511 | russell | 2008-05-07 11:22:49 -0500 (Wed, 07 May 2008) | 3 lines Remove remnants of dlinkedlists.  I didn't actually use them in the final version of my IAX2 improvements. ........ ................ ................ r115515 | russell | 2008-05-07 11:38:36 -0600 (Wed, 07 May 2008) | 2 lines re-add dlinkedlists.h to trunk, oops! ................ r115518 | russell | 2008-05-07 12:17:43 -0600 (Wed, 07 May 2008) | 12 lines Blocked revisions 115517 via svnmerge ........ r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription.  This fixes some realtime related crashes. (closes issue ASTERISK-11976) (closes issue ASTERISK-11945) ........ ................ r115519 | russell | 2008-05-07 12:24:51 -0600 (Wed, 07 May 2008) | 2 lines Let chan_h323 build in dev mode ................ r115521 | russell | 2008-05-07 12:30:12 -0600 (Wed, 07 May 2008) | 7 lines Use the default that the log output claims will be used for the basedn (closes issue ASTERISK-11986) Reported by: suretec Patches:      12599.patch uploaded by juggie (license 24) ................ r115523 | russell | 2008-05-07 12:33:50 -0600 (Wed, 07 May 2008) | 6 lines Only save a password if a username exists. (closes issue ASTERISK-11987) Reported By: suretec Patch by me ................ r115525 | tilghman | 2008-05-07 12:40:21 -0600 (Wed, 07 May 2008) | 2 lines Don't free the object on destroy, as astobj2 takes care of that for you ................ r115535 | tilghman | 2008-05-07 14:22:09 -0600 (Wed, 07 May 2008) | 2 lines Advance to next sounds release ................ r115537 | russell | 2008-05-07 15:11:33 -0600 (Wed, 07 May 2008) | 10 lines Fix up a problem that was introduced into the scheduler when it was converted to use doubly linked lists.  The schedule() function had an optimization that had it try to guess which direction would be better for the traversal to insert the task into the scheduler queue.  However, if the code chose the path where it traversed the queue in reverse, and the result was that the task should be at the head of the queue, then the code would actually put it at the tail, instead. (Problem found by bbryant, debugged and fixed by bbryant and me) ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=115885 By: Digium Subversion (svnbot) 2008-06-27 17:36:22 Repository: asterisk Revision: 126112 _U  branches/1.6.0/ ------------------------------------------------------------------------ r126112 | tilghman | 2008-06-27 17:36:14 -0500 (Fri, 27 Jun 2008) | 286 lines Blocked revisions 114174,114298,115258,115518,117524,117812,118059,119077,120063,120372,120672,120732,121993,122315,122434,122616,122664,124744,124909,125894 via svnmerge ................ r114174 | qwell | 2008-04-16 12:31:02 -0500 (Wed, 16 Apr 2008) | 14 lines Blocked revisions 114173 via svnmerge ........ r114173 | qwell | 2008-04-16 12:30:09 -0500 (Wed, 16 Apr 2008) | 7 lines Fix "fallthrough" behavior here, so config options in a previously configured user don't override settings in general. (closes issue ASTERISK-11863) Reported by: tzafrir Patches:      chanzap_users_sections.diff uploaded by tzafrir (license 46) ........ ................ r114298 | tilghman | 2008-04-19 08:53:38 -0500 (Sat, 19 Apr 2008) | 11 lines Blocked revisions 114297 via svnmerge ........ r114297 | tilghman | 2008-04-19 08:49:50 -0500 (Sat, 19 Apr 2008) | 4 lines MOH usage information needs a terminating newline, or else "asterisk -rx 'help moh reload'" will hang.  Reported via -dev list, fixed by me. ........ ................ r115258 | bbryant | 2008-05-02 15:26:00 -0500 (Fri, 02 May 2008) | 9 lines Blocked revisions 115257 via svnmerge ........ r115257 | bbryant | 2008-05-02 15:25:42 -0500 (Fri, 02 May 2008) | 2 lines Add new "pri show version" command to show the libpri version for support reasons. ........ ................ r115518 | russell | 2008-05-07 13:17:43 -0500 (Wed, 07 May 2008) | 12 lines Blocked revisions 115517 via svnmerge ........ r115517 | russell | 2008-05-07 13:17:19 -0500 (Wed, 07 May 2008) | 5 lines Track peer references when stored in the sip_pvt struct as the peer related to a qualify ping or a subscription.  This fixes some realtime related crashes. (closes issue ASTERISK-11976) (closes issue ASTERISK-11945) ........ ................ r117524 | tilghman | 2008-05-21 13:45:26 -0500 (Wed, 21 May 2008) | 9 lines Blocked revisions 117523 via svnmerge ........ r117523 | tilghman | 2008-05-21 13:44:53 -0500 (Wed, 21 May 2008) | 2 lines Revert accidental commit of the last change ........ ................ r117812 | tilghman | 2008-05-22 11:50:32 -0500 (Thu, 22 May 2008) | 13 lines Blocked revisions 117809 via svnmerge ........ r117809 | tilghman | 2008-05-22 11:47:03 -0500 (Thu, 22 May 2008) | 6 lines Take into account the length of delimiters when calculating result string length. (closes issue ASTERISK-12059) Reported by: adomjan Patches:       func_realtime.c-longdelimiter.patch uploaded by adomjan (license 487) ........ ................ r118059 | tilghman | 2008-05-23 08:20:13 -0500 (Fri, 23 May 2008) | 9 lines Blocked revisions 118055 via svnmerge ........ r118055 | tilghman | 2008-05-23 08:18:44 -0500 (Fri, 23 May 2008) | 2 lines Add format type checking for recently de-inlined function ........ ................ r119077 | russell | 2008-05-29 15:49:48 -0500 (Thu, 29 May 2008) | 10 lines Blocked revisions 119076 via svnmerge ........ r119076 | russell | 2008-05-29 15:48:33 -0500 (Thu, 29 May 2008) | 3 lines Oddly enough, all of the contents of audiohook.h were in there twice.  I have removed the second copy. ........ ................ r120063 | tilghman | 2008-06-03 13:24:14 -0500 (Tue, 03 Jun 2008) | 15 lines Blocked revisions 120061 via svnmerge ........ r120061 | tilghman | 2008-06-03 13:23:32 -0500 (Tue, 03 Jun 2008) | 8 lines When listing the manager users, managers in users.conf are not shown, even though they are allowed to connect. (closes issue ASTERISK-11982) Reported by: bkruse Patches:       12594-managerusers-2.diff uploaded by qwell (license 4) Tested by: bkruse ........ ................ r120372 | russell | 2008-06-04 11:28:37 -0500 (Wed, 04 Jun 2008) | 11 lines Blocked revisions 120371 via svnmerge ........ r120371 | russell | 2008-06-04 11:26:43 -0500 (Wed, 04 Jun 2008) | 4 lines Make the "dialplan remove include" CLI command actually work.  Also, tweak some formatting, and make the success message a little bit more clear. (closes AST-52) ........ ................ r120672 | russell | 2008-06-05 11:39:25 -0500 (Thu, 05 Jun 2008) | 12 lines Blocked revisions 120671 via svnmerge ........ r120671 | russell | 2008-06-05 11:38:52 -0500 (Thu, 05 Jun 2008) | 5 lines It turns out that searching on the forwarding station isn't very useful for most people, so pull in the changes that allow searching for SMDI messages based on other components of the SMDI message.  Also, update the SMDI documentation. ........ ................ r120732 | russell | 2008-06-05 13:01:45 -0500 (Thu, 05 Jun 2008) | 9 lines Blocked revisions 120731 via svnmerge ........ r120731 | russell | 2008-06-05 13:01:25 -0500 (Thu, 05 Jun 2008) | 2 lines Add the UPGRADE.txt file from Asterisk 1.2, for handy reference. ........ ................ r121993 | twilson | 2008-06-11 18:48:38 -0500 (Wed, 11 Jun 2008) | 9 lines Blocked revisions 121992 via svnmerge ........ r121992 | twilson | 2008-06-11 18:47:23 -0500 (Wed, 11 Jun 2008) | 2 lines Backport fix for 11520--for some reason I didn't do this back in February when I patched for trunk. ........ ................ r122315 | jpeeler | 2008-06-12 14:11:23 -0500 (Thu, 12 Jun 2008) | 9 lines Blocked revisions 122314 via svnmerge ........ r122314 | jpeeler | 2008-06-12 14:08:20 -0500 (Thu, 12 Jun 2008) | 2 lines Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow. ........ ................ r122434 | jpeeler | 2008-06-12 18:09:16 -0500 (Thu, 12 Jun 2008) | 12 lines Blocked revisions 122208 via svnmerge ........ r122208 | jpeeler | 2008-06-12 10:46:08 -0500 (Thu, 12 Jun 2008) | 5 lines (closes issue ASTERISK-11622) Reported by: davidw Patch by: Corydon76, modified by me to work properly with ParkAndAnnounce app ........ ................ r122616 | jpeeler | 2008-06-13 12:38:28 -0500 (Fri, 13 Jun 2008) | 13 lines Blocked revisions 122613 via svnmerge ........ r122613 | jpeeler | 2008-06-13 12:36:56 -0500 (Fri, 13 Jun 2008) | 6 lines (closes issue ASTERISK-12184) Reported by: Netview Tested by: jpeeler Use correct location to search for tonezone. ........ ................ r122664 | jpeeler | 2008-06-13 13:58:29 -0500 (Fri, 13 Jun 2008) | 8 lines Blocked revisions 122663 via svnmerge ........ r122663 | jpeeler | 2008-06-13 13:57:24 -0500 (Fri, 13 Jun 2008) | 1 line fixed dahdi compatability header from assuming either dahdi or zaptel is installed (may not have either) ........ ................ r124744 | kpfleming | 2008-06-23 16:24:34 -0500 (Mon, 23 Jun 2008) | 10 lines Blocked revisions 124743 via svnmerge ........ r124743 | kpfleming | 2008-06-23 16:22:08 -0500 (Mon, 23 Jun 2008) | 3 lines emit a warning if the old IAX2 call searching code finds a call when the new code did not... so that we can get rid of the old code in 2-3 months ........ ................ r124909 | tilghman | 2008-06-24 15:55:06 -0500 (Tue, 24 Jun 2008) | 13 lines Blocked revisions 124908 via svnmerge ........ r124908 | tilghman | 2008-06-24 15:52:43 -0500 (Tue, 24 Jun 2008) | 6 lines Don't access the pvt structure if unable to acquire the lock. (closes issue ASTERISK-11592) Reported by: norman Patches:       12162-lockfail.diff uploaded by qwell (license 4) ........ ................ r125894 | tilghman | 2008-06-27 11:48:05 -0500 (Fri, 27 Jun 2008) | 14 lines Blocked revisions 125893 via svnmerge ........ r125893 | tilghman | 2008-06-27 11:46:05 -0500 (Fri, 27 Jun 2008) | 7 lines Since HAVE_DAHDI is defined to HAVE_ZAPTEL in dahdi_compat.h, we must first check for HAVE_ZAPTEL. (closes issue ASTERISK-12259) Reported by: opticron Patches:       tonezone_compat.diff uploaded by opticron (license 267) ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=126112