[Home]

Summary:ASTERISK-12768: [patch] Asterisk crash getting fax by sip channel
Reporter:german aracil boned (tecnoxarxa)Labels:
Date Opened:2008-09-23 13:07:58Date Closed:2009-02-10 11:12:53.000-0600
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_sip.c.gz
( 1) crash.txt.gz
Description:Function: sip_uri_headers_cmp
Comments:By: german aracil boned (tecnoxarxa) 2008-09-23 13:15:07

I upload a posible solution in chan_sip.c file

By: Dmitry Andrianov (dimas) 2008-09-23 13:50:07

You better upload changes to chan_sip as a patch.
It is small (so no need to compress) and the actual changes can be easily identified.

By: german aracil boned (tecnoxarxa) 2008-09-23 17:00:00

I always submit patches, but now I don't have time, sorry!

By: Leif Madsen (lmadsen) 2008-12-09 08:13:53.000-0600

Assigned to Dwayne since this is a fax issue (fun times!). Please reassign should you not be able to move this forward.

tecnoxarxa: if you have a working solution for this, I would try to influence you to attach it to this issue. I know you are busy, but so is everyone else. If Dwayne cannot move this forward, we may need to suspend this issue until you have time to move the issue forward.

By: Digium Subversion (svnbot) 2009-02-06 17:36:05.000-0600

Repository: asterisk
Revision: 174082

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r174082 | dhubbard | 2009-02-06 17:36:04 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()
patch by tecnoxarxa, modified by me
closes issue ASTERISK-12768


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174082

By: Digium Subversion (svnbot) 2009-02-06 17:51:57.000-0600

Repository: asterisk
Revision: 174084

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r174084 | dhubbard | 2009-02-06 17:51:57 -0600 (Fri, 06 Feb 2009) | 13 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()
patch by tecnoxarxa, modified by me
closes issue ASTERISK-12768


........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174084

By: Digium Subversion (svnbot) 2009-02-06 17:59:45.000-0600

Repository: asterisk
Revision: 174085

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r174085 | dhubbard | 2009-02-06 17:59:44 -0600 (Fri, 06 Feb 2009) | 21 lines

Merged revisions 174084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r174084 | dhubbard | 2009-02-06 17:51:56 -0600 (Fri, 06 Feb 2009) | 13 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()
patch by tecnoxarxa, modified by me
closes issue ASTERISK-12768


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174085

By: Digium Subversion (svnbot) 2009-02-06 18:09:09.000-0600

Repository: asterisk
Revision: 174086

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r174086 | dhubbard | 2009-02-06 18:09:08 -0600 (Fri, 06 Feb 2009) | 21 lines

Merged revisions 174084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r174084 | dhubbard | 2009-02-06 17:51:56 -0600 (Fri, 06 Feb 2009) | 13 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()
patch by tecnoxarxa, modified by me
closes issue ASTERISK-12768


........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174086

By: Dwayne Hubbard (dhubbard) 2009-02-10 09:54:21.000-0600

reopening to use commit message template

By: Digium Subversion (svnbot) 2009-02-10 10:45:17.000-0600

Repository: asterisk
Revision: 174082

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 13 lines

------------------------------------------------------------------------
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

------------------------------------------------------------------------

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174082

By: Digium Subversion (svnbot) 2009-02-10 10:47:19.000-0600

Repository: asterisk
Revision: 174082

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 8 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp() and sip_uri_params_cmp()

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174082

By: Digium Subversion (svnbot) 2009-02-10 11:00:16.000-0600

Repository: asterisk
Revision: 174082

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 14 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp()
and sip_uri_params_cmp()

The reporter didn't actually upload a properly-formed patch, instead a
modified chan_sip.c file was uploaded.  I created a patch to determine the
changes, then modified the suggested changes to create a proper fix.  The
summary above is a complete description of the changes.

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174082

By: Digium Subversion (svnbot) 2009-02-10 11:02:52.000-0600

Repository: asterisk
Revision: 174084

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r174084 | dhubbard | 2009-02-06 17:51:56 -0600 (Fri, 06 Feb 2009) | 22 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp()
and sip_uri_params_cmp()

The reporter didn't actually upload a properly-formed patch, instead a
modified chan_sip.c file was uploaded.  I created a patch to determine the
changes, then modified the suggested changes to create a proper fix.  The
summary above is a complete description of the changes.

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174084

By: Digium Subversion (svnbot) 2009-02-10 11:08:38.000-0600

Repository: asterisk
Revision: 174085

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c

------------------------------------------------------------------------
r174085 | dhubbard | 2009-02-06 17:59:42 -0600 (Fri, 06 Feb 2009) | 32 lines

Merged revisions 174084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r174084 | dhubbard | 2009-02-06 17:51:56 -0600 (Fri, 06 Feb 2009) | 13 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp()
and sip_uri_params_cmp()

The reporter didn't actually upload a properly-formed patch, instead a
modified chan_sip.c file was uploaded.  I created a patch to determine the
changes, then modified the suggested changes to create a proper fix.  The
summary above is a complete description of the changes.

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

........

................

------------------------------------------------------------------------

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174085

By: Digium Subversion (svnbot) 2009-02-10 11:12:51.000-0600

Repository: asterisk
Revision: 174086

_U  branches/1.6.1/
U   branches/1.6.1/channels/chan_sip.c

------------------------------------------------------------------------
r174086 | dhubbard | 2009-02-06 18:09:08 -0600 (Fri, 06 Feb 2009) | 30 lines

Merged revisions 174084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r174084 | dhubbard | 2009-02-06 17:51:56 -0600 (Fri, 06 Feb 2009) | 13 lines

Merged revisions 174082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r174082 | dhubbard | 2009-02-06 17:36:03 -0600 (Fri, 06 Feb 2009) | 5 lines

check ast_strlen_zero() before calling ast_strdupa() in sip_uri_headers_cmp()
and sip_uri_params_cmp()

The reporter didn't actually upload a properly-formed patch, instead a
modified chan_sip.c file was uploaded.  I created a patch to determine the
changes, then modified the suggested changes to create a proper fix.  The
summary above is a complete description of the changes.

(closes issue ASTERISK-12768)
Reported by: tecnoxarxa
Patches:
     chan_sip.c.gz uploaded by tecnoxarxa (license 258)
Tested by: tecnoxarxa

........

................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=174086