[Home]

Summary:ASTERISK-12789: [Patch] Allow realtime_multi_ldap to behave like other realtime_multi functions
Reporter:Navin Kumar (navkumar)Labels:
Date Opened:2008-09-27 18:43:40Date Closed:2010-07-26 16:08:24
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Resources/res_config_ldap
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) res_config_ldap
( 1) res_config_ldap.patch
( 2) res_config_ldap-category.diff
Description:This patch allows for res_config_ldap multi function to properly deal with categories like the other realtime_multi functions in res_config_odbc, etc.  This allows for example, realtime queues to work with res_config_ldap configurations.
Comments:By: Leif Madsen (lmadsen) 2008-10-01 10:58:25

Thanks for the patch navkumar! Hopefully one of the developers who is familiar with LDAP can take a look at this soon.

Thanks again!
By: Tilghman Lesher (tilghman) 2008-10-09 18:18:56

suretec: could you take a look at this patch, please?
By: Gavin Henry (suretec) 2008-10-10 03:17:22

Will do. Won't be until next week sometime.
By: Leif Madsen (lmadsen) 2009-01-09 13:50:25.000-0600

Is it next week yet? :)
By: Gavin Henry (suretec) 2009-01-14 09:44:05.000-0600

Sorry, will be soon.
By: Joshua C. Colp (jcolp) 2009-02-13 14:47:40.000-0600

Any progress?
By: bencer (bencer) 2009-03-13 13:34:03

i'm really interested on having this patch merged too.
By: Tilghman Lesher (tilghman) 2009-03-13 13:51:17

I'm really interested in having someone with the understanding of LDAP actually maintain the driver.  It's all well and good to commit the patch, but if something is wrong with it, we need to have someone around who understands enough of the protocols to know how to fix it.
By: Gavin Henry (suretec) 2009-03-13 15:19:03

I'm no experienced C coder, but part of the OpenLDAP project and contributed a proper LDAP schema (which still needs some corrections) file and also have a huge interest in Asterisk, personal and business.

I can do this side, as I've seen enough LDAP C code to know what's missing etc. But I'm not up to date on the Asterisk C API.
By: Tilghman Lesher (tilghman) 2009-08-27 18:03:00

I wonder if perhaps this just needs testing.
By: Leif Madsen (lmadsen) 2009-12-10 11:13:03.000-0600

I don't have a way to test this easily, so I'm unassigning myself.
By: Leif Madsen (lmadsen) 2009-12-10 11:13:38.000-0600

For testing, it would probably be ideal if the reporter asked for some testing help from the asterisk-dev and/or asterisk-users mailing lists.
By: bencer (bencer) 2010-01-08 09:13:08.000-0600

i can confirm this patch works with trunk, i would like to see it merged soon (attached updated version).
By: bencer (bencer) 2010-06-03 12:11:03

Any chance to merge this into trunk ?
By: Gavin Henry (suretec) 2010-06-04 06:39:06

I'm just getting the user cert renewed and will commit then.

Thanks for waiting.

Gavin.
By: bencer (bencer) 2010-06-06 10:04:11

Updated patch which prevents segfault when newparam o newval are null. Also increases passwd lenght.

Btw, I'm having issues with app_queue, doesn't get the member interface to make the call. Anybody has realtime LDAP queues working with trunk? I got them working with 1.6.2.1+svn244040 but now I'm upgrading and this issue is blocking me.
By: Leif Madsen (lmadsen) 2010-07-26 12:59:57

@suretec: were you able to get your cert renewed? We've just branched 1.8 now so we should make sure Russell still wants this merged into the 1.8 branch and trunk. We should get that done this week.
By: Gavin Henry (suretec) 2010-07-26 13:17:34

Yeah, I did. Not had chance. It's been mental busy here as always and I know that's not an excuse. We now actually have a UK ITSP setup fully Ofcom registered with our own number allocations. All live, but still working on sales website.

That's my excuse. Will test cert now and grab 1.8.
By: Leif Madsen (lmadsen) 2010-07-26 14:00:44

No problem, I know how that is. Merge when you have a chance over the next week :)
By: Gavin Henry (suretec) 2010-07-26 15:23:28

OK, this works on 1.6.2, that patch that is. Will commit and ask for testing.

It failed on trunk and haven't tried 1.8 yet.
By: Digium Subversion (svnbot) 2010-07-26 15:25:53

Repository: asterisk
Revision: 279597

U   branches/1.6.2/res/res_config_ldap.c

------------------------------------------------------------------------
r279597 | ghenry | 2010-07-26 15:25:53 -0500 (Mon, 26 Jul 2010) | 13 lines

Apply all patches in:

https://issues.asterisk.org/view.php?id=13573

(closes issue ASTERISK-12789)
Reported by: navkumar
Patches:
     res_config_ldap-category.diff uploaded by navkumar (license 580)
     res_config_ldap.patch uploaded by bencer (license 961)
     res_config_ldap uploaded by bencer (license 961)
Tested by: suretec


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279597
By: Digium Subversion (svnbot) 2010-07-26 16:07:44

Repository: asterisk
Revision: 279601

_U  branches/1.8/
U   branches/1.8/res/res_config_ldap.c

------------------------------------------------------------------------
r279601 | tilghman | 2010-07-26 16:07:44 -0500 (Mon, 26 Jul 2010) | 19 lines

Merged revisions 279597 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r279597 | ghenry | 2010-07-26 15:25:54 -0500 (Mon, 26 Jul 2010) | 13 lines
 
 Apply all patches in:
 
 https://issues.asterisk.org/view.php?id=13573
 
 (closes issue ASTERISK-12789)
 Reported by: navkumar
 Patches:
       res_config_ldap-category.diff uploaded by navkumar (license 580)
       res_config_ldap.patch uploaded by bencer (license 961)
       res_config_ldap uploaded by bencer (license 961)
 Tested by: suretec
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279601
By: Digium Subversion (svnbot) 2010-07-26 16:08:23

Repository: asterisk
Revision: 279602

_U  trunk/
U   trunk/res/res_config_ldap.c

------------------------------------------------------------------------
r279602 | tilghman | 2010-07-26 16:08:23 -0500 (Mon, 26 Jul 2010) | 26 lines

Merged revisions 279601 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r279601 | tilghman | 2010-07-26 16:07:45 -0500 (Mon, 26 Jul 2010) | 19 lines
 
 Merged revisions 279597 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r279597 | ghenry | 2010-07-26 15:25:54 -0500 (Mon, 26 Jul 2010) | 13 lines
   
   Apply all patches in:
   
   https://issues.asterisk.org/view.php?id=13573
   
   (closes issue ASTERISK-12789)
   Reported by: navkumar
   Patches:
         res_config_ldap-category.diff uploaded by navkumar (license 580)
         res_config_ldap.patch uploaded by bencer (license 961)
         res_config_ldap uploaded by bencer (license 961)
   Tested by: suretec
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279602