Summary: | ASTERISK-12830: IAX port change using dnsmgr | ||
Reporter: | David A. Bandel (pananix) | Labels: | |
Date Opened: | 2008-10-06 10:59:41 | Date Closed: | 2008-12-22 10:10:18.000-0600 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_iax2 |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) bug13628.patch | |
Description: | When dnsmgr is enabled, a iax peer that is connected will go unreachable when the dnsmgr runs and subsequently changes the port. ****** ADDITIONAL INFORMATION ****** Appicable DNS SRV record: _iax._udp IN SRV 20 0 4569 pbx.pananix.com. with dnsmgr turned on, port will change from 4569 to something else (like 5017). If dnsmgr is turned off, port remains correct and iax remains connected. | ||
Comments: | By: Joshua C. Colp (jcolp) 2008-12-10 11:27:55.000-0600 Is this defined as a peer? Can you make it happen with dnsmgr refresh? What is the console output? I just attempted to reproduce this using the latest revision and was not able to so further details would be helpful. By: David A. Bandel (pananix) 2008-12-10 19:29:13.000-0600 This is a peer. Using iax2 show peers this shows up normally with port 4569. What I noticed is that if, when dnsmgr runs the DNS servers aren't reachable, you'll get a random port, and the peer goes unreachable (hadn't noticed that when I filed this report). The system where I've been testing this is in a location that occasionally experiences very short outages (due to network loading -- it's also my network testbed) and if that coincides with dnsmgr's cycle -- goodbye peer. I then have to actually reload iax2 to fix the problem. dnsmgr off, peer remains connected. Even when DNS is again reachable, port remains (doesn't change back to 4569) until I reload iax2. By: Jeff Peeler (jpeeler) 2008-12-18 16:45:47.000-0600 I've reproduced this. One can make it occur immediately by issuing a dnsmgr refresh. By: Jeff Peeler (jpeeler) 2008-12-18 17:49:38.000-0600 Try the attached patch. By: David A. Bandel (pananix) 2008-12-22 07:34:34.000-0600 Sorry, been traveling. Testing today. Will add note with results RSN. By: Leif Madsen (lmadsen) 2008-12-22 10:05:22.000-0600 This seems to work for me. The issue I closed and related will be something I need to wait over the next day or so to see if this fixes that issue or not, but for the dnsmgr refresh part of it, yes, it appears to be fixed! By: Digium Subversion (svnbot) 2008-12-22 10:08:08.000-0600 Repository: asterisk Revision: 166268 U trunk/main/dnsmgr.c ------------------------------------------------------------------------ r166268 | file | 2008-12-22 10:08:08 -0600 (Mon, 22 Dec 2008) | 7 lines Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port. (closes issue ASTERISK-12830) Reported by: pananix Patches: bug13628.patch uploaded by jpeeler (license 325) Tested by: file, blitzrage ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=166268 By: Digium Subversion (svnbot) 2008-12-22 10:09:32.000-0600 Repository: asterisk Revision: 166270 _U branches/1.6.0/ ------------------------------------------------------------------------ r166270 | file | 2008-12-22 10:09:31 -0600 (Mon, 22 Dec 2008) | 13 lines Blocked revisions 166268 via svnmerge ........ r166268 | file | 2008-12-22 12:08:13 -0400 (Mon, 22 Dec 2008) | 7 lines Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port. (closes issue ASTERISK-12830) Reported by: pananix Patches: bug13628.patch uploaded by jpeeler (license 325) Tested by: file, blitzrage ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=166270 By: Digium Subversion (svnbot) 2008-12-22 10:10:18.000-0600 Repository: asterisk Revision: 166272 _U branches/1.6.1/ U branches/1.6.1/main/dnsmgr.c ------------------------------------------------------------------------ r166272 | file | 2008-12-22 10:10:17 -0600 (Mon, 22 Dec 2008) | 14 lines Merged revisions 166268 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r166268 | file | 2008-12-22 12:08:13 -0400 (Mon, 22 Dec 2008) | 7 lines Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port. (closes issue ASTERISK-12830) Reported by: pananix Patches: bug13628.patch uploaded by jpeeler (license 325) Tested by: file, blitzrage ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=166272 |