Asterisk
  1. Asterisk
  2. ASTERISK-13564

Asterisk plays a continuous tone forever if it never receives a 2833 end packet

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Core/RTP
    • Labels:
      None
    • Mantis ID:
      14460
    • Regression:
      No

      Description

      I am running asterisk 1.4.21.1, but have also reproduced this issue with 1.6.1-rc1.

      Asterisk is bridging a call between two endpoints, both using rfc2833 for digit detection.

      SBC (192.168.196.40) --> asterisk (192.168.196.33) --> IP Phone (192.168.196.181).

      Asterisk receives a single rfc2833 digit with a duration of 320 (no end packet) from 196.40. Asterisk then sends a continuous stream of 2833 events towards the other end with increasing duration, causing a continuous tone to be played. Asterisk also stops sending rtp towards 196.181 while sending the 2833 events.

      I believe that this is not compliant with rfc2833.

      Would it be better if the 2833 packets were simply forwarded on if bridging between two peers that both do 2833? At least the tone should not last forever, and should not block rtp. This 2833 packet originated from an Adtran TA904 gateway that falsely detected a digit when none was pressed (talk off).

      I will attach a packet capture after submitting this ticket.

                • ADDITIONAL INFORMATION ******

      As mentioned, I am running 1.4.21.1 but saw the same behavior in 1.6.1-rc1

      1. dtmf_logging.txt
        2 kB
      2. endless-digit-svnBranch1.4-r178508.pcap.gz
        255 kB
      3. rfc2833-noEnd.pcap.gz
        214 kB
      4. talkoff.pcap
        277 kB
      5. uac_talkoff.xml
        5 kB

        Activity

        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 194208

        U branches/1.4/main/rtp.c

        ------------------------------------------------------------------------
        r194208 | file | 2009-05-13 08:38:08 -0500 (Wed, 13 May 2009) | 11 lines

        Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

        (closes issue ASTERISK-13887)
        Reported by: geoff2010
        Patches:
        v1-14815.patch uploaded by dimas (license 88)
        Tested by: geoff2010, file, dimas, ZX81, moliveras
        (closes issue ASTERISK-13564)
        Reported by: moliveras
        Tested by: moliveras

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=194208

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 194208 U branches/1.4/main/rtp.c ------------------------------------------------------------------------ r194208 | file | 2009-05-13 08:38:08 -0500 (Wed, 13 May 2009) | 11 lines Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over. (closes issue ASTERISK-13887 ) Reported by: geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88) Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue ASTERISK-13564 ) Reported by: moliveras Tested by: moliveras ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=194208
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 194209

        _U trunk/
        U trunk/res/res_rtp_asterisk.c

        ------------------------------------------------------------------------
        r194209 | file | 2009-05-13 08:39:15 -0500 (Wed, 13 May 2009) | 18 lines

        Merged revisions 194208 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines

        Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

        (closes issue ASTERISK-13887)
        Reported by: geoff2010
        Patches:
        v1-14815.patch uploaded by dimas (license 88)
        Tested by: geoff2010, file, dimas, ZX81, moliveras
        (closes issue ASTERISK-13564)
        Reported by: moliveras
        Tested by: moliveras
        ........

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=194209

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 194209 _U trunk/ U trunk/res/res_rtp_asterisk.c ------------------------------------------------------------------------ r194209 | file | 2009-05-13 08:39:15 -0500 (Wed, 13 May 2009) | 18 lines Merged revisions 194208 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over. (closes issue ASTERISK-13887 ) Reported by: geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88) Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue ASTERISK-13564 ) Reported by: moliveras Tested by: moliveras ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=194209
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 194211

        _U branches/1.6.0/
        U branches/1.6.0/main/rtp.c

        ------------------------------------------------------------------------
        r194211 | file | 2009-05-13 08:40:24 -0500 (Wed, 13 May 2009) | 25 lines

        Merged revisions 194209 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines

        Merged revisions 194208 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines

        Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

        (closes issue ASTERISK-13887)
        Reported by: geoff2010
        Patches:
        v1-14815.patch uploaded by dimas (license 88)
        Tested by: geoff2010, file, dimas, ZX81, moliveras
        (closes issue ASTERISK-13564)
        Reported by: moliveras
        Tested by: moliveras
        ........
        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=194211

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 194211 _U branches/1.6.0/ U branches/1.6.0/main/rtp.c ------------------------------------------------------------------------ r194211 | file | 2009-05-13 08:40:24 -0500 (Wed, 13 May 2009) | 25 lines Merged revisions 194209 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines Merged revisions 194208 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over. (closes issue ASTERISK-13887 ) Reported by: geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88) Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue ASTERISK-13564 ) Reported by: moliveras Tested by: moliveras ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=194211
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 194212

        _U branches/1.6.1/
        U branches/1.6.1/main/rtp.c

        ------------------------------------------------------------------------
        r194212 | file | 2009-05-13 08:41:34 -0500 (Wed, 13 May 2009) | 25 lines

        Merged revisions 194209 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines

        Merged revisions 194208 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines

        Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

        (closes issue ASTERISK-13887)
        Reported by: geoff2010
        Patches:
        v1-14815.patch uploaded by dimas (license 88)
        Tested by: geoff2010, file, dimas, ZX81, moliveras
        (closes issue ASTERISK-13564)
        Reported by: moliveras
        Tested by: moliveras
        ........
        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=194212

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 194212 _U branches/1.6.1/ U branches/1.6.1/main/rtp.c ------------------------------------------------------------------------ r194212 | file | 2009-05-13 08:41:34 -0500 (Wed, 13 May 2009) | 25 lines Merged revisions 194209 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines Merged revisions 194208 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over. (closes issue ASTERISK-13887 ) Reported by: geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88) Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue ASTERISK-13564 ) Reported by: moliveras Tested by: moliveras ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=194212
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 194213

        _U branches/1.6.2/
        U branches/1.6.2/main/rtp.c

        ------------------------------------------------------------------------
        r194213 | file | 2009-05-13 08:42:27 -0500 (Wed, 13 May 2009) | 25 lines

        Merged revisions 194209 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/trunk

        ................
        r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines

        Merged revisions 194208 via svnmerge from
        https://origsvn.digium.com/svn/asterisk/branches/1.4

        ........
        r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines

        Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over.

        (closes issue ASTERISK-13887)
        Reported by: geoff2010
        Patches:
        v1-14815.patch uploaded by dimas (license 88)
        Tested by: geoff2010, file, dimas, ZX81, moliveras
        (closes issue ASTERISK-13564)
        Reported by: moliveras
        Tested by: moliveras
        ........
        ................

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=194213

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 194213 _U branches/1.6.2/ U branches/1.6.2/main/rtp.c ------------------------------------------------------------------------ r194213 | file | 2009-05-13 08:42:27 -0500 (Wed, 13 May 2009) | 25 lines Merged revisions 194209 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r194209 | file | 2009-05-13 10:39:10 -0300 (Wed, 13 May 2009) | 18 lines Merged revisions 194208 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r194208 | file | 2009-05-13 10:38:01 -0300 (Wed, 13 May 2009) | 11 lines Fix RFC2833 issues with DTMF getting duplicated and with duration wrapping over. (closes issue ASTERISK-13887 ) Reported by: geoff2010 Patches: v1-14815.patch uploaded by dimas (license 88) Tested by: geoff2010, file, dimas, ZX81, moliveras (closes issue ASTERISK-13564 ) Reported by: moliveras Tested by: moliveras ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=194213

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development