[Home]

Summary:ASTERISK-13680: [patch] meetme doesn't play conf-has left prompts
Reporter:Giedrius (voipas)Labels:
Date Opened:2009-03-02 14:44:03.000-0600Date Closed:2009-09-08 15:34:25
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_meetme
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20090716__issue14588__2.diff.txt
Description:Hello,

 I'm using dynamic conference with meetme (meetme(dMi)). Everything works fine (recording names, conference participants hears new users conf-hasjoin prompt), except I'm not hearing conf-hasleft prompt, and recorded name also. From log, you can see that asterisk is playing 'conf-hasleft', but when another conf users exits conference, I hear MOH!

 Thanks



{{****** ADDITIONAL INFORMATION ******}}

Full log:
{noformat}
[Mar  2 22:35:35] VERBOSE[8584] logger.c:     -- Executing [STARTMEETME@DYNAMIC-CONF:1] MeetMe("SIP/123-1e1e4500", "12345678,dMi") in new stack
[Mar  2 22:35:35] VERBOSE[8584] logger.c:     -- Recording
[Mar  2 22:35:35] VERBOSE[8584] logger.c:     -- <SIP/123-1e1e4500> Playing 'vm-rec-name.slin' (language 'en')
[Mar  2 22:35:39] VERBOSE[8584] logger.c:     -- <SIP/123-1e1e4500> Playing 'beep.slin' (language 'en')
[Mar  2 22:35:39] VERBOSE[8584] logger.c:     -- x=0, open writing:  /var/spool/asterisk/meetme/meetme-username-12345678-2 format: sln, 0x2aaab4048318
[Mar  2 22:35:41] VERBOSE[8584] logger.c:     -- User ended message by pressing #
[Mar  2 22:35:41] VERBOSE[8584] logger.c:     -- <SIP/123-1e1e4500> Playing 'auth-thankyou.slin' (language 'en')
[Mar  2 22:35:42] VERBOSE[8584] logger.c:     -- <SIP/123-1e1e4500> Playing 'vm-review.slin' (language 'en')
[Mar  2 22:35:45] VERBOSE[8584] logger.c:     -- <SIP/123-1e1e4500> Playing 'vm-msgsaved.slin' (language 'en')
[Mar  2 22:35:47] DEBUG[8581] app_meetme.c: About to play /var/spool/asterisk/meetme/meetme-username-12345678-2
[Mar  2 22:35:47] VERBOSE[8581] logger.c:     -- <DAHDI/pseudo-229848494> Playing '/var/spool/asterisk/meetme/meetme-username-12345678-2.slin' (language 'en')
[Mar  2 22:35:47] VERBOSE[8578] logger.c:     -- Stopped music on hold on SIP/111-1e1c83e0
[Mar  2 22:35:49] VERBOSE[8581] logger.c:     -- <DAHDI/pseudo-229848494> Playing 'conf-hasjoin.slin' (language 'en')
[Mar  2 22:36:11] VERBOSE[8578] logger.c:   == Spawn extension (DYNAMIC-CONF, STARTMEETME, 1) exited non-zero on 'SIP/111-1e1c83e0'
[Mar  2 22:36:11] DEBUG[8581] app_meetme.c: About to play /var/spool/asterisk/meetme/meetme-username-12345678-1
[Mar  2 22:36:11] VERBOSE[8581] logger.c:     -- <DAHDI/pseudo-229848494> Playing '/var/spool/asterisk/meetme/meetme-username-12345678-1.slin' (language 'en')
[Mar  2 22:36:11] VERBOSE[8584] logger.c:     -- Started music on hold, class 'default', on SIP/123-1e1e4500
[Mar  2 22:36:13] VERBOSE[8581] logger.c:     -- <DAHDI/pseudo-229848494> Playing 'conf-hasleft.slin' (language 'en')
{noformat}
Comments:By: David Brillert (aragon) 2009-03-02 15:23:10.000-0600

Same thing happens in 1.4 SVN revision 178108

According to log, it play it : but nobody actually hears the prompt 'conf-hasleft'

JOIN:

-- <Zap/pseudo-922194497> Playing '/var/spool/asterisk/meetme/meetme-username-6052-2' (language 'en')
-- Stopped music on hold on SIP/6010-b74489b8
-- <Zap/pseudo-922194497> Playing 'conf-hasjoin' (language 'en')


LEAVE:

-- <Zap/pseudo-922194497> Playing '/var/spool/asterisk/meetme/meetme-username-6052-1' (language 'en')
-- Started music on hold, class 'default', on SIP/6002-b744b758
-- <Zap/pseudo-922194497> Playing 'conf-hasleft' (language 'en')
By: David Brillert (aragon) 2009-03-02 15:35:47.000-0600

Actually I don't think this is a bug.
If there are only two calls in the bridge and one call hangs up and leaves one party on the bridge that party will hear MOH and no conf-hasleft prompt.
But if there are three people in meetme and hangs up leaving two then both remaining parties hear the conf-hasleft prompt

One could assume you are the only party left in meetme when you hear MOH because of setting "Enable Music On Hold when the conference has a single caller"

Still, I don't understand why the CLI says its playing the prompt when no one can hear it...

This behavior is easily reproduced.


By: Giedrius (voipas) 2009-03-03 00:59:42.000-0600

Also in 1.6.0.1 version works great.
By: Leif Madsen (lmadsen) 2009-03-04 13:38:16.000-0600

Sorry, I'm confused by your note aragon. Is this an issue that needs something to change, or no?
By: David Brillert (aragon) 2009-03-04 13:54:36.000-0600

I think that if the CLI says that it is playing the prompt it should be actually playing the prompt but it is not. It is easy enough to assume that if you are hearing MOH that you are the only person left on the bridge but you will never hear the name of the last caller that has left meetme if you are the only participant left.

Technically it is a bug but very minor.
Honestly a slight change in behavior would be a good idea.
Before the MOH audio is bridged the "conf-hasleft" promt should be played back and another prompt could be played back. Such as "youaretheonlycallerleftinthisconference". Then the MOH...
By: twisted (twisted) 2009-06-30 14:56:49

This is a bug.  We have some customers who complain of this as well, and I've spent some time trying to knock it out with no luck.  

It should say "so and so has left the conference" if announcements are on, followed by you are the only person in this conference, just as if you joined a new conference and are the only person.  Both of these are shown in the code to be what should happen, however, it just doesn't, and I can't seem to get it to work properly.

My vote is that this is something that needs to change.

EDIT: This is also reproducable on 1.4-latest.


By: twisted (twisted) 2009-06-30 14:58:44

updated severity from 'tweak' to 'minor', as this is actually a bug, not a tweaking request.
By: Leif Madsen (lmadsen) 2009-07-01 07:58:28

twisted: thanks for the feedback! Nice to see you on the bug tracker again! :)
By: Tilghman Lesher (tilghman) 2009-07-16 17:12:28

What this is is a conflict between the two locations that we play sound to the channel:  through the conference and through the individual channels.  Music on hold is currently played through the individual channels, which is also how different conference users might hear different MOH (such as when a conference is waiting on a marked user).  The announcements, as to which user is joining or leaving, are played in a separate thread, which is then mixed with all the other channels, without having to worry about conflicting audio.

Since MOH is being played on the individual channel, the audio received from the conference is ignored by the individual channel.

One way to fix this would be to put the MOH through the announce thread.  Unfortunately, this would create other problems, such as disallowing users to hear their own custom MOH; also, users might be able to talk to one another, even when a marked user is not present.  There isn't an easy solution to this, other than not using the M option in conjunction with the i option.


By: Tilghman Lesher (tilghman) 2009-07-16 18:27:35

I have a potential patch, which is against SVN 1.4.  It does work as wanted, by using silence detection on the conference frames.  The only flaw currently is that it continually switches MOH on and off for every frame, because I haven't gotten the silence detection down correctly yet.
By: Leif Madsen (lmadsen) 2009-07-20 11:25:12

Tested with this dialplan:

exten => 14588,1,MeetMe(7070,dMi)

exten => 145882,1,Dial(Local/14588@from-devices/n)


Reproduced the issue on stock 1.4.

Then applied the patch from here and retested.

After the patch, when I leave the conference, I get the announcement, and then the MoH as expected.

Thanks!
By: twisted (twisted) 2009-07-20 11:45:27

On stock 1.4, this patch stops leave announcements altogether.  

I do not get ANY leave announcements.  1.4.25.1.
By: twisted (twisted) 2009-07-20 11:46:09

Just FYI, i do see in the debug where it thinks its playing them, it 's just not...
By: Tilghman Lesher (tilghman) 2009-07-20 12:14:53

twisted: just to try to reproduce this, what flags are you using with the meetme conference?  If you use the flags documented above, do you get the expected behavior?
By: twisted (twisted) 2009-07-20 12:24:27

Flags are MIP.    Same result with dMi

Plays intro messages just fine. (eg, "hoot hoot is now in the conference <intro sound>" for each user (except the first user, obviously).  when one of the announced users leave, all I hear is the exit sound.  No "hoot hoot has left the conference", and when the last user leaves, I don't hear anything except the exit tone and then MOH.

Basically, results are worse than they were befoere... at least before I was getting user exit playback sounds unless they were the 2nd to last user..
By: Tilghman Lesher (tilghman) 2009-07-21 12:47:25

I just tried this with flags MIP (after defining the conference in meetme.conf).  It worked perfectly.

twisted:  can you think of ANYTHING different that you might be doing on your system that would differentiate the functionality?

I will note that both lmadsen and I are testing on systems with dahdi_dummy.  What dahdi board/driver are you using?  (Not that I think that would make a difference, but I want to be thorough).  Running DAHDI trunk here.
By: twisted (twisted) 2009-07-21 12:53:38

Hmm...    Yeah, we're still running under Zaptel 1.4.12.1 (cannot change for api issues yet), but I can TEST on DAHDI trunk if needed.  all other functionality works fine.  just that particular part.
By: Leif Madsen (lmadsen) 2009-09-08 14:10:34

Because nothing has moved forward here, I'm going to request that you test on DAHDI just to see if the issue exists there as well. Perhaps it'll give some indication as to why we're seeing this.
By: twisted (twisted) 2009-09-08 14:45:26

So I patched up 1.4.26.1 after recieving the prod from Leif, and now no longer experience this issue using the patch attached to this bugnote.  I didn''t even get to the part where I test with DAHDI rather than Zaptel (driver wise).  Flags MiP, MIP, this problem no longer exists with above patch.  Don't know why it made it not work at all on 1.4.25 as mentioned above, but this patch definitely works on 1.4.26.1.

*thumbsup*
By: Digium Subversion (svnbot) 2009-09-08 15:02:51

Repository: asterisk
Revision: 217156

U   branches/1.4/apps/app_meetme.c

------------------------------------------------------------------------
r217156 | tilghman | 2009-09-08 15:02:50 -0500 (Tue, 08 Sep 2009) | 7 lines

When MOH is playing on the channel, announcements sent through the conference are not heard.
(closes issue ASTERISK-13680)
Reported by: voipas
Patches:
      20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
Tested by: lmadsen, twisted, tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217156
By: Digium Subversion (svnbot) 2009-09-08 15:29:48

Repository: asterisk
Revision: 217199

_U  trunk/
U   trunk/apps/app_meetme.c

------------------------------------------------------------------------
r217199 | tilghman | 2009-09-08 15:29:47 -0500 (Tue, 08 Sep 2009) | 14 lines

Merged revisions 217156 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r217156 | tilghman | 2009-09-08 15:01:45 -0500 (Tue, 08 Sep 2009) | 7 lines
 
 When MOH is playing on the channel, announcements sent through the conference are not heard.
 (closes issue ASTERISK-13680)
  Reported by: voipas
  Patches:
        20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
  Tested by: lmadsen, twisted, tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217199
By: Digium Subversion (svnbot) 2009-09-08 15:32:08

Repository: asterisk
Revision: 217209

_U  branches/1.6.0/
U   branches/1.6.0/apps/app_meetme.c

------------------------------------------------------------------------
r217209 | tilghman | 2009-09-08 15:32:08 -0500 (Tue, 08 Sep 2009) | 21 lines

Merged revisions 217199 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r217199 | tilghman | 2009-09-08 15:28:41 -0500 (Tue, 08 Sep 2009) | 14 lines
 
 Merged revisions 217156 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r217156 | tilghman | 2009-09-08 15:01:45 -0500 (Tue, 08 Sep 2009) | 7 lines
   
   When MOH is playing on the channel, announcements sent through the conference are not heard.
   (closes issue ASTERISK-13680)
    Reported by: voipas
    Patches:
          20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
    Tested by: lmadsen, twisted, tilghman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217209
By: Digium Subversion (svnbot) 2009-09-08 15:33:08

Repository: asterisk
Revision: 217213

_U  branches/1.6.1/
U   branches/1.6.1/apps/app_meetme.c

------------------------------------------------------------------------
r217213 | tilghman | 2009-09-08 15:33:08 -0500 (Tue, 08 Sep 2009) | 21 lines

Merged revisions 217199 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r217199 | tilghman | 2009-09-08 15:28:41 -0500 (Tue, 08 Sep 2009) | 14 lines
 
 Merged revisions 217156 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r217156 | tilghman | 2009-09-08 15:01:45 -0500 (Tue, 08 Sep 2009) | 7 lines
   
   When MOH is playing on the channel, announcements sent through the conference are not heard.
   (closes issue ASTERISK-13680)
    Reported by: voipas
    Patches:
          20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
    Tested by: lmadsen, twisted, tilghman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217213
By: Digium Subversion (svnbot) 2009-09-08 15:34:24

Repository: asterisk
Revision: 217217

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_meetme.c

------------------------------------------------------------------------
r217217 | tilghman | 2009-09-08 15:34:23 -0500 (Tue, 08 Sep 2009) | 21 lines

Merged revisions 217199 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
 r217199 | tilghman | 2009-09-08 15:28:41 -0500 (Tue, 08 Sep 2009) | 14 lines
 
 Merged revisions 217156 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r217156 | tilghman | 2009-09-08 15:01:45 -0500 (Tue, 08 Sep 2009) | 7 lines
   
   When MOH is playing on the channel, announcements sent through the conference are not heard.
   (closes issue ASTERISK-13680)
    Reported by: voipas
    Patches:
          20090716__issue14588__2.diff.txt uploaded by tilghman (license 14)
    Tested by: lmadsen, twisted, tilghman
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=217217