[Home]

Summary:ASTERISK-13943: Parking extension number is not overriden in custom parking lots
Reporter:Vadim Mikhnevych (vmikhnevych)Labels:
Date Opened:2009-04-13 04:07:31Date Closed:2010-09-15 14:23:59
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Features/Parking
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) patch_14882.txt
Description:Example, from features.conf :
[general]
parkext => 700
.....

[PARKINGLOT_1]
parkext => 800
...

CLI command "features show" says that Parking extension is 700 for PARKINGLOT_1

(Other options, like "Parking context" and "Parked call extensions" are overriden correctly.)
Comments:By: Leif Madsen (lmadsen) 2009-04-21 22:05:45

Is this just cosmetic, or is the parking lot 800 not accessible at all?
By: Vadim Mikhnevych (vmikhnevych) 2009-04-23 09:40:07

I've installed Asterisk 1.6.1-rc5, and it's reproducible on it too.

That's what i get after "features show" and "dialplan show":
=================================================
Call parking (Parking lot: PARKINGLOT_165)
------------
Parking extension     :      700
Parking context       :      PARK_165
Parked call extensions:      801-850

*CLI> dialplan show PARK_165
[ Context 'PARK_165' created by 'features' ]
 '700' =>          1. Park()                                     [features]

-= 1 extension (1 priority) in 1 context. =-
=================================================

Meantime in features.conf.inc file (included in features.conf) there is:
[PARKINGLOT_165]
parkext => 800
context => PARK_165
parkpos => 801-850

And the phone can't dial 800, though PARK_165 is included in it's context. 700 parks the call in default (parkedcalls) context on default parking lot.

So my conclusion is that it's not just cosmetic.
By: Matthias Nick (mnick) 2009-11-03 10:52:44.000-0600

posted patch for trunk
can you please test it, and report if it is working properly ?


By: Vadim Mikhnevych (vmikhnevych) 2009-11-06 10:32:32.000-0600

I've tried the patch with the trunk today. Seems working.
Would be great if this bug would be fixed in 1.6.1 and 1.6.2 branches as well as in trunk.


By: Michiel van Baak (mvanbaak) 2009-12-04 11:36:18.000-0600

@mnick: Did you really mean to change this many lines?
Looks like the patch touches a lot more then only the cause of this issue (I might be wrong, that's why I'm asking)
By: Matthias Nick (mnick) 2009-12-04 11:47:50.000-0600

That's right, but that's because the old code was designed to have just one parking extension -> 'default_parkinglot'.

In a lot of functions the 'default_parkinglot' (700) was hardcoded. My patch resolves this and enables the ability to have more than the 'default_parkinglot'

Therefore it's more like a new feature than a bugfix


By: Vadim Mikhnevych (vmikhnevych) 2010-05-06 10:08:09

Seems like this is fixed in 1.6.2.7
In 1.6.1.18 this bug still exists (and looks like 1.6.1 won't have the fix because of EOL)
Perhaps it's time to close this issue?
By: Leif Madsen (lmadsen) 2010-05-10 11:12:54

Is this fixed in 1.6.1.19 then? 1.6.2.7 and 1.6.1.19 were released at the same time and any issues that affected both versions should have had it included in both branches.

Any idea which issue or commit would have resolved it?
By: Vadim Mikhnevych (vmikhnevych) 2010-05-11 02:13:18

I've tried it on 1.6.1.19 and it looks fixed there too.
By: Leif Madsen (lmadsen) 2010-05-17 10:33:28

Closed as 'fixed' per the reporter. Thanks for the feedback!
By: Leif Madsen (lmadsen) 2010-07-06 08:11:57

I've just reproduced this on both the latest trunk and latest 1.6.2 -- not sure how the reporters stated that this feature was working...
By: Leif Madsen (lmadsen) 2010-07-06 08:13:45

Am I just daft and configuring this wrong?

*CLI> features show

Call parking (Parking lot: parkinglot_lme)
------------
Parking extension     :      700
Parking context       :      lmepark
Parked call extensions:      600-609


Call parking (Parking lot: default)
------------
Parking extension     :      700
Parking context       :      parkedcalls
Parked call extensions:      701-720


Call parking (Parking lot: PARKINGLOT_165)
------------
Parking extension     :      700
Parking context       :      PARK_165
Parked call extensions:      801-850




features.conf:

[parkinglot_lme]
context => lmepark
parkext => 600
parkpos => 600-609

[PARKINGLOT_165]
parkext => 800
context => PARK_165
parkpos => 801-850
By: Leif Madsen (lmadsen) 2010-07-06 08:18:20

Also, I can't apply the patch that is here right now -- it appears to be much different than what is in trunk. I haven't tried applying it to 1.6.2 yet though.
By: Leif Madsen (lmadsen) 2010-07-06 08:20:45

(Note: the same 5 hunks fail with the latest 1.6.2 that fail in trunk, so the code must be a fair amount different -- from the cursory look, I couldn't figure out how to apply the failed hunks manually)
By: Digium Subversion (svnbot) 2010-09-15 14:22:16

Repository: asterisk
Revision: 286931

U   branches/1.8/CHANGES
U   branches/1.8/channels/chan_dahdi.c
U   branches/1.8/channels/chan_iax2.c
U   branches/1.8/channels/chan_mgcp.c
U   branches/1.8/channels/chan_sip.c
U   branches/1.8/channels/sig_analog.c
U   branches/1.8/channels/sip/include/sip.h
U   branches/1.8/configs/features.conf.sample
U   branches/1.8/include/asterisk/features.h
U   branches/1.8/main/features.c

------------------------------------------------------------------------
r286931 | jpeeler | 2010-09-15 14:22:16 -0500 (Wed, 15 Sep 2010) | 16 lines

Add parking extension for non-default parking lots.

This is a new feature that allows for parking to custom parking lots to be
accessed directly, rather than with channel variables or by changing the
default parking lot. The extension is set with the parkext option just as the
default parking lot is done. Also, the manager action has been updated to
optionally allow a specified parking lot.

(closes issue ASTERISK-13943)
Reported by: vmikhnevych
Patches:
     patch_14882.txt uploaded by mnick (license 874)
     modified by me

Review: https://reviewboard.asterisk.org/r/884/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=286931
By: Digium Subversion (svnbot) 2010-09-15 14:23:57

Repository: asterisk
Revision: 286939

_U  trunk/
U   trunk/CHANGES
U   trunk/channels/chan_dahdi.c
U   trunk/channels/chan_iax2.c
U   trunk/channels/chan_mgcp.c
U   trunk/channels/chan_sip.c
U   trunk/channels/sig_analog.c
U   trunk/channels/sip/include/sip.h
U   trunk/configs/features.conf.sample
U   trunk/include/asterisk/features.h
U   trunk/main/features.c

------------------------------------------------------------------------
r286939 | jpeeler | 2010-09-15 14:23:57 -0500 (Wed, 15 Sep 2010) | 23 lines

Merged revisions 286931 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r286931 | jpeeler | 2010-09-15 14:22:15 -0500 (Wed, 15 Sep 2010) | 16 lines
 
 Add parking extension for non-default parking lots.
 
 This is a new feature that allows for parking to custom parking lots to be
 accessed directly, rather than with channel variables or by changing the
 default parking lot. The extension is set with the parkext option just as the
 default parking lot is done. Also, the manager action has been updated to
 optionally allow a specified parking lot.
 
 (closes issue ASTERISK-13943)
 Reported by: vmikhnevych
 Patches:
       patch_14882.txt uploaded by mnick (license 874)
       modified by me
 
 Review: https://reviewboard.asterisk.org/r/884/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=286939