Summary:	ASTERISK-14492: [patch] Add voicefile and dtmf options to res/res_agi.c
Reporter:	dillec (dillec)	Labels:
Date Opened:	2009-07-19 08:13:52	Date Closed:	2010-11-22 12:59:21.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Resources/res_agi
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-res_agi-203638-patched.patch
Description:	This patch adds the following functionality to the AGI function WAIT FOR DIGIT: WAIT FOR DIGIT <timeout> [<voicefile>] [<escape chars>] [<maxdigits>] [<previously die chars>] 'voicefile' is played as long 'previously die chars' (default '#') are not typed in or 'escape chars' (default '1234567890*#ABCD') are typed in a 'maxdigit' (default 1) times. ****** ADDITIONAL INFORMATION ****** We use that functions to play a voicefile and wait for digits to be typed in.
Comments:	By: Tilghman Lesher (tilghman) 2009-07-19 13:46:44 Why aren't you just using STREAM FILE ? By: dillec (dillec) 2009-07-20 12:26:07 Because STREAM FILE breaks on the first dtmf digit. We need the function to play a voicefile and simoultanously read a number of dtmf digits which are specified with maxdigits and escape chars. Further it is possible that we need to break not only on # before maxidigts of escape chars are entered but also on *. By: Leif Madsen (lmadsen) 2009-09-22 08:14:36 If the reporter can gather some people to test this issue out and have them report back here, that'll do a lot to move this issue forward. I would suggest using the asterisk-users and/or asterisk-dev mailing list. By: John Todd (jtodd) 2010-05-18 13:45:28 It would be very useful to have this be a more generic function that is also applicable in the dialplan and not just AGI. By: Digium Subversion (svnbot) 2010-11-19 13:24:06.000-0600 Repository: asterisk Revision: 295552 U   branches/1.4/res/res_agi.c ------------------------------------------------------------------------ r295552 | espiceland | 2010-11-19 13:24:05 -0600 (Fri, 19 Nov 2010) | 12 lines Add extra functionality to AGI command WAIT FOR DIGIT. Add the ability to play a sound file, listen for more than just one digit, specify escape characters. Backwards compatible (to work with only timeout specified). (closes issue ASTERISK-14492) Reported by: diLLec Patches:      asterisk-res_agi-203638-patched.patch uploaded by diLLec (license 839) Tested by: diLLec, espiceland ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=295552 By: Digium Subversion (svnbot) 2010-11-19 13:32:56.000-0600 Repository: asterisk Revision: 295554 U   trunk/res/res_agi.c ------------------------------------------------------------------------ r295554 | espiceland | 2010-11-19 13:32:56 -0600 (Fri, 19 Nov 2010) | 13 lines Add extra functionality to AGI command WAIT FOR DIGIT. Add the ability to play a sound file, listen for more than just one digit, specify escape characters. Backwards compatible (to work with only timeout specified). (closes issue ASTERISK-14492) Reported by: diLLec Patches:      asterisk-res_agi-203638-patched.patch uploaded by diLLec (license 839) Tested by: diLLec, espiceland ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=295554 By: Erin Spiceland (espiceland) 2010-11-22 12:59:21.000-0600 Thanks for this submission. We have actually decided to revert back to the previous behavior of WAIT FOR DIGIT. We do not want to change the behavior to make it non-backwards-compatible. This patch makes WAIT FOR DIGIT output a string instead of a digit, and it makes WAIT FOR DIGIT behave almost exactly like GET DATA. The only difference is that GET DATA does not take escape characters. Those wanting to play a file and receive DTMF digits in ASCII form should use GET DATA.