[Home]

Summary:ASTERISK-14662: [patch] password change for mailboxes without user name
Reporter:298 (298)Labels:
Date Opened:2009-08-16 05:16:39Date Closed:2010-09-07 12:57:33
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) M15726.diff
Description:Asterisk seems to have no real problem with mail boxes defined without a name,
for example:
23 => 123,
24 => 456

Both can successfully change their password. However, in the second case where the comma is missing, an error (see below) is displayed in the console and the password is updated only in memory, not in voicemail.conf.

WARNING[17638]: app_voicemail.c:843 vm_change_password: variable has bad format.
Comments:By: Jason Parker (jparker) 2009-08-19 18:07:33

I see where this is happening in the code, and I see why it gives that error message.  I'm not sure how to get around it though.  If this is fixed by setting the password regardless of the return of the strstr, one must consider the following config line:

6000 => 123 // This comment MUST NOT be eaten.
By: Clod Patry (junky) 2009-12-21 08:43:54.000-0600

try this fix.
This patch fixes your problem for a missing comma, but doesn't fix the comment eaten like qwell suggested.
By: Paul Belanger (pabelanger) 2010-06-29 12:40:56

Any feedback from the reporter?
By: Digium Subversion (svnbot) 2010-09-07 12:45:42

Repository: asterisk
Revision: 285194

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r285194 | bbryant | 2010-09-07 12:45:41 -0500 (Tue, 07 Sep 2010) | 10 lines

Fixes voicemail.conf issues where mailboxes with passwords that don't precede a comma would throw unnecessary error messages.

(closes issue ASTERISK-14662)
Reported by: 298
Patches:
     M15726.diff uploaded by junky (license 177)
Tested by: junky

Review: [full review board URL with trailing slash]

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285194
By: Digium Subversion (svnbot) 2010-09-07 12:49:08

Repository: asterisk
Revision: 285196

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r285196 | bbryant | 2010-09-07 12:49:08 -0500 (Tue, 07 Sep 2010) | 17 lines

Merged revisions 285194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r285194 | bbryant | 2010-09-07 13:45:41 -0400 (Tue, 07 Sep 2010) | 10 lines
 
 Fixes voicemail.conf issues where mailboxes with passwords that don't precede a comma would throw unnecessary error messages.
 
 (closes issue ASTERISK-14662)
 Reported by: 298
 Patches:
       M15726.diff uploaded by junky (license 177)
 Tested by: junky
 
 Review: [full review board URL with trailing slash]
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285196
By: Digium Subversion (svnbot) 2010-09-07 12:54:22

Repository: asterisk
Revision: 285197

_U  branches/1.8/
U   branches/1.8/apps/app_voicemail.c

------------------------------------------------------------------------
r285197 | bbryant | 2010-09-07 12:54:22 -0500 (Tue, 07 Sep 2010) | 24 lines

Merged revisions 285196 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r285196 | bbryant | 2010-09-07 13:49:07 -0400 (Tue, 07 Sep 2010) | 17 lines
 
 Merged revisions 285194 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r285194 | bbryant | 2010-09-07 13:45:41 -0400 (Tue, 07 Sep 2010) | 10 lines
   
   Fixes voicemail.conf issues where mailboxes with passwords that don't precede a comma would throw unnecessary error messages.
   
   (closes issue ASTERISK-14662)
   Reported by: 298
   Patches:
         M15726.diff uploaded by junky (license 177)
   Tested by: junky
   
   Review: [full review board URL with trailing slash]
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285197
By: Digium Subversion (svnbot) 2010-09-07 12:57:32

Repository: asterisk
Revision: 285199

_U  trunk/
U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r285199 | bbryant | 2010-09-07 12:57:32 -0500 (Tue, 07 Sep 2010) | 31 lines

Merged revisions 285197 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r285197 | bbryant | 2010-09-07 13:54:21 -0400 (Tue, 07 Sep 2010) | 24 lines
 
 Merged revisions 285196 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r285196 | bbryant | 2010-09-07 13:49:07 -0400 (Tue, 07 Sep 2010) | 17 lines
   
   Merged revisions 285194 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r285194 | bbryant | 2010-09-07 13:45:41 -0400 (Tue, 07 Sep 2010) | 10 lines
     
     Fixes voicemail.conf issues where mailboxes with passwords that don't precede a comma would throw unnecessary error messages.
     
     (closes issue ASTERISK-14662)
     Reported by: 298
     Patches:
           M15726.diff uploaded by junky (license 177)
     Tested by: junky
     
     Review: [full review board URL with trailing slash]
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285199