[Home]

Summary:ASTERISK-14691: Park application expects timeout to be in Milliseconds
Reporter:Mat Murdock (mmurdock)Labels:
Date Opened:2009-08-21 16:22:00Date Closed:2010-12-20 10:19:24.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Features/Parking
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:When using the park() application the timeout has to be set in milliseconds.  It is expected that this be in seconds.

If this is your dialplan:
exten => _7Z,n,Set(PARKINGEXTEN=702)
exten => _7Z,n,Park(60,park-dial,9999,1)

This is what you will see on the console
Parked SIP/1123-b700c008 on 702 (lot default). Will timeout back to extension [park-dial] 9999, 1 in 0 seconds

If I change it to this:
exten => _7Z,n,Set(PARKINGEXTEN=702)
exten => _7Z,n,Park(60000,park-dial,9999,1)

This is what I see and it does time out in 60 seconds.
== Parked SIP/1135-0910b0a0 on 702 (lot default). Will timeout back to extension [park-dial] 9999, 1 in 60 seconds
Comments:By: Mat Murdock (mmurdock) 2009-08-21 16:25:13

Correction, the second dial plan should read:

exten => _7Z,n,Set(PARKINGEXTEN=702)
exten => _7Z,n,Park(60000,park-dial,9999,1)
By: Sean Bright (seanbright) 2009-09-02 15:29:29

"It is expected that this be in seconds."

Why is that expected?
By: Mat Murdock (mmurdock) 2009-09-02 15:35:17

It is expected to be in seconds because most if not all asterisk functions that deal with time are measured in seconds.  Also the "parkingtime" option in features.conf is measured in seconds.
By: Sean Bright (seanbright) 2009-09-02 15:39:26

So is updating the documentation to indicate that it expects milliseconds a sufficient fix?
By: Mat Murdock (mmurdock) 2009-09-02 16:41:11

That would be fine.  Interestingly enough the Answer() application is in seconds while the Wait() application is in milliseconds.  Standardizing on a single unit of measure might be nice.
By: Clod Patry (junky) 2009-09-02 17:04:13

mmurock: that's not quite true.
Answer() accepts ms and not s.
Wait() accepts s and not s.


I agree with you that all the time should be standardize. To me, ms is a better option.

seanbright: I think we can only do this if we avoid the standardization. That will be a cool discussion at astricon!
By: Sean Bright (seanbright) 2009-09-02 17:09:15

We aren't going to be able to standardize as most of the applications we are talking about have been out in the wild for quite some time.  When was the timeout argument introduced to the Park() application?  If it is already in a release version, we are going to have to stick with millis.
By: Mat Murdock (mmurdock) 2009-09-02 17:14:58

Your right Junky.
Answer()= ms
Wait() = sec.
By: Leif Madsen (lmadsen) 2009-09-22 09:02:13

Changing this status to Confirmed as I talked to Junky the other day, and he knows of this issue, but has just been busy. He'll get back to it when he can.
By: Digium Subversion (svnbot) 2010-12-20 10:18:04.000-0600

Repository: asterisk
Revision: 299087

U   branches/1.6.2/main/features.c

------------------------------------------------------------------------
r299087 | lmadsen | 2010-12-20 10:18:04 -0600 (Mon, 20 Dec 2010) | 5 lines

Note that Park() timeout is milliseconds.

(closes issue ASTERISK-14691)
Reported by: mmurdock
Tested by: mmurdock, seanbright
------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299087
By: Digium Subversion (svnbot) 2010-12-20 10:18:27.000-0600

Repository: asterisk
Revision: 299088

_U  branches/1.8/
U   branches/1.8/main/features.c

------------------------------------------------------------------------
r299088 | lmadsen | 2010-12-20 10:18:27 -0600 (Mon, 20 Dec 2010) | 13 lines

Merged revisions 299087 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r299087 | lmadsen | 2010-12-20 10:18:03 -0600 (Mon, 20 Dec 2010) | 5 lines
 
 Note that Park() timeout is milliseconds.
 
 (closes issue ASTERISK-14691)
 Reported by: mmurdock
 Tested by: mmurdock, seanbright
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299088
By: Digium Subversion (svnbot) 2010-12-20 10:19:23.000-0600

Repository: asterisk
Revision: 299089

_U  trunk/
U   trunk/main/features.c

------------------------------------------------------------------------
r299089 | lmadsen | 2010-12-20 10:19:23 -0600 (Mon, 20 Dec 2010) | 20 lines

Merged revisions 299088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r299088 | lmadsen | 2010-12-20 10:18:26 -0600 (Mon, 20 Dec 2010) | 13 lines
 
 Merged revisions 299087 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r299087 | lmadsen | 2010-12-20 10:18:03 -0600 (Mon, 20 Dec 2010) | 5 lines
   
   Note that Park() timeout is milliseconds.
   
   (closes issue ASTERISK-14691)
   Reported by: mmurdock
   Tested by: mmurdock, seanbright
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=299089