Asterisk
  1. Asterisk
  2. ASTERISK-14830

[patch] handle_response check for retransmits when using TCP/TLS

        Details

        • Type: Bug Bug
        • Status: Closed
        • Severity: Major Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Target Release Version/s: None
        • Component/s: Channels/chan_sip/TCP-TLS
        • Labels:
          None
        • SVN Revision Number:
          218463
        • Mantis ID:
          15896
        • Regression:
          No

          Description

          Since we don't use reliable xmit when using TCP/TLS(since TCP is reliable in itself), we should not be attempting to ack retransmitted packets in handle_response().

                    • ADDITIONAL INFORMATION ******

          —
          /* Acknowledge whatever it is destined for */
          if ((resp >= 100) && (resp <= 199))

          { ack_res = __sip_semi_ack(p, seqno, 0, sipmethod); }

          else

          { ack_res = __sip_ack(p, seqno, 0, sipmethod); }

          if (ack_res == FALSE)

          { append_history(p, "Ignore", "Ignoring this retransmit\n"); return; }

          —

          ack_res will always return FALSE when using tcp/tls, resulting in the dialog never being completed, as we return from handle_response() before actually doing anything.

            Activity

            Hide
            Permalink
            Joshua Colp added a comment -

            I was unaware of this issue while testing this morning and fixed it the same way. The revisions are below:

            trunk - 218918
            1.6.0 - 218931
            1.6.1 - 218932
            1.6.2 - 218934

            Show
            Joshua Colp added a comment - I was unaware of this issue while testing this morning and fixed it the same way. The revisions are below: trunk - 218918 1.6.0 - 218931 1.6.1 - 218932 1.6.2 - 218934

              People

              • Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development