Asterisk
  1. Asterisk
  2. ASTERISK-15154

[patch] VM_DATE does not follow emaildateformat format for pager email

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • SVN Revision Number:
      230419
    • Mantis ID:
      16263
    • Regression:
      No

      Description

      VM_DATE should be formatted by the emaildateformat string in the voicemail.conf file (or the default). It's not... it just uses a fixed format.

      If you think it should NOT be formatted as per the emaildateformat, then there should be a pagerdateformat or a some other format string. The default should at least be shorter (eg. "%T %D"), this is a short message to a pager!

                • ADDITIONAL INFORMATION ******

      Note: This seems to affect all new and old versions.

      1. date.patch
        0.5 kB
        Andrew Lindh
      2. pagerdate.patch
        2 kB
        Andrew Lindh

        Issue Links

          Activity

          Hide
          Leif Madsen added a comment -

          I'm marking this as a feature for now, although it may end up being deemed a bug, but changes in functionality (even if "wrong") could break existing configurations, so typically these kinds of changes will go into trunk as a feature change with a note in UPGRADE.txt.

          I'll allow a developer to make the judgement call. You're also welcome to get some other testers of your patch on the asterisk-users and/or asterisk-dev mailing lists.

          Thanks for the contribution!

          Show
          Leif Madsen added a comment - I'm marking this as a feature for now, although it may end up being deemed a bug, but changes in functionality (even if "wrong") could break existing configurations, so typically these kinds of changes will go into trunk as a feature change with a note in UPGRADE.txt. I'll allow a developer to make the judgement call. You're also welcome to get some other testers of your patch on the asterisk-users and/or asterisk-dev mailing lists. Thanks for the contribution!
          Hide
          Andrew Lindh added a comment -

          The second patch adds "pagerdateformat" to the voicemail.conf file. It has the same format as "emaildateformat" but is used for the pager message. This does not change the default date format for existing pager users. Example config file patch included.

          Show
          Andrew Lindh added a comment - The second patch adds "pagerdateformat" to the voicemail.conf file. It has the same format as "emaildateformat" but is used for the pager message. This does not change the default date format for existing pager users. Example config file patch included.
          Hide
          Leif Madsen added a comment -

          Thanks!

          Show
          Leif Madsen added a comment - Thanks!
          Hide
          Digium Subversion added a comment -

          Repository: asterisk
          Revision: 232916

          U trunk/CHANGES
          U trunk/apps/app_voicemail.c
          U trunk/configs/voicemail.conf.sample

          ------------------------------------------------------------------------
          r232916 | tilghman | 2009-12-03 16:21:36 -0600 (Thu, 03 Dec 2009) | 7 lines

          Add pagerdateformat, to allow shorter dates for SMS messages.
          (closes issue ASTERISK-15154)
          Reported by: andrew
          Patches:
          pagerdate.patch uploaded by andrew (license 240)
          (with a slight modification by me)

          ------------------------------------------------------------------------

          http://svn.digium.com/view/asterisk?view=rev&revision=232916

          Show
          Digium Subversion added a comment - Repository: asterisk Revision: 232916 U trunk/CHANGES U trunk/apps/app_voicemail.c U trunk/configs/voicemail.conf.sample ------------------------------------------------------------------------ r232916 | tilghman | 2009-12-03 16:21:36 -0600 (Thu, 03 Dec 2009) | 7 lines Add pagerdateformat, to allow shorter dates for SMS messages. (closes issue ASTERISK-15154 ) Reported by: andrew Patches: pagerdate.patch uploaded by andrew (license 240) (with a slight modification by me) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=232916

            People

            • Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development