[Home]

Summary:ASTERISK-15154: [patch] VM_DATE does not follow emaildateformat format for pager email
Reporter:Andrew Lindh (andrew)Labels:
Date Opened:2009-11-17 15:12:00.000-0600Date Closed:2009-12-03 16:21:38.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) date.patch
( 1) pagerdate.patch
Description:VM_DATE should be formatted by the emaildateformat string in the voicemail.conf file (or the default). It's not... it just uses a fixed format.

If you think it should NOT be formatted as per the emaildateformat, then there should be a pagerdateformat or a some other format string. The default should at least be shorter (eg. "%T %D"), this is a short message to a pager!

****** ADDITIONAL INFORMATION ******

Note: This seems to affect all new and old versions.
Comments:By: Leif Madsen (lmadsen) 2009-11-18 10:07:31.000-0600

I'm marking this as a feature for now, although it may end up being deemed a bug, but changes in functionality (even if "wrong") could break existing configurations, so typically these kinds of changes will go into trunk as a feature change with a note in UPGRADE.txt.

I'll allow a developer to make the judgement call. You're also welcome to get some other testers of your patch on the asterisk-users and/or asterisk-dev mailing lists.

Thanks for the contribution!

By: Andrew Lindh (andrew) 2009-11-18 13:10:57.000-0600

The second patch adds "pagerdateformat" to the voicemail.conf file. It has the same format as "emaildateformat" but is used for the pager message. This does not change the default date format for existing pager users. Example config file patch included.

By: Leif Madsen (lmadsen) 2009-11-18 13:54:45.000-0600

Thanks!

By: Digium Subversion (svnbot) 2009-12-03 16:21:37.000-0600

Repository: asterisk
Revision: 232916

U   trunk/CHANGES
U   trunk/apps/app_voicemail.c
U   trunk/configs/voicemail.conf.sample

------------------------------------------------------------------------
r232916 | tilghman | 2009-12-03 16:21:36 -0600 (Thu, 03 Dec 2009) | 7 lines

Add pagerdateformat, to allow shorter dates for SMS messages.
(closes issue ASTERISK-15154)
Reported by: andrew
Patches:
      pagerdate.patch uploaded by andrew (license 240)
      (with a slight modification by me)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=232916