Asterisk
  1. Asterisk
  2. ASTERISK-15268

[patch] Add support for ring indication when calling member

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Severity: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Applications/app_queue
    • Labels:
      None
    • SVN Revision Number:
      232810
    • Mantis ID:
      16384
    • Regression:
      No

      Description

      A lot of ACD systems out there play MOH until a member/agent is ready for a new call, and then plays normal ring indication until you get an answer.

      This is a nice thing to have, since the caller might have been in the queue for quite a while, and put his phone down. As he hears the ring indication, he have time enough to pick up the phone before the agent answers.

      This introduces a new parameter 'R' to the Queue application.

                • ADDITIONAL INFORMATION ******

      (I added the "ringing" option to the queue_entity struct. Which I felt was more logical. This however means that a lot of function calls in app_queue don't really need the "ringing" function parameter anymore, as most of the functions also have a reference to the current queue entity.

      But as the bug guidelines say, I should minimize impact on the code, so I let the old functions be, as it has no functional difference.) – per reporter, this is no longer an issue as the patch has been updated. <lmadsen>

      1. app_queue.c.patch
        3 kB
        Håkon Nessjøen
      2. new_app_queue.c.patch
        2 kB
        Håkon Nessjøen

        Issue Links

          Activity

          Hide
          Ronald Chan added a comment -

          haakon, thanks for the patch it works great for me too

          Show
          Ronald Chan added a comment - haakon, thanks for the patch it works great for me too
          Hide
          Digium Subversion added a comment -

          Repository: asterisk
          Revision: 236304

          U trunk/apps/app_queue.c

          ------------------------------------------------------------------------
          r236304 | dvossel | 2009-12-23 12:39:37 -0600 (Wed, 23 Dec 2009) | 12 lines

          new parameter 'R' to the Queue application

          The 'R' argument stops moh and indicates ringing once the agent is
          ringing. This allows the person in the queue to know their call
          is potentially about to be answered.

          (closes issue ASTERISK-15268)
          Reported by: haakon
          Patches:
          new_app_queue.c.patch uploaded by haakon (license 880)
          Tested by: haakon, loloski, dvossel

          ------------------------------------------------------------------------

          http://svn.digium.com/view/asterisk?view=rev&revision=236304

          Show
          Digium Subversion added a comment - Repository: asterisk Revision: 236304 U trunk/apps/app_queue.c ------------------------------------------------------------------------ r236304 | dvossel | 2009-12-23 12:39:37 -0600 (Wed, 23 Dec 2009) | 12 lines new parameter 'R' to the Queue application The 'R' argument stops moh and indicates ringing once the agent is ringing. This allows the person in the queue to know their call is potentially about to be answered. (closes issue ASTERISK-15268 ) Reported by: haakon Patches: new_app_queue.c.patch uploaded by haakon (license 880) Tested by: haakon, loloski, dvossel ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236304
          Hide
          Digium Subversion added a comment -

          Repository: asterisk
          Revision: 236305

          _U branches/1.6.2/

          ------------------------------------------------------------------------
          r236305 | dvossel | 2009-12-23 12:40:22 -0600 (Wed, 23 Dec 2009) | 18 lines

          Blocked revisions 236304 via svnmerge

          ........
          r236304 | dvossel | 2009-12-23 12:39:37 -0600 (Wed, 23 Dec 2009) | 12 lines

          new parameter 'R' to the Queue application

          The 'R' argument stops moh and indicates ringing once the agent is
          ringing. This allows the person in the queue to know their call
          is potentially about to be answered.

          (closes issue ASTERISK-15268)
          Reported by: haakon
          Patches:
          new_app_queue.c.patch uploaded by haakon (license 880)
          Tested by: haakon, loloski, dvossel
          ........

          ------------------------------------------------------------------------

          http://svn.digium.com/view/asterisk?view=rev&revision=236305

          Show
          Digium Subversion added a comment - Repository: asterisk Revision: 236305 _U branches/1.6.2/ ------------------------------------------------------------------------ r236305 | dvossel | 2009-12-23 12:40:22 -0600 (Wed, 23 Dec 2009) | 18 lines Blocked revisions 236304 via svnmerge ........ r236304 | dvossel | 2009-12-23 12:39:37 -0600 (Wed, 23 Dec 2009) | 12 lines new parameter 'R' to the Queue application The 'R' argument stops moh and indicates ringing once the agent is ringing. This allows the person in the queue to know their call is potentially about to be answered. (closes issue ASTERISK-15268 ) Reported by: haakon Patches: new_app_queue.c.patch uploaded by haakon (license 880) Tested by: haakon, loloski, dvossel ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236305
          Hide
          Digium Subversion added a comment -

          Repository: asterisk
          Revision: 236306

          U trunk/CHANGES
          U trunk/apps/app_queue.c

          ------------------------------------------------------------------------
          r236306 | dvossel | 2009-12-23 12:45:54 -0600 (Wed, 23 Dec 2009) | 4 lines

          update CHANGES to reflect new 'R' app_queue option plus a minor optimization to the feature patch

          (issue ASTERISK-15268)

          ------------------------------------------------------------------------

          http://svn.digium.com/view/asterisk?view=rev&revision=236306

          Show
          Digium Subversion added a comment - Repository: asterisk Revision: 236306 U trunk/CHANGES U trunk/apps/app_queue.c ------------------------------------------------------------------------ r236306 | dvossel | 2009-12-23 12:45:54 -0600 (Wed, 23 Dec 2009) | 4 lines update CHANGES to reflect new 'R' app_queue option plus a minor optimization to the feature patch (issue ASTERISK-15268 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236306
          Hide
          Digium Subversion added a comment -

          Repository: asterisk
          Revision: 236307

          _U branches/1.6.2/

          ------------------------------------------------------------------------
          r236307 | dvossel | 2009-12-23 12:46:18 -0600 (Wed, 23 Dec 2009) | 10 lines

          Blocked revisions 236306 via svnmerge

          ........
          r236306 | dvossel | 2009-12-23 12:45:54 -0600 (Wed, 23 Dec 2009) | 4 lines

          update CHANGES to reflect new 'R' app_queue option plus a minor optimization to the feature patch

          (issue ASTERISK-15268)
          ........

          ------------------------------------------------------------------------

          http://svn.digium.com/view/asterisk?view=rev&revision=236307

          Show
          Digium Subversion added a comment - Repository: asterisk Revision: 236307 _U branches/1.6.2/ ------------------------------------------------------------------------ r236307 | dvossel | 2009-12-23 12:46:18 -0600 (Wed, 23 Dec 2009) | 10 lines Blocked revisions 236306 via svnmerge ........ r236306 | dvossel | 2009-12-23 12:45:54 -0600 (Wed, 23 Dec 2009) | 4 lines update CHANGES to reflect new 'R' app_queue option plus a minor optimization to the feature patch (issue ASTERISK-15268 ) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=236307

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development