[Home]

Summary:ASTERISK-15463: [patch] Extend the max number of callgroups/pickupgroups
Reporter:raarts (raarts)Labels:
Date Opened:2010-01-18 16:10:54.000-0600Date Closed:2012-09-05 09:20:39
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/NewFeature
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) moregroups.patch
Description:Currently the number of callgroups/pickupgroups is limited to 63, because the variable type that holds the group bits is a long long.

Here's a patch that extends this variable to an arbitrary-length (determined at compile time) int array. It currently sets the max number of groups to 1024.
It implements this for all channels, but I only tested SIP and DAHDI.



****** ADDITIONAL INFORMATION ******

Some people might object to implementing this as an array of ints, because it introduces a loop. But I think call pickups are not done often enough for this to become a problem.
Comments:By: Leif Madsen (lmadsen) 2010-01-19 07:28:35.000-0600

Huh, I thought this had already been done, but apparently I was wrong :)

Thanks for the contribution! Since this appears to be a fairly substantial patch, this would be a good candidate for reviewboard (reviewboard.asterisk.org).
By: raarts (raarts) 2010-01-19 07:32:12.000-0600

I'm sorry, does that mean I need to do something now?
By: raarts (raarts) 2010-01-19 07:39:09.000-0600

Ok, I get it now, I just submitted it for review.
By: Leif Madsen (lmadsen) 2010-01-19 10:53:34.000-0600

Can you let me know what the link is to the review you posted so I can link to it here in the issue for reference? Thanks!
By: raarts (raarts) 2010-01-19 16:13:13.000-0600

Here's the reviewboard link: https://reviewboard.asterisk.org/r/466/
By: Russell Bryant (russell) 2010-01-28 11:35:19.000-0600

Thanks a lot for the patch!  I'm actually going to suspect the review request for now until we can get a committer assigned to this patch to review.  Once someone is assigned to this issue, we can open it back up.
By: raarts (raarts) 2010-06-15 16:13:25

The reviewboard says: this patch has been discarded, but this bug description isn't updated. Also there's no explanation as to why it's discarded.
By: Paul Belanger (pabelanger) 2010-06-15 16:33:04

Simply reopen your reviewboard posting, we can then continue through the review process.
By: raarts (raarts) 2010-06-15 17:17:10

Ok done, re-opened. I'd like this to go into 1.8.
By: Sebastian Denz (denzs) 2011-04-20 03:12:17

Are there any news on this topic?
I would appreciate using Asterisk 1.8 with more than 64 pickupgroups too...
By: Leif Madsen (lmadsen) 2011-05-23 10:38:40

As this is a new feature, it can only be committed to trunk at this point, but if the patch applies cleanly to 1.8 you could apply it locally.
By: Matt Jordan (mjordan) 2012-09-05 09:20:39.667-0500

The number of callgroups/pickupgroups is effectively unlimited in Asterisk 11, due to the creation of named callgroups/pickupgroups.  This is a different approach than what is advocated on this issue, but it captures the intent of this patch.

For more information, please see https://wiki.asterisk.org/wiki/display/AST/New+in+11