[Home]

Summary:ASTERISK-15520: [patch] [regression] T.38 negotiation Broken
Reporter:Matteo (mpiazzatnetbug)Labels:
Date Opened:2010-01-26 08:42:46.000-0600Date Closed:2010-08-19 15:02:54
Priority:MajorRegression?Yes
Status:Closed/CompleteComponents:Channels/chan_sip/T.38
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) issue16705_1.diff
( 1) issue16705_2.diff
( 2) puttyt38229.zip.zip
Description:After upgrading from 1.4.26.3 to 1.4.29 the T.38 negoation seems broken. Probably this issue is a replication of 0016318 . Unfortunatly on the 1.4.29 it's look like the issue it's not totally fixed.
I try to send a fax from an ATA to a fan on analog line.
ATA -> Asterisk -> Patton SN4091

When the fax answer the asterisk don't handle properly the call, on the CLI I can see the message "Start music on hold" link with the ATA sip channel.

As attachment the log of the console

****** ADDITIONAL INFORMATION ******

Back to 1.4.26.3 works fine.
Comments:By: Kristijan Vrban (vrban) 2010-01-28 10:36:59.000-0600

same error here, see:
http://lists.digium.com/pipermail/asterisk-dev/2010-January/041686.html
By: Matteo (mpiazzatnetbug) 2010-02-03 05:09:09.000-0600

Any news? I'm available to do some tests but i need someone to drive me.
By: Elazar Broad (ebroad) 2010-02-03 17:10:39.000-0600

The attached patch is based on a hunch that I have after looking through the code. Unfortunately, I do not have time to test it.

Edit: Looks like we have an issue with gcc and sockaddr_in structs:

struct sockaddr_in foo;
if (!foo.sin_addr.s_addr)
   printf("We should never get here");

gcc -O2: printf fires
gcc -g: printf doesn't fire


By: Elazar Broad (ebroad) 2010-02-04 10:03:30.000-0600

Ignore the first patch, it won't fix anything, all it will do is make DONT_OPTIMIZE behave like an optimized build. Please test the 2nd patch and report back. Thanks!

elazar
By: Kristijan Vrban (vrban) 2010-02-05 09:33:11.000-0600

I just tested patch issue16705_2.diff is working fine!
By: Elazar Broad (ebroad) 2010-02-05 09:43:25.000-0600

Sweet! Thanks for testing vrban!
By: c0rnoTa (c0rnota) 2010-02-05 12:00:49.000-0600

Yes. Thanks, edroad. It works!
By: Matteo (mpiazzatnetbug) 2010-03-30 04:17:58

It works.
By: Matteo (mpiazzatnetbug) 2010-04-07 07:04:01

Can we do something more to close the ticket and see the patch included into a stable release?
By: Matteo (mpiazzatnetbug) 2010-04-26 01:50:52

Hello ?


I repeat my question:
Can we do something more to close the ticket and see the patch included into a stable release?
By: Sam Deller (samdell3) 2010-05-26 00:44:34

Identical bug exists in 1.4.30 and very likely 1.4.31

Tested issue16705_2.diff patch on v1.4.30 and now it works just beautiful.
By: Paul Belanger (pabelanger) 2010-06-29 12:59:17

Added to reviewboard.
By: Digium Subversion (svnbot) 2010-07-19 15:56:06

Repository: asterisk
Revision: 277944

U   branches/1.4/channels/chan_sip.c

------------------------------------------------------------------------
r277944 | pabelanger | 2010-07-19 15:56:05 -0500 (Mon, 19 Jul 2010) | 16 lines

Regression with T.38 negotiation

Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
of the reporter.  

(issue ASTERISK-15646)
Reported by: cfc

(closes issue ASTERISK-15520)
Reported by: mpiazzatnetbug
Patches:
     issue16705_2.diff uploaded by ebroad (license 878)
Tested by: vrban, ebroad, c0rnoTa, samdell3

Review: https://reviewboard.asterisk.org/r/754/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=277944
By: Digium Subversion (svnbot) 2010-08-19 14:43:59

Repository: asterisk
Revision: 282859

U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r282859 | mnicholson | 2010-08-19 14:43:58 -0500 (Thu, 19 Aug 2010) | 23 lines

Merged revisions 277944 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
 
 Regression with T.38 negotiation
 
 Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
 of the reporter.  
 
 (issue ASTERISK-15646)
 Reported by: cfc
 
 (closes issue ASTERISK-15520)
 Reported by: mpiazzatnetbug
 Patches:
       issue16705_2.diff uploaded by ebroad (license 878)
 Tested by: vrban, ebroad, c0rnoTa, samdell3
 
 Review: https://reviewboard.asterisk.org/r/754/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282859
By: Digium Subversion (svnbot) 2010-08-19 15:01:10

Repository: asterisk
Revision: 282860

_U  branches/1.8/
U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r282860 | mnicholson | 2010-08-19 15:01:09 -0500 (Thu, 19 Aug 2010) | 30 lines

Merged revisions 282859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r282859 | mnicholson | 2010-08-19 14:44:00 -0500 (Thu, 19 Aug 2010) | 23 lines
 
 Merged revisions 277944 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
   
   Regression with T.38 negotiation
   
   Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
   of the reporter.  
   
   (issue ASTERISK-15646)
   Reported by: cfc
   
   (closes issue ASTERISK-15520)
   Reported by: mpiazzatnetbug
   Patches:
         issue16705_2.diff uploaded by ebroad (license 878)
   Tested by: vrban, ebroad, c0rnoTa, samdell3
   
   Review: https://reviewboard.asterisk.org/r/754/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282860
By: Digium Subversion (svnbot) 2010-08-19 15:02:51

Repository: asterisk
Revision: 282861

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r282861 | mnicholson | 2010-08-19 15:02:51 -0500 (Thu, 19 Aug 2010) | 37 lines

Merged revisions 282860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r282860 | mnicholson | 2010-08-19 15:01:11 -0500 (Thu, 19 Aug 2010) | 30 lines
 
 Merged revisions 282859 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r282859 | mnicholson | 2010-08-19 14:44:00 -0500 (Thu, 19 Aug 2010) | 23 lines
   
   Merged revisions 277944 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r277944 | pabelanger | 2010-07-19 15:56:07 -0500 (Mon, 19 Jul 2010) | 16 lines
     
     Regression with T.38 negotiation
     
     Prior to 1.4.26.3 T.38 negotiation worked properly, in the case
     of the reporter.  
     
     (issue ASTERISK-15646)
     Reported by: cfc
     
     (closes issue ASTERISK-15520)
     Reported by: mpiazzatnetbug
     Patches:
           issue16705_2.diff uploaded by ebroad (license 878)
     Tested by: vrban, ebroad, c0rnoTa, samdell3
     
     Review: https://reviewboard.asterisk.org/r/754/
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282861