Summary:	ASTERISK-15521: SIP URIs are not always parsed correctly
Reporter:	nick_lewis (nick_lewis)	Labels:
Date Opened:	2010-01-26 09:58:01.000-0600	Date Closed:	2015-02-25 20:21:44.000-0600
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_sip/Interoperability
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	There are many sip headers containing uris that chan_sip.c does not parse correctly. There is already a function parse_uri that does correctly parse uris but for many headers it is not used. ****** ADDITIONAL INFORMATION ****** Examples of headers that could benefit from parse_uri are: "p-asserted-id", "remote-party-id", "diversion", "refer-to", "referred-by", "also" Also some headers do make use of parse_uri in some sip methods but not others. Examples include the request-line the to-header and the from-header There are even examples of some parts of uris being got with parse_uri will other parts are got using incorrect code such as in the get_domain function
Comments:	By: Matt Jordan (mjordan) 2015-02-25 20:21:35.965-0600 I know this issue was filed a long time ago, but without a patch, I would not expect parsing of various headers to be changed unless there is an actual bug with the parsing of that header. Note that there have been improvements in some URI parsing within Asterisk's {{chan_sip}}. Without an actual patch that can be looked at and compared to a currently supported branch, this is really an improvement request without a patch. As such, I'm going to close it out as "Suspended". If someone would like to improve any of the URI handling in {{chan_sip}}, commenting on this issue and providing a patch would certainly be appreciated.