[Home]

Summary:ASTERISK-15684: [patch] Realtime queue does not re-read announce variable from mysql after first use
Reporter:Håkon Nessjøen (haakon)Labels:
Date Opened:2010-02-24 07:39:50.000-0600Date Closed:2010-09-17 16:10:04
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_queue
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100818__issue16893.diff.txt
Description:I am using realtime queues extensively with * 1.6.1.

Everything works great. Asterisk reads new values from the queue table each time a user enters the queue.
Except from one thing: announcements. The "announce" variable from the queue table, doesn't seem to be read more than once, if it has already found a value.

Example:
I create a queue in the queue table, and add announce = "my_audio_file"
Then I call in, and the agent gets the audio file played correctly before they are set up.

Then I set the announce field to NULL, or empty it with a empty string.
Now if i call in, the agent still gets the audio file set up earlier.

I even tried changing the ID of the queue entry in mysql (because i know the queue_members table require this).
But it still reads the "ghost" value of announce.
Comments:By: Leif Madsen (lmadsen) 2010-02-25 12:22:32.000-0600

Thanks for the report. This seems to provide enough information to determine what is going on. Seems like the information is being cached into memory and not released.

If you unload app_queue.so and then load it back in, does that remove it from memory? (just curious -- this is obviously not a solution).
By: Tilghman Lesher (tilghman) 2010-07-20 18:30:43

In your description, you say that you set the announce field to NULL or to the empty string.  It should not work the same way if you do either.  NULL is a special value in realtime that means "act like this field doesn't exist", whereas an empty string does exist.  When set to NULL, the value does not propagate back to the queue, so it cannot reset the value.
By: Tilghman Lesher (tilghman) 2010-07-20 18:44:31

Are you actually setting the value to NULL or to blank?
By: Håkon Nessjøen (haakon) 2010-07-26 07:09:17

I did test NULL and blank. None of them changed anything.
By: Tilghman Lesher (tilghman) 2010-08-18 12:25:28

Patch uploaded.  Please test and verify that it solves the problem for you.
By: Digium Subversion (svnbot) 2010-09-17 16:06:04

Repository: asterisk
Revision: 287386

U   branches/1.4/apps/app_queue.c

------------------------------------------------------------------------
r287386 | tilghman | 2010-09-17 16:06:04 -0500 (Fri, 17 Sep 2010) | 7 lines

Blank columns should get set on reload, not ignored.

(closes issue ASTERISK-15684)
Reported by: haakon
Patches:
      20100818__issue16893.diff.txt uploaded by tilghman (license 14)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287386
By: Digium Subversion (svnbot) 2010-09-17 16:08:01

Repository: asterisk
Revision: 287387

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_queue.c

------------------------------------------------------------------------
r287387 | tilghman | 2010-09-17 16:08:01 -0500 (Fri, 17 Sep 2010) | 14 lines

Merged revisions 287386 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r287386 | tilghman | 2010-09-17 16:06:03 -0500 (Fri, 17 Sep 2010) | 7 lines
 
 Blank columns should get set on reload, not ignored.
 
 (closes issue ASTERISK-15684)
  Reported by: haakon
  Patches:
        20100818__issue16893.diff.txt uploaded by tilghman (license 14)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287387
By: Digium Subversion (svnbot) 2010-09-17 16:08:55

Repository: asterisk
Revision: 287388

_U  branches/1.8/
U   branches/1.8/apps/app_queue.c

------------------------------------------------------------------------
r287388 | tilghman | 2010-09-17 16:08:55 -0500 (Fri, 17 Sep 2010) | 21 lines

Merged revisions 287387 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r287387 | tilghman | 2010-09-17 16:08:00 -0500 (Fri, 17 Sep 2010) | 14 lines
 
 Merged revisions 287386 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r287386 | tilghman | 2010-09-17 16:06:03 -0500 (Fri, 17 Sep 2010) | 7 lines
   
   Blank columns should get set on reload, not ignored.
   
   (closes issue ASTERISK-15684)
    Reported by: haakon
    Patches:
          20100818__issue16893.diff.txt uploaded by tilghman (license 14)
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287388
By: Digium Subversion (svnbot) 2010-09-17 16:10:03

Repository: asterisk
Revision: 287389

_U  trunk/
U   trunk/apps/app_queue.c

------------------------------------------------------------------------
r287389 | tilghman | 2010-09-17 16:10:03 -0500 (Fri, 17 Sep 2010) | 28 lines

Merged revisions 287388 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r287388 | tilghman | 2010-09-17 16:08:54 -0500 (Fri, 17 Sep 2010) | 21 lines
 
 Merged revisions 287387 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r287387 | tilghman | 2010-09-17 16:08:00 -0500 (Fri, 17 Sep 2010) | 14 lines
   
   Merged revisions 287386 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r287386 | tilghman | 2010-09-17 16:06:03 -0500 (Fri, 17 Sep 2010) | 7 lines
     
     Blank columns should get set on reload, not ignored.
     
     (closes issue ASTERISK-15684)
      Reported by: haakon
      Patches:
            20100818__issue16893.diff.txt uploaded by tilghman (license 14)
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=287389