Summary:	ASTERISK-15693: [patch] Incorrect pattern specificity in new dial pattern functions
Reporter:	nick_lewis (nick_lewis)	Labels:
Date Opened:	2010-02-25 09:40:33.000-0600	Date Closed:	2010-09-09 20:49:29
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	PBX/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) pbx.c-specificity.patch
Description:	An error appears to have crept in when copying the specificity of X, Z and N wildcards from the old dial pattern matching functions to the new ones. In the old functions the specificity is: X : 0x0A30 Z : 0x0931 N : 0x0832 which is the same as [0-9] : 0x0A30 [1-9] : 0x0931 [2-9] : 0x0832 but in the new functions the specificity is: X : 0x0A00 Z : 0x0901 N : 0x0802
Comments:	By: nick_lewis (nick_lewis) 2010-02-25 10:01:02.000-0600 In both the new and old functions the char set cardinality is set incorrectly to 0x00 for . and ! wildcards. These wildcards permit all ascii values from 0x00 to 0x7F so the cardinality should therefore be set to 0x80. This problem with . and ! does not cause symptoms at the moment but will prevent correct pattern ordering with the introduction of some proposed future wildcards By: Digium Subversion (svnbot) 2010-09-09 20:49:22 Repository: asterisk Revision: 285710 U   branches/1.6.2/main/pbx.c ------------------------------------------------------------------------ r285710 | bbryant | 2010-09-09 20:49:22 -0500 (Thu, 09 Sep 2010) | 8 lines Fixes an issue with dialplan pattern matching where the specificity for pattern ranges and pattern special characters was inconsistent. (closes issue ASTERISK-15693) Reported by: Nick_Lewis Patches:      pbx.c-specificity.patch uploaded by Nick Lewis (license 657) Tested by: Nick_Lewis ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285710 By: Digium Subversion (svnbot) 2010-09-09 20:49:25 Repository: asterisk Revision: 285711 _U  branches/1.8/ U   branches/1.8/main/pbx.c ------------------------------------------------------------------------ r285711 | bbryant | 2010-09-09 20:49:25 -0500 (Thu, 09 Sep 2010) | 15 lines Merged revisions 285710 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r285710 | bbryant | 2010-09-09 14:50:13 -0400 (Thu, 09 Sep 2010) | 8 lines    Fixes an issue with dialplan pattern matching where the specificity for pattern ranges and pattern special characters was inconsistent.    (closes issue ASTERISK-15693)  Reported by: Nick_Lewis  Patches:        pbx.c-specificity.patch uploaded by Nick Lewis (license 657)  Tested by: Nick_Lewis ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285711 By: Digium Subversion (svnbot) 2010-09-09 20:49:28 Repository: asterisk Revision: 285712 _U  trunk/ U   trunk/main/pbx.c ------------------------------------------------------------------------ r285712 | bbryant | 2010-09-09 20:49:28 -0500 (Thu, 09 Sep 2010) | 22 lines Merged revisions 285711 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r285711 | bbryant | 2010-09-09 14:51:52 -0400 (Thu, 09 Sep 2010) | 15 lines    Merged revisions 285710 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r285710 | bbryant | 2010-09-09 14:50:13 -0400 (Thu, 09 Sep 2010) | 8 lines        Fixes an issue with dialplan pattern matching where the specificity for pattern ranges and pattern special characters was inconsistent.        (closes issue ASTERISK-15693)    Reported by: Nick_Lewis    Patches:          pbx.c-specificity.patch uploaded by Nick Lewis (license 657)    Tested by: Nick_Lewis  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285712