[Home]

Summary:ASTERISK-15762: [patch] Cleanup transmit_ for handle_register and keepalives
Reporter:Damien Wedhorn (wedhorn)Labels:
Date Opened:2010-03-07 16:34:46.000-0600Date Closed:2010-07-30 04:12:55
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) skinny-clean06.diff
( 1) skinny-clean06b.diff
Description:Moved inline packet sending to transmit_ subs. Removed handle_keep_alive and handle_register_message to inline in handle_message.

Also moved transmit_response(d) to transmit_response_bysessions(s) and created a wrapper transmit_response(d) that calls transmit_response_bysession(d->session).
Comments:By: Damien Wedhorn (wedhorn) 2010-04-02 15:39:42

skinny-clean06b.diff added. Updates patch to r255952.
By: dea (dea) 2010-07-28 14:51:23

The good news is that the clean does not cause any new bugs.
The bad news is that is does not fix any of the open issues
either, but still worth merging.  Note that version 6b applies
to trunk with major fuzz, but no failures.
By: John Todd (jtodd) 2010-07-29 15:51:24

Go forth and commit if it works.  :-)
By: Leif Madsen (lmadsen) 2010-07-29 15:51:33

Just get this reviewed and then commit this :)
By: Digium Subversion (svnbot) 2010-07-30 04:12:53

Repository: asterisk
Revision: 280589

U   trunk/channels/chan_skinny.c

------------------------------------------------------------------------
r280589 | wedhorn | 2010-07-30 04:12:53 -0500 (Fri, 30 Jul 2010) | 12 lines

Cleanup transmit_ for handle_register and keepalives

Moved inline packet sending to transmit_ subs. Removed handle_keep_alive and handle_register_message to inline in handle_message. Also moved transmit_response(d) to transmit_response_bysessions(s) and created a wrapper transmit_response(d) that calls transmit_response_bysession(d->session).

(closes issue ASTERISK-15762)
Reported by: wedhorn
Patches:
     skinny-clean06b.diff uploaded by wedhorn (license 30)
Tested by: wedhorn, DEA

Review: NA

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=280589