Asterisk
  1. Asterisk
  2. ASTERISK-1590

[patch] manager_event and run_externnotify don't use context

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Labels:
      None
    • Mantis ID:
      1609
    • Regression:
      No

      Description

      app_hasvoicemail and run_externnotify only use the mailbox number when run, without using the context.

      In asterisk manager events, this means that it only works with mailboxes in the default context. If the mailbox is in a context other than 'default', it will not report new messages (it always returns 0).

      This patch fixes that.

                • ADDITIONAL INFORMATION ******

      Tested only by me. Need more testers!

      I already sent the disclaimer on january for bug 772.

        Activity

        Hide
        sbingner added a comment -

        Patch looks ok to me, I'll test when I get home...

        Show
        sbingner added a comment - Patch looks ok to me, I'll test when I get home...
        Hide
        James Golovich added a comment -

        Looks fine in the functionality department, but I've got a small formatting complaint.

        + snprintf(ext_context, sizeof(ext_context), "%s@%s",ext,vmu->context);

        Notice how the first few args are sepearted with a comma and a space, and the later args are seperated with just a comma. Please keep it consistent

        Show
        James Golovich added a comment - Looks fine in the functionality department, but I've got a small formatting complaint. + snprintf(ext_context, sizeof(ext_context), "%s@%s",ext,vmu->context); Notice how the first few args are sepearted with a comma and a space, and the later args are seperated with just a comma. Please keep it consistent
        Hide
        nicolasg added a comment -

        Hi James,

        I corrected the formatting. My mistake. Please remove the first patch file if you can. Thanks!

        Show
        nicolasg added a comment - Hi James, I corrected the formatting. My mistake. Please remove the first patch file if you can. Thanks!
        Hide
        Mark Spencer added a comment -

        Added to CVS, thanks.

        Show
        Mark Spencer added a comment - Added to CVS, thanks.
        Hide
        Digium Subversion added a comment -

        Repository: asterisk
        Revision: 2950

        U trunk/apps/app_voicemail.c
        U trunk/channels/chan_sip.c

        ------------------------------------------------------------------------
        r2950 | markster | 2008-01-15 14:54:30 -0600 (Tue, 15 Jan 2008) | 2 lines

        Put sip history stuff in (for real) and provide voicemail context (when not default) in some critical places (bug ASTERISK-1590)

        ------------------------------------------------------------------------

        http://svn.digium.com/view/asterisk?view=rev&revision=2950

        Show
        Digium Subversion added a comment - Repository: asterisk Revision: 2950 U trunk/apps/app_voicemail.c U trunk/channels/chan_sip.c ------------------------------------------------------------------------ r2950 | markster | 2008-01-15 14:54:30 -0600 (Tue, 15 Jan 2008) | 2 lines Put sip history stuff in (for real) and provide voicemail context (when not default) in some critical places (bug ASTERISK-1590 ) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=2950

          People

          • Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development