[Home]

Summary:ASTERISK-16056: [patch] chan_iax2 ignores the port in an SRV record
Reporter:John Covert (jcovert)Labels:
Date Opened:2010-05-05 13:29:56Date Closed:2011-05-07 18:26:07
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_iax.patch-fix-srvlookup
( 1) chan_iax2.c.1.8.3-srvlookup-corrected.patch
( 2) chan_iax2.c.srvllookup.1.8.3.patch
( 3) iax.conf.sample.1.8.3.patch
( 4) iax.conf.sample.patch
( 5) UPGRADE.txt.patch
Description:chan_iax2 ignores the port when doing an srv lookup.

The attached patch fixes this, and also turns srv lookup on by default.



****** ADDITIONAL INFORMATION ******

The attached patch is SVN 1.6.0 head.
Comments:By: Jared Smith (jsmith) 2010-05-05 13:49:48

Just a quick comment, but I think you may want to split this up into two separate patches.  I know they're both trivial, but we like making feature changes independently from bug fixes.  Also, if you're doing to default to doing SRV record lookups, you should also patch the iax.conf.sample file and UPGRADE.txt files to make it obvious that we're changing behavior here.

Other than that, the change looks fine to me.
By: John Covert (jcovert) 2010-05-05 14:20:19

There's one big reason I don't really want to split it:

srvlookup is pretty useless unless everyone is doing it.  if it isn't the default, then it's not particularly useful.

I'll add patches to iax.conf.sample and UPGRADE.txt.
By: Paul Belanger (pabelanger) 2010-05-05 15:10:32

Additional comment: If you are already working with a svn branch, please use `svn diff` for patches. Makes it easier to commit.

Thanks.
By: Paul Belanger (pabelanger) 2010-10-22 20:28:12

Are you able to confirm this is an issue with 1.6.2?

---
Per the Asterisk maintenance timeline page at http://www.asterisk.org/asterisk-versions maintenance (bug) support for the 1.6.0 and 1.6.1 branches has ended. For continued maintenance support please move to the 1.6.2 branch.

More information on this change can be found in the release announcement: http://www.asterisk.org/node/49924

By: John Covert (jcovert) 2011-02-16 20:07:32.000-0600

This is still an issue with 1.8.3-rc2

See supplied patches:

chan_iax2.c.srvllookup.1.8.3.patch
and
iax.conf.sample.1.8.3.patch
By: John Covert (jcovert) 2011-04-06 17:35:26

Patch above still needed.  Valid against head.
By: Digium Subversion (svnbot) 2011-05-07 18:24:20

Repository: asterisk
Revision: 318055

U   branches/1.8/channels/chan_iax2.c

------------------------------------------------------------------------
r318055 | russell | 2011-05-07 18:24:19 -0500 (Sat, 07 May 2011) | 7 lines

chan_iax2: Don't overwrite port found with an SRV lookup.

(closes issue ASTERISK-16056)
Reported by: jcovert
Patches:
     chan_iax2.c.1.8.3-srvlookup-corrected.patch uploaded by jcovert (license 551)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318055
By: Digium Subversion (svnbot) 2011-05-07 18:26:07

Repository: asterisk
Revision: 318056

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r318056 | russell | 2011-05-07 18:26:06 -0500 (Sat, 07 May 2011) | 14 lines

Merged revisions 318055 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r318055 | russell | 2011-05-07 18:24:18 -0500 (Sat, 07 May 2011) | 7 lines
 
 chan_iax2: Don't overwrite port found with an SRV lookup.
 
 (closes issue ASTERISK-16056)
 Reported by: jcovert
 Patches:
       chan_iax2.c.1.8.3-srvlookup-corrected.patch uploaded by jcovert (license 551)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=318056