Summary:	ASTERISK-16157: [patch] MoH not restarted after end of conference announcement is played
Reporter:	Sébastien Couture (sysreq)	Labels:
Date Opened:	2010-05-27 09:43:23	Date Closed:	2010-09-08 16:00:33
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_meetme
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-issue-17408_fixed.patch ( 1) asterisk-issue-17408.patch
Description:	When the "conference will end in X minutes" announcement is played, MoH is not restarted; you'd need to press '*' (considering you have the 's' MeetMe option set) then quit the user/admin menu for it to be started again. ****** ADDITIONAL INFORMATION ****** I've only added the following lines, which are also used when you exit the user/admin MeetMe menu and go back to the conference: if (musiconhold)  conf_start_moh(chan, optargs[OPT_ARG_MOH_CLASS]);
Comments:	By: Paul Belanger (pabelanger) 2010-05-27 09:48:45 Thanks for the patch, please add braces per CODING-GUIDELINES By: Sébastien Couture (sysreq) 2010-05-27 09:56:02 Sorry for that. So, the surrounding evaluations (that were already there) would also break the guidelines? By: Paul Belanger (pabelanger) 2010-05-27 10:44:49 Correct.  Any new code that is submitted will be enforced with the CODING-GUIDELINES.  Existing code, _should_ be updated, which is usually done when somebody decides to submit a formatting patch. By: Sébastien Couture (sysreq) 2010-05-27 10:51:18 Great. Thanks for the precision! By: Digium Subversion (svnbot) 2010-09-08 15:56:13 Repository: asterisk Revision: 285532 U   branches/1.6.2/apps/app_meetme.c ------------------------------------------------------------------------ r285532 | bbryant | 2010-09-08 15:56:12 -0500 (Wed, 08 Sep 2010) | 8 lines Fixes a bug with MeetMe where after announcing the amount of time left in a conference, if music on hold was playing, it doesn't restart. (closes issue ASTERISK-16157) Reported by: sysreq Patches:      asterisk-issue-17408_fixed.patch uploaded by sysreq (license 1009) Tested by: sysreq ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285532 By: Digium Subversion (svnbot) 2010-09-08 15:58:43 Repository: asterisk Revision: 285533 _U  branches/1.8/ U   branches/1.8/apps/app_meetme.c ------------------------------------------------------------------------ r285533 | bbryant | 2010-09-08 15:58:43 -0500 (Wed, 08 Sep 2010) | 15 lines Merged revisions 285532 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r285532 | bbryant | 2010-09-08 16:56:12 -0400 (Wed, 08 Sep 2010) | 8 lines    Fixes a bug with MeetMe where after announcing the amount of time left in a conference, if music on hold was playing, it doesn't restart.    (closes issue ASTERISK-16157)  Reported by: sysreq  Patches:        asterisk-issue-17408_fixed.patch uploaded by sysreq (license 1009)  Tested by: sysreq ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285533 By: Digium Subversion (svnbot) 2010-09-08 16:00:33 Repository: asterisk Revision: 285534 _U  trunk/ U   trunk/apps/app_meetme.c ------------------------------------------------------------------------ r285534 | bbryant | 2010-09-08 16:00:32 -0500 (Wed, 08 Sep 2010) | 22 lines Merged revisions 285533 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r285533 | bbryant | 2010-09-08 16:58:43 -0400 (Wed, 08 Sep 2010) | 15 lines    Merged revisions 285532 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r285532 | bbryant | 2010-09-08 16:56:12 -0400 (Wed, 08 Sep 2010) | 8 lines        Fixes a bug with MeetMe where after announcing the amount of time left in a conference, if music on hold was playing, it doesn't restart.        (closes issue ASTERISK-16157)    Reported by: sysreq    Patches:          asterisk-issue-17408_fixed.patch uploaded by sysreq (license 1009)    Tested by: sysreq  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285534