[Home]

Summary:ASTERISK-16172: Problems with siren14 codec; problems with siren7 sound files.
Reporter:Steve Murphy (murf)Labels:
Date Opened:2010-05-29 09:31:46Date Closed:2018-01-29 11:47:14.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Codecs/codec_siren14 Codecs/codec_siren7 Sounds
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:Using 1.6.2, I have obtained license from polycom for their siren codecs, and built the execs they supplied, and can generate siren7 and siren14 format files. Trouble is, how do I verify that I'm generating "the right stuff"? I don't have any siren7 or siren14 capable phones or devices.

So, Russell suggested I could simply force a conversion within codec_siren14 or codec_siren7 by playing them to my phone (which is g722). So, I tried that, for both codecs. And learned some interesting things:

1. siren14 files play back on g722 as garbage, mostly quiet garbage, with spikes of noisy garbage.
2. The siren7 recordings supplied with Asterisk also play back as garbage. But, mine don't!



****** STEPS TO REPRODUCE ******

1. Take a 44-48 khz .wav format sound file. Call is X.wav.

2. Convert it to siren7 via these commands:

   sox -v .7 X.wav -r 16000 -c 1 -t sw X.sln16
   asterisk -rx "file convert <path>/X.sln16 <path>/X.siren7"

3. Convert it to siren14 via these commands:

   sox -v .7 X.wav -r 32000 -c 1 -t sw X.sln32
   siren_encode 1 X.sln32 X.siren14 32000 14000


Keep in mind that I can't use the "file convert" to form siren14 files, because sln32 files are not a legal format. I'd have to assume that transcoding from siren14 to 8 or 16 bit formats is provided in the siren14 codec itself.

Also keep in mind that siren_encode was supplied to digium when the siren codecs were licensed from Polycom. They had to use them in some way to write the siren codecs. So grub around there somewhere, and you should be able to find it. It could be, that I'm using the wrong args. That might explain why my X.siren14 file sounds like garbage.


But it doesn't explain why a file from the 1.4.18 core soundset for siren14 plays back like garbage.

And it doesn't explain why a file from the 1.4.18 core soundset for siren7 plays back like garbage. Especially when my siren7 file (formed using the codec itself) plays back fine.


cp X.siren7 <varlibastsounds/en>/zzx.siren7
cp X.siren14 <varlibastsounds/en>/zzy.siren14

cp <varlibastsounds/en>/vm-options.siren7 <varlibastsounds/en>/yyx.siren7
cp <varlibastsounds/en>/vm-options.siren14 <varlibastsounds/en>/yyy.siren14

in the dialplan:

exten => 6668,1,Playback(yyx)  // your siren7
exten => 6668,n,Playback(beep)
exten => 6668,n,Playback(zzx)   // my siren7
exten => 6668,n,Playback(beep)
exten => 6668,n,Playback(yyy)   // your siren14
exten => 6668,n,Playback(beep)
exten => 6668,n,Playback(zzy)   // my siren14

Your goal is to make your siren7 and siren14 files play back on a g722 or ulaw or whatever phone.

My goal is to make mine sound OK.

Comments:By: Malcolm Davenport (mdavenport) 2010-06-02 14:30:28

Using Asterisk 1.6.2.6, codec_siren7.so from codec_siren7-1.6.2.0_1.0.5-i686_32, codec_siren14.so from codec_siren14-1.6.2.0_1.0.5-i686_32, and a Polycom VVX1500 Rev D running some development firmware (I don't have a release phone to test on), I'm not able to duplicate what you're seeing with Asterisk.

I can configure my phone for G.722 only and listen to the demo-congrats.siren14 and demo-congrats.siren7, that are derived from the stock Asterisk build configured to only include Siren7&Siren14 core sound files, and they sound fine.

I can configure my phone for G.722.1 only and listen to both files just fine.

I can configure my phone for G.722.1C only and listen to both files just fine.

By: Malcolm Davenport (mdavenport) 2010-06-09 09:55:42

murf, you out there?

By: Steve Murphy (murf) 2010-06-10 06:53:04

Yes, I'm out here. Seeing that you enjoy such flawless success, let me carve out some time and see why/how my tests are such miserable failures. It might be a week or two. I'll use the 1.4.19 set (now that they are out), and make sure my codecs are the latest.

By: Leif Madsen (lmadsen) 2010-06-23 12:00:42

Cool, let me know when you've performed some additional testing. Thanks!

By: Leif Madsen (lmadsen) 2010-09-09 12:24:04

Is there still interest in moving this issue forward?

By: Leif Madsen (lmadsen) 2011-02-08 13:41:01.000-0600

I'm going to close this issue because there isn't much movement on it, and is likely related (and potentially resolved) by the stuff David Vossel has been working on his FixTheWorld branches.

By: Alexander Traud (traud) 2017-11-26 12:06:10.060-0600

Sorry to re-open this. However, since version 1.4.18 (27th April 2010), the files for Siren7 and Siren14 are broken. I tested the file _demo-moreinfo_ with pjsua of PJProject 2.7. After [going back|http://downloads.asterisk.org/pub/telephony/sounds/releases/] to the files of 1.4.17, pjsua sounds as expected. Please, look in this especially because that version does not contain all sounds files of Asterisk 13 today. My workaround is not to select the Siren7 and Siren14 files within {{menuselect}}. That way, Asterisk transcodes from slin8, which gives at least narrow-band quality. Furthermore, I went for the patch in ASTERISK-23735 which gave me wide-band quality, because Asterisk transcodes from slin16, then.

By: Benjamin Keith Ford (bford) 2017-12-06 14:20:48.387-0600

Just tested the sound files and there is something going on with the 1.4.18 set. Opening up an issue for it.

By: Alexander Traud (traud) 2017-12-12 07:13:12.931-0600

Just to avoid a possible misunderstanding: The problem is even in the current set 1.5.1 (July 2017), tested with Asterisk 13.18.3. However, the issue was introduced with 1.4.18 because all releases since then behave the same.

By: Joshua C. Colp (jcolp) 2017-12-12 09:24:36.682-0600

I've fixed the underlying issue in the sounds creation process which resulted in this. Once I have a time frame on updated sounds I'll post here.

By: Joshua C. Colp (jcolp) 2018-01-26 15:48:28.688-0600

New releases have been done and the changes to update the version in Asterisk to use them is now up for review.

By: Friendly Automation (friendly-automation) 2018-01-29 11:47:15.054-0600

Change 8056 merged by Jenkins2:
Update sounds release to fix siren7 and siren14 files.

[https://gerrit.asterisk.org/8056|https://gerrit.asterisk.org/8056]

By: Friendly Automation (friendly-automation) 2018-01-29 11:56:18.789-0600

Change 8054 merged by Jenkins2:
Update sounds release to fix siren7 and siren14 files.

[https://gerrit.asterisk.org/8054|https://gerrit.asterisk.org/8054]

By: Friendly Automation (friendly-automation) 2018-01-29 11:59:17.821-0600

Change 8055 merged by Jenkins2:
Update sounds release to fix siren7 and siren14 files.

[https://gerrit.asterisk.org/8055|https://gerrit.asterisk.org/8055]