[Home]

Summary:ASTERISK-16233: [patch] "dahdi show channels group" auto-completion bug
Reporter:Fossard Florent (ffossard)Labels:
Date Opened:2010-06-09 17:02:53Date Closed:2011-04-15 10:20:48
Priority:TrivialRegression?No
Status:Closed/CompleteComponents:Channels/chan_dahdi
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:After typing "dahdi show channels group", the <tab> key adds a "group" of more:

localhost*CLI> dahdi show channels group group group group group group group
Usage: dahdi show channels [ trunkgroup <trunkgroup> | group <group> | context <context> ]
Shows a list of available channels with optional filtering
<group> must be a number between 0 and 63

=> <group> can't be a word, only a number, so auto-completion should not add the word "group"
Comments:By: Paul Belanger (pabelanger) 2010-06-10 14:27:35

The problem is having 'trunkgroup' and 'group' in the same e->command.  It seems substrings are a problem for asterisk.

By: Digium Subversion (svnbot) 2011-04-15 09:58:39

Repository: asterisk
Revision: 313859

U   branches/1.6.2/main/cli.c

------------------------------------------------------------------------
r313859 | jrose | 2011-04-15 09:58:38 -0500 (Fri, 15 Apr 2011) | 10 lines

Fix a Tab Completion bug that occurs due to multiple matches on a substring.

Makes word_match function in cli.c repeat a search for a command string until
a proper match is found or the string is searched to the last point.

(closes issue ASTERISK-16233)
Reported by: ffossard

Review: https://reviewboard.asterisk.org/r/1180/

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313859

By: Digium Subversion (svnbot) 2011-04-15 10:08:06

Repository: asterisk
Revision: 313860

_U  branches/1.8/
U   branches/1.8/main/cli.c

------------------------------------------------------------------------
r313860 | jrose | 2011-04-15 10:08:06 -0500 (Fri, 15 Apr 2011) | 17 lines

Merged revisions 313859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r313859 | jrose | 2011-04-15 09:58:37 -0500 (Fri, 15 Apr 2011) | 10 lines
 
 Fix a Tab Completion bug that occurs due to multiple matches on a substring.
 
 Makes word_match function in cli.c repeat a search for a command string until
 a proper match is found or the string is searched to the last point.
 
 (closes issue ASTERISK-16233)
 Reported by: ffossard
 
 Review: https://reviewboard.asterisk.org/r/1180/
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313860

By: Digium Subversion (svnbot) 2011-04-15 10:20:47

Repository: asterisk
Revision: 313867

_U  trunk/
U   trunk/main/cli.c

------------------------------------------------------------------------
r313867 | jrose | 2011-04-15 10:20:46 -0500 (Fri, 15 Apr 2011) | 24 lines

Merged revisions 313860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r313860 | jrose | 2011-04-15 10:08:05 -0500 (Fri, 15 Apr 2011) | 17 lines
 
 Merged revisions 313859 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r313859 | jrose | 2011-04-15 09:58:37 -0500 (Fri, 15 Apr 2011) | 10 lines
   
   Fix a Tab Completion bug that occurs due to multiple matches on a substring.
   
   Makes word_match function in cli.c repeat a search for a command string until
   a proper match is found or the string is searched to the last point.
   
   (closes issue ASTERISK-16233)
   Reported by: ffossard
   
   Review: https://reviewboard.asterisk.org/r/1180/
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=313867