Summary:	ASTERISK-16347: [patch] sounds/Makefile ignores checksum errors
Reporter:	Barry Miller (bjm)	Labels:
Date Opened:	2010-07-11 19:07:31	Date Closed:	2010-07-28 15:04:06
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Core/BuildSystem
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) diffs-trunk
Description:	While installing 1.6.2-SVN on OpenBSD 4.7, I got the disconcerting message "/bin/sh: sha1sum: not found", yet the install continued.  The sha1sum issue seems to be fixed in trunk,  but sounds/Makefile still ignores errors. It emits the "Bad checksum:" message and exits 1, but inside a subshell whose exit status is ignored.  So a symlink to the bad file is created in sounds/, and a 0 status is returned to make, letting the install continue with a dubious file in SOUNDS_CACHE_DIR.
Comments:	By: Barry Miller (bjm) 2010-07-11 20:53:54 I should add that I've seen NO problems with downloads.asterisk.org.  For testing I pointed SOUNDS_URL at a local server with .tar.gz and .tar.gz.sha1 files that didn't agree. By: Leif Madsen (lmadsen) 2010-07-12 11:02:36 Thanks for the report! By: Leif Madsen (lmadsen) 2010-07-12 11:02:56 Oh and there is a patch! Thanks! By: Digium Subversion (svnbot) 2010-07-28 13:05:53 Repository: asterisk Revision: 280193 U   branches/1.6.2/sounds/Makefile ------------------------------------------------------------------------ r280193 | qwell | 2010-07-28 13:05:53 -0500 (Wed, 28 Jul 2010) | 9 lines Remove unnecessary subshells.  Attempt to make checksumming work. Also improves readability. (issue ASTERISK-16347) Reported by: bjm Review: https://reviewboard.asterisk.org/r/808/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280193 By: Digium Subversion (svnbot) 2010-07-28 13:24:27 Repository: asterisk Revision: 280195 _U  branches/1.8/ U   branches/1.8/sounds/Makefile ------------------------------------------------------------------------ r280195 | qwell | 2010-07-28 13:24:27 -0500 (Wed, 28 Jul 2010) | 16 lines Merged revisions 280193 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r280193 | qwell | 2010-07-28 13:05:54 -0500 (Wed, 28 Jul 2010) | 9 lines    Remove unnecessary subshells.  Attempt to make checksumming work.    Also improves readability.    (issue ASTERISK-16347)  Reported by: bjm    Review: https://reviewboard.asterisk.org/r/808/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280195 By: Digium Subversion (svnbot) 2010-07-28 13:24:59 Repository: asterisk Revision: 280196 _U  trunk/ U   trunk/sounds/Makefile ------------------------------------------------------------------------ r280196 | qwell | 2010-07-28 13:24:59 -0500 (Wed, 28 Jul 2010) | 23 lines Merged revisions 280195 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r280195 | qwell | 2010-07-28 13:24:29 -0500 (Wed, 28 Jul 2010) | 16 lines    Merged revisions 280193 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r280193 | qwell | 2010-07-28 13:05:54 -0500 (Wed, 28 Jul 2010) | 9 lines        Remove unnecessary subshells.  Attempt to make checksumming work.        Also improves readability.        (issue ASTERISK-16347)    Reported by: bjm        Review: https://reviewboard.asterisk.org/r/808/  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280196 By: Jason Parker (jparker) 2010-07-28 13:26:32 These commits should make checksumming work much better now.  Could you try it and let me know? By: Digium Subversion (svnbot) 2010-07-28 15:02:26 Repository: asterisk Revision: 280231 U   branches/1.6.2/sounds/Makefile ------------------------------------------------------------------------ r280231 | qwell | 2010-07-28 15:02:25 -0500 (Wed, 28 Jul 2010) | 6 lines Work around some silly behavior on BSD. A non-zero exit from a subshell should make the build fail. (closes issue ASTERISK-16347) ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280231 By: Digium Subversion (svnbot) 2010-07-28 15:03:20 Repository: asterisk Revision: 280233 _U  branches/1.8/ U   branches/1.8/sounds/Makefile ------------------------------------------------------------------------ r280233 | qwell | 2010-07-28 15:03:20 -0500 (Wed, 28 Jul 2010) | 13 lines Merged revisions 280231 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ........  r280231 | qwell | 2010-07-28 15:02:27 -0500 (Wed, 28 Jul 2010) | 6 lines    Work around some silly behavior on BSD.    A non-zero exit from a subshell should make the build fail.    (closes issue ASTERISK-16347) ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280233 By: Digium Subversion (svnbot) 2010-07-28 15:04:05 Repository: asterisk Revision: 280234 _U  trunk/ U   trunk/sounds/Makefile ------------------------------------------------------------------------ r280234 | qwell | 2010-07-28 15:04:05 -0500 (Wed, 28 Jul 2010) | 20 lines Merged revisions 280233 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r280233 | qwell | 2010-07-28 15:03:22 -0500 (Wed, 28 Jul 2010) | 13 lines    Merged revisions 280231 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ........    r280231 | qwell | 2010-07-28 15:02:27 -0500 (Wed, 28 Jul 2010) | 6 lines        Work around some silly behavior on BSD.        A non-zero exit from a subshell should make the build fail.        (closes issue ASTERISK-16347)  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=280234