[Home]

Summary:ASTERISK-16363: [patch] reset visible_indication after call answering
Reporter:klaus3000 (klaus3000)Labels:
Date Opened:2010-07-14 07:17:38Date Closed:2010-08-10 12:49:36
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_dial
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast1.6.2.9-app_dial-visible_indication.patch.txt
Description:Currently, after a call is established (outgoing channel is answered), a visible_indication on the incoming channel is not reset.

This can cause problems when the channel is later used by services which check for visible_indication and trigger indication.

Consider the following case:

exten => a,1,Answer()
exten => a,2,Dial(SIP/a)
exten => b,1,Answer()
exten => b,2,Dial(SIP/b)
exten => c,1,Answer()
exten => c,2,Dial(SIP/c)

A calls B. B calls C. B refers A to C (attended transfer).

When A calls B, channel A is answered (UP). When the outgoing channel (B1) receives 180 ringing, a ringback tone will be played back to A (as A is already UP) and the visible_indication is set to ringing (3).

Later, when channel A is masquereded into channel B2 (B->C), the visible indication is still set, and Asterisk will falsely play a ringbacl tone to A as the attended transfer checks for visible_indication and triggers ast_indicate().


****** ADDITIONAL INFORMATION ******

This is a "reopening" of ASTERISK-16150. ASTERISK-16150 was closed as a duplicate of ASTERISK-14538, but  I can not reprouce the problem of ASTERISK-14538, thus I do not know if these problems are related at all. Therefore, I openend a new issue.
Comments:By: Leif Madsen (lmadsen) 2010-07-14 10:57:54

Thanks for the patch!
By: Stefan Schmidt (schmidts) 2010-07-14 12:13:14

i´ve tested this patch with the setup as described in 17400 and the channels are all ok. no slin write format after an attendand transfer.

thanks klaus for your patch.
By: Digium Subversion (svnbot) 2010-08-10 12:45:43

Repository: asterisk
Revision: 281566

U   branches/1.4/apps/app_dial.c

------------------------------------------------------------------------
r281566 | russell | 2010-08-10 12:45:43 -0500 (Tue, 10 Aug 2010) | 8 lines

Reset visible indication after answer.

(closes issue ASTERISK-16363)
Reported by: klaus3000
Patches:
     ast1.6.2.9-app_dial-visible_indication.patch.txt uploaded by klaus3000 (license 65)
Tested by: schmidts

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=281566
By: Digium Subversion (svnbot) 2010-08-10 12:47:11

Repository: asterisk
Revision: 281567

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_dial.c

------------------------------------------------------------------------
r281567 | russell | 2010-08-10 12:47:11 -0500 (Tue, 10 Aug 2010) | 15 lines

Merged revisions 281566 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r281566 | russell | 2010-08-10 12:45:45 -0500 (Tue, 10 Aug 2010) | 8 lines
 
 Reset visible indication after answer.
 
 (closes issue ASTERISK-16363)
 Reported by: klaus3000
 Patches:
       ast1.6.2.9-app_dial-visible_indication.patch.txt uploaded by klaus3000 (license 65)
 Tested by: schmidts
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=281567
By: Digium Subversion (svnbot) 2010-08-10 12:48:40

Repository: asterisk
Revision: 281568

_U  branches/1.8/
U   branches/1.8/apps/app_dial.c

------------------------------------------------------------------------
r281568 | russell | 2010-08-10 12:48:40 -0500 (Tue, 10 Aug 2010) | 22 lines

Merged revisions 281567 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r281567 | russell | 2010-08-10 12:47:13 -0500 (Tue, 10 Aug 2010) | 15 lines
 
 Merged revisions 281566 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r281566 | russell | 2010-08-10 12:45:45 -0500 (Tue, 10 Aug 2010) | 8 lines
   
   Reset visible indication after answer.
   
   (closes issue ASTERISK-16363)
   Reported by: klaus3000
   Patches:
         ast1.6.2.9-app_dial-visible_indication.patch.txt uploaded by klaus3000 (license 65)
   Tested by: schmidts
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=281568
By: Digium Subversion (svnbot) 2010-08-10 12:49:35

Repository: asterisk
Revision: 281570

_U  trunk/
U   trunk/apps/app_dial.c

------------------------------------------------------------------------
r281570 | russell | 2010-08-10 12:49:34 -0500 (Tue, 10 Aug 2010) | 29 lines

Merged revisions 281568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r281568 | russell | 2010-08-10 12:48:42 -0500 (Tue, 10 Aug 2010) | 22 lines
 
 Merged revisions 281567 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r281567 | russell | 2010-08-10 12:47:13 -0500 (Tue, 10 Aug 2010) | 15 lines
   
   Merged revisions 281566 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r281566 | russell | 2010-08-10 12:45:45 -0500 (Tue, 10 Aug 2010) | 8 lines
     
     Reset visible indication after answer.
     
     (closes issue ASTERISK-16363)
     Reported by: klaus3000
     Patches:
           ast1.6.2.9-app_dial-visible_indication.patch.txt uploaded by klaus3000 (license 65)
     Tested by: schmidts
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=281570