Summary:	ASTERISK-16408: [patch] GCC 4.2.x optimizations result in improper behavior of GSM codec
Reporter:	Philip Prindeville (pprindeville)	Labels:
Date Opened:	2010-07-22 13:17:05	Date Closed:	2011-06-07 14:04:48
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Codecs/codec_gsm
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-trunk-bugid11243.patch
Description:	Two patches were originally reported in bug 11243, one to add additional needed constraints on some asm() sequences that the codec uses, the other to disable optimization that the compiler was doing which was resulting in incorrect code. Only the latter was committed.  It's been confirmed that both patches are needed, at least until the code is restructured to allow correct optimization by the compiler. ****** ADDITIONAL INFORMATION ****** See bugid 11243 for the original report.
Comments:	By: Michael Keuter (mkeuter) 2010-07-23 02:44:26 I tested the patch and it works fine for me. The distortions of gsm sound files are gone. By: Philip Prindeville (pprindeville) 2010-08-28 12:38:34 Please advise what we need to do to get closure on this. By: Digium Subversion (svnbot) 2010-09-09 20:51:13 Repository: asterisk Revision: 285817 U   branches/1.4/codecs/gsm/Makefile ------------------------------------------------------------------------ r285817 | pabelanger | 2010-09-09 20:51:13 -0500 (Thu, 09 Sep 2010) | 8 lines GCC 4.2.x optimizations result in improper behavior of GSM codec (closes issue ASTERISK-16408) Reported by: pprindeville Patches:      asterisk-trunk-bugid11243.patch uploaded by pprindeville (license 347) Tested by: mkeuter, pprindeville ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285817 By: Digium Subversion (svnbot) 2010-09-09 20:51:19 Repository: asterisk Revision: 285818 _U  branches/1.6.2/ U   branches/1.6.2/codecs/gsm/Makefile ------------------------------------------------------------------------ r285818 | pabelanger | 2010-09-09 20:51:18 -0500 (Thu, 09 Sep 2010) | 15 lines Merged revisions 285817 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........  r285817 | pabelanger | 2010-09-09 18:34:35 -0400 (Thu, 09 Sep 2010) | 8 lines    GCC 4.2.x optimizations result in improper behavior of GSM codec    (closes issue ASTERISK-16408)  Reported by: pprindeville  Patches:        asterisk-trunk-bugid11243.patch uploaded by pprindeville (license 347)  Tested by: mkeuter, pprindeville ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285818 By: Digium Subversion (svnbot) 2010-09-09 20:51:23 Repository: asterisk Revision: 285819 _U  branches/1.8/ U   branches/1.8/codecs/gsm/Makefile ------------------------------------------------------------------------ r285819 | pabelanger | 2010-09-09 20:51:22 -0500 (Thu, 09 Sep 2010) | 22 lines Merged revisions 285818 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................  r285818 | pabelanger | 2010-09-09 18:49:19 -0400 (Thu, 09 Sep 2010) | 15 lines    Merged revisions 285817 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.4    ........    r285817 | pabelanger | 2010-09-09 18:34:35 -0400 (Thu, 09 Sep 2010) | 8 lines        GCC 4.2.x optimizations result in improper behavior of GSM codec        (closes issue ASTERISK-16408)    Reported by: pprindeville    Patches:          asterisk-trunk-bugid11243.patch uploaded by pprindeville (license 347)    Tested by: mkeuter, pprindeville  ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285819 By: Digium Subversion (svnbot) 2010-09-09 20:51:26 Repository: asterisk Revision: 285820 _U  trunk/ U   trunk/codecs/gsm/Makefile ------------------------------------------------------------------------ r285820 | pabelanger | 2010-09-09 20:51:26 -0500 (Thu, 09 Sep 2010) | 29 lines Merged revisions 285819 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................  r285819 | pabelanger | 2010-09-09 18:52:31 -0400 (Thu, 09 Sep 2010) | 22 lines    Merged revisions 285818 via svnmerge from  https://origsvn.digium.com/svn/asterisk/branches/1.6.2    ................    r285818 | pabelanger | 2010-09-09 18:49:19 -0400 (Thu, 09 Sep 2010) | 15 lines        Merged revisions 285817 via svnmerge from    https://origsvn.digium.com/svn/asterisk/branches/1.4        ........      r285817 | pabelanger | 2010-09-09 18:34:35 -0400 (Thu, 09 Sep 2010) | 8 lines            GCC 4.2.x optimizations result in improper behavior of GSM codec            (closes issue ASTERISK-16408)      Reported by: pprindeville      Patches:            asterisk-trunk-bugid11243.patch uploaded by pprindeville (license 347)      Tested by: mkeuter, pprindeville    ........  ................ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=285820 By: Russell Bryant (russell) 2010-09-10 10:53:52 Kevin suggested that we should move this check to the configure script.  I agree. By: Russell Bryant (russell) 2010-09-10 10:54:59 Check for an existing autoconf macro to get the gcc version.  There has _got_ to be one already out there. By: Leif Madsen (lmadsen) 2011-04-06 11:55:15 Closed due to lack of movement. If someone is able to provide the changes to the configure script per Kevin/Russell, then please feel free to reopen this issue.