[Home]

Summary:ASTERISK-16415: [patch] Workaround required for environments not supporting locale
Reporter:Philip Prindeville (pprindeville)Labels:
Date Opened:2010-07-24 13:56:59Date Closed:2010-07-26 11:44:25
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) asterisk-trunk-bugid17697.patch
Description:The fix for bugid 17662 introduced linkage dependencies on:

strcasecmp_l()
newlocale()
freelocale()

which might be an obstacle for embedded platforms which typically don't require (or have) internationalization support.



****** ADDITIONAL INFORMATION ******

Recommend that:

(a) the configure script be modified to detect the presence of xlocale;
(b) that the locale-based functionality only be enabled (via conditional compilation) when that presence is detected.
Comments:By: Mark Michelson (mmichelson) 2010-07-26 10:39:22

Definitely passes the "works for me" test on Linux. I'll go ahead and get this committed to 1.8 and trunk. Thanks a bunch!

By: Digium Subversion (svnbot) 2010-07-26 11:04:08

Repository: asterisk
Revision: 279504

U   branches/1.8/channels/sip/reqresp_parser.c
U   branches/1.8/configure
U   branches/1.8/configure.ac
U   branches/1.8/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r279504 | mmichelson | 2010-07-26 11:04:07 -0500 (Mon, 26 Jul 2010) | 14 lines

Allow for systems without locale support to be usable.

A recent change to SIP URI comparison code added a locale-specific
string comparison to the mix, and certain systems do not support
such functions. This fix allows for those systems to still use
Asterisk 1.8

(closes issue ASTERISK-16415)
Reported by: pprindeville
Patches:
     asterisk-trunk-bugid17697.patch uploaded by pprindeville (license 347)
Tested by: mmichelson


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279504

By: Digium Subversion (svnbot) 2010-07-26 11:44:24

Repository: asterisk
Revision: 279533

_U  trunk/
U   trunk/channels/sip/reqresp_parser.c
U   trunk/configure
U   trunk/configure.ac
U   trunk/include/asterisk/autoconfig.h.in

------------------------------------------------------------------------
r279533 | mmichelson | 2010-07-26 11:44:24 -0500 (Mon, 26 Jul 2010) | 20 lines

Merged revisions 279504 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r279504 | mmichelson | 2010-07-26 11:04:09 -0500 (Mon, 26 Jul 2010) | 14 lines
 
 Allow for systems without locale support to be usable.
 
 A recent change to SIP URI comparison code added a locale-specific
 string comparison to the mix, and certain systems do not support
 such functions. This fix allows for those systems to still use
 Asterisk 1.8
 
 (closes issue ASTERISK-16415)
 Reported by: pprindeville
 Patches:
       asterisk-trunk-bugid17697.patch uploaded by pprindeville (license 347)
 Tested by: mmichelson
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279533