[Home]

Summary:ASTERISK-16421: AST_OPTION_ONLY tests wrong variable
Reporter:Stuart Henderson (stuarth)Labels:
Date Opened:2010-07-25 05:16:21Date Closed:2010-07-26 10:44:45
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/BuildSystem
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:AST_OPTION_ONLY tests the wrong variable when it's checking to see if a value is used.

if test "x${$2}" = "x"; then
   m4_ifval($4, [$2="$4"], [:])

Instead it should be testing withval:

if test "x${withval}" = "x"; then
   m4_ifval($4, [$2="$4"], [:])


****** STEPS TO REPRODUCE ******

Attempt to set --with-sounds-cache and see that it's not honoured.

****** ADDITIONAL INFORMATION ******

Noticed in 1.6.2.10 but same code is in SVN head.
Comments:By: Digium Subversion (svnbot) 2010-07-26 10:41:12

Repository: asterisk
Revision: 279501

U   branches/1.6.2/autoconf/ast_ext_lib.m4

------------------------------------------------------------------------
r279501 | seanbright | 2010-07-26 10:41:12 -0500 (Mon, 26 Jul 2010) | 5 lines

Expand the correct value within AST_OPTION_ONLY.

(closes issue ASTERISK-16421)
Reported by: stuarth

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279501
By: Digium Subversion (svnbot) 2010-07-26 10:43:53

Repository: asterisk
Revision: 279502

_U  branches/1.8/
U   branches/1.8/autoconf/ast_ext_lib.m4

------------------------------------------------------------------------
r279502 | seanbright | 2010-07-26 10:43:53 -0500 (Mon, 26 Jul 2010) | 12 lines

Merged revisions 279501 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r279501 | seanbright | 2010-07-26 11:41:13 -0400 (Mon, 26 Jul 2010) | 5 lines
 
 Expand the correct value within AST_OPTION_ONLY.
 
 (closes issue ASTERISK-16421)
 Reported by: stuarth
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279502
By: Digium Subversion (svnbot) 2010-07-26 10:44:45

Repository: asterisk
Revision: 279503

_U  trunk/
U   trunk/autoconf/ast_ext_lib.m4

------------------------------------------------------------------------
r279503 | seanbright | 2010-07-26 10:44:44 -0500 (Mon, 26 Jul 2010) | 19 lines

Merged revisions 279502 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r279502 | seanbright | 2010-07-26 11:43:54 -0400 (Mon, 26 Jul 2010) | 12 lines
 
 Merged revisions 279501 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r279501 | seanbright | 2010-07-26 11:41:13 -0400 (Mon, 26 Jul 2010) | 5 lines
   
   Expand the correct value within AST_OPTION_ONLY.
   
   (closes issue ASTERISK-16421)
   Reported by: stuarth
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279503