[Home]

Summary:ASTERISK-16422: [patch] Asterisk 1.8-beta1 crash on "logger reoad"
Reporter:Kristijan Vrban (vrban)Labels:
Date Opened:2010-07-25 06:57:14Date Closed:2010-07-27 12:21:08
Priority:CriticalRegression?No
Status:Closed/CompleteComponents:General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) gdb.txt
( 1) issue17704.patch
Description:The cli cmd "logger reload" crash asterisk. See attached gdb output
Comments:By: Paul Belanger (pabelanger) 2010-07-25 07:47:33

I see the problem, but would like to see your logger.conf file.

By: Paul Belanger (pabelanger) 2010-07-25 08:00:53

Try this patch.  I was not able to reproduce this locally, but still upload your .config file.  Would like to see about a testsuite for this.

By: Kristijan Vrban (vrban) 2010-07-25 08:28:44

the patch fixed the crash.

my logger.conf is not modified. it's the logger.conf shipped from configs/logger.conf.sample

By: Paul Belanger (pabelanger) 2010-07-25 08:34:30

Promoted to 'Ready for Review'

By: Michael L. Young (elguero) 2010-07-25 12:25:30

This would appear to be a regression introduced in revision 278307.  I am having this same crash using trunk.

I can confirm that this patch appears to resolve this.

By: Scott Johnson (globalnetinc) 2010-07-25 12:31:55

also fixed the issues with logger rotate.

Thanks.

By: Digium Subversion (svnbot) 2010-07-25 12:32:20

Repository: asterisk
Revision: 279390

U   branches/1.8/main/logger.c

------------------------------------------------------------------------
r279390 | tilghman | 2010-07-25 12:32:20 -0500 (Sun, 25 Jul 2010) | 8 lines

Don't assume qlog is open.

(closes issue ASTERISK-16422)
Reported by: vrban
Patches:
      issue17704.patch uploaded by pabelanger (license 224)
Tested by: vrban

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279390

By: Digium Subversion (svnbot) 2010-07-25 12:33:44

Repository: asterisk
Revision: 279391

_U  trunk/
U   trunk/main/logger.c

------------------------------------------------------------------------
r279391 | tilghman | 2010-07-25 12:33:44 -0500 (Sun, 25 Jul 2010) | 15 lines

Merged revisions 279390 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r279390 | tilghman | 2010-07-25 12:32:21 -0500 (Sun, 25 Jul 2010) | 8 lines
 
 Don't assume qlog is open.
 
 (closes issue ASTERISK-16422)
  Reported by: vrban
  Patches:
        issue17704.patch uploaded by pabelanger (license 224)
  Tested by: vrban
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=279391