[Home]

Summary:ASTERISK-16441: [patch] res_musiconhold does not use generic timing interfaces
Reporter:Leif Madsen (lmadsen)Labels:
Date Opened:2010-07-27 07:04:37Date Closed:2010-08-26 18:51:54
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Resources/res_musiconhold
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100825__issue17726__2.diff.txt
Description:Per IRC:

<kpfleming> tzafrir_laptop: no, i don't believe that res_musiconhold is directly dependent on dahdi; it only requires a functional timing source
<tzafrir_laptop> kpfleming, not 'depend' actually. 'use'. See HAVE_DAHDI there
<kpfleming> i can't right now, sorry
<tzafrir_laptop> If I package dahdi-related modules separately to remove that dependency from the main package, can I safely keep it?
<kpfleming> tzafrir_laptop: it appears that res_musiconhold has not been upgraded to the use the generic timing interfaces.. that is an oversight that should be corrected before 1.8 is released
Comments:By: Sean Bright (seanbright) 2010-07-31 09:07:25

Patch removed because it was incorrect.


By: Digium Subversion (svnbot) 2010-08-26 18:47:01

Repository: asterisk
Revision: 283770

U   branches/1.8/res/res_musiconhold.c

------------------------------------------------------------------------
r283770 | tilghman | 2010-08-26 18:47:00 -0500 (Thu, 26 Aug 2010) | 8 lines

Convert MOH to use generic timers.

(closes issue ASTERISK-16441)
Reported by: lmadsen
Patches:
      20100825__issue17726__2.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=283770
By: Digium Subversion (svnbot) 2010-08-26 18:51:54

Repository: asterisk
Revision: 283771

_U  trunk/
U   trunk/res/res_musiconhold.c

------------------------------------------------------------------------
r283771 | tilghman | 2010-08-26 18:51:53 -0500 (Thu, 26 Aug 2010) | 15 lines

Merged revisions 283770 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r283770 | tilghman | 2010-08-26 18:47:02 -0500 (Thu, 26 Aug 2010) | 8 lines
 
 Convert MOH to use generic timers.
 
 (closes issue ASTERISK-16441)
  Reported by: lmadsen
  Patches:
        20100825__issue17726__2.diff.txt uploaded by tilghman (license 14)
  Tested by: tilghman
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=283771