[Home]

Summary:ASTERISK-16444: [patch] chan_iax2 produces PeerState registered event without Address and Port
Reporter:Jaco Kroon (jkroon)Labels:
Date Opened:2010-07-27 18:01:29Date Closed:2010-07-29 16:06:13
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) iax2-peerstate-address.patch
Description:The SIP variant of the registered PeerState event adds an Address and Port reflecting where the registration came from.  It is useful to obtain this information via AMI (specifically I'm looking to use this for auditing purposes, so I intend to store when and from where clients registered, as well as when registrations expired - obviously I don't care about the IP in that case).

****** ADDITIONAL INFORMATION ******

Confirmed via code review that ast 1.6.2.10 still has the issue.
Comments:By: Jaco Kroon (jkroon) 2010-07-27 18:08:16

Attached patch adds the desired parameters to the event when an IAX/2 peer registers.
By: Leif Madsen (lmadsen) 2010-07-28 13:27:21

Honestly I think this is a feature rather than a bug. Thanks for the patch!

I'm going to set this to Ready for Testing. I've asked #asterisk-bugs to determine some feedback on what versions this should go into though.
By: Leif Madsen (lmadsen) 2010-07-28 13:28:05

Also, since this is adding information to the manager (additional headers) I think UPGRADE.txt and CHANGES may need to be modified.
By: Leif Madsen (lmadsen) 2010-07-28 13:44:02

Folks in #asterisk-bugs consider this a new feature (thanks!) so we'll only be able to get this into Asterisk trunk (*maybe* 1.8 if Russell allows it).

I'd suggest we need to update CHANGES and UPGRADE.txt then for sure.
By: Leif Madsen (lmadsen) 2010-07-29 15:49:01

This should be reviewed and probably committed ;)
By: Leif Madsen (lmadsen) 2010-07-29 15:49:20

Paul, another one you may be able to help with. Thanks!
By: Digium Subversion (svnbot) 2010-07-29 16:06:12

Repository: asterisk
Revision: 280555

U   trunk/CHANGES
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r280555 | pabelanger | 2010-07-29 16:06:12 -0500 (Thu, 29 Jul 2010) | 8 lines

PeerStatus now includes Address and Port

(closes issue ASTERISK-16444)
Reported by: jkroon
Patches:
     iax2-peerstate-address.patch uploaded by jkroon (license 714)
Tested by: lmadsen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=280555