Summary:	ASTERISK-16484: [patch] Cleanup: consolidate call answering
Reporter:	Damien Wedhorn (wedhorn)	Labels:
Date Opened:	2010-07-30 21:09:22	Date Closed:	2010-08-07 17:17:09
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_skinny
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) cleanup.stateconnected.diff ( 1) cleanup.stateconnected2.diff
Description:	Move call answering stuff into new setsubstate_connected. Also add sub->substate var and set it to SUBSTATE_CONNECTED in setsubstate_connected. This should be roughly equivalent to previous code and there should be no changes in behaviour. ****** ADDITIONAL INFORMATION ****** Please test the following. Make a call to your skinny device and try answering with the 3 following methods: Pickup handset Press Answer softkey Press the line button Tested on 7960 and 30VIP.
Comments:	By: Damien Wedhorn (wedhorn) 2010-08-06 19:08:51 Added patch (v2) which includes starting rtp before queuing answer as per bug 17770. By: Sergio (salecha) 2010-08-07 07:58:36 the patch "cleanup.stateconnected2.diff" works perfectly to solve the issue of the first ring. I've tested with a cisco 7910. Thank you. By: Digium Subversion (svnbot) 2010-08-07 17:17:09 Repository: asterisk Revision: 281227 U   trunk/channels/chan_skinny.c ------------------------------------------------------------------------ r281227 | wedhorn | 2010-08-07 17:17:08 -0500 (Sat, 07 Aug 2010) | 12 lines Move call answering stuff into new setsubstate_connected. Move call answering stuff into new setsubstate_connected. Also add sub->substate var and set it to SUBSTATE_CONNECTED in setsubstate_connected. (closes issue ASTERISK-16484) Reported by: wedhorn Patches:      cleanup.stateconnected2.diff uploaded by wedhorn (license 30) Tested by: wedhorn, salecha Review: NA ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=281227