[Home]

Summary:ASTERISK-16514: [patch] [regression] Forwarding a voicemail with a prepended message does not work
Reporter:David Petersen (dpetersen)Labels:
Date Opened:2010-08-05 11:05:19Date Closed:2010-10-01 23:54:15
Priority:MinorRegression?Yes
Status:Closed/CompleteComponents:Applications/app_voicemail/ODBC
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 20100923__issue17803.diff.txt
Description:When a users selects to prepend a voicemail message before forwarding it, the voicemail is forwarded but the prepended message is not played.



****** ADDITIONAL INFORMATION ******

We have two asterisk servers that are running app_voicemail with ODBC storage.  Both were working (version 1.4.29.1) prior to upgrading to Asterisk 1.4.34 and Asterisk 1.4.33.1
Comments:By: Leif Madsen (lmadsen) 2010-08-05 15:21:44

If you were to revert the version back to 1.4.29.1 does this issue also revert? It might be possible to track down which specific revision caused this issue too by looking through the ChangeLogs and testing before/after that revision.

By: David Petersen (dpetersen) 2010-08-06 10:26:48

I reverted back to 1.4.29.1 and the issue did not follow; prepending voicemail messages worked.  
I next tried with 1.4.30 and prepending does not work.  So it would appear that the problem was introduced between 1.4.29.1 and 1.4.30.

By: Philippe Bolduc (philippebolduc) 2010-09-07 08:03:51

I have the same problem without ODBC on asterisk 1.6.0.26 but the issue is not in asterisk 1.6.0.22

By: Tilghman Lesher (tilghman) 2010-09-23 11:12:28

Patch uploaded for 1.4.  Basically, what was happening was that an optimization path caused the prepended file to be ignored.  This patch explicitly disables that optimization and forces the prepended file to be used.

By: Philippe Bolduc (philippebolduc) 2010-09-23 11:36:17

Do you have any indication when this was patch on the 1.6 version ?

By: Tilghman Lesher (tilghman) 2010-09-23 11:52:57

philippebolduc:  it won't be patched on 1.6 until the 1.4 version is tested and verified to fix the issue.

By: David Petersen (dpetersen) 2010-10-01 17:22:16

I've tested the patch on our 1.4.33.1 system, and it has fixed the problem we've had with prepending voicemail.  

Thank you.

By: Digium Subversion (svnbot) 2010-10-01 23:42:09

Repository: asterisk
Revision: 289873

U   branches/1.4/apps/app_voicemail.c

------------------------------------------------------------------------
r289873 | tilghman | 2010-10-01 23:42:09 -0500 (Fri, 01 Oct 2010) | 8 lines

When forwarding a message, a prepend means that the filesystem will always have a better copy.

(closes issue ASTERISK-16514)
Reported by: dpetersen
Patches:
      20100923__issue17803.diff.txt uploaded by tilghman (license 14)
Tested by: dpetersen

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=289873

By: Digium Subversion (svnbot) 2010-10-01 23:45:50

Repository: asterisk
Revision: 289874

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_voicemail.c

------------------------------------------------------------------------
r289874 | tilghman | 2010-10-01 23:45:50 -0500 (Fri, 01 Oct 2010) | 15 lines

Merged revisions 289873 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
 r289873 | tilghman | 2010-10-01 23:42:08 -0500 (Fri, 01 Oct 2010) | 8 lines
 
 When forwarding a message, a prepend means that the filesystem will always have a better copy.
 
 (closes issue ASTERISK-16514)
  Reported by: dpetersen
  Patches:
        20100923__issue17803.diff.txt uploaded by tilghman (license 14)
  Tested by: dpetersen
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=289874

By: Digium Subversion (svnbot) 2010-10-01 23:46:44

Repository: asterisk
Revision: 289875

_U  branches/1.8/
U   branches/1.8/apps/app_voicemail.c

------------------------------------------------------------------------
r289875 | tilghman | 2010-10-01 23:46:44 -0500 (Fri, 01 Oct 2010) | 22 lines

Merged revisions 289874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

................
 r289874 | tilghman | 2010-10-01 23:45:49 -0500 (Fri, 01 Oct 2010) | 15 lines
 
 Merged revisions 289873 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.4
 
 ........
   r289873 | tilghman | 2010-10-01 23:42:08 -0500 (Fri, 01 Oct 2010) | 8 lines
   
   When forwarding a message, a prepend means that the filesystem will always have a better copy.
   
   (closes issue ASTERISK-16514)
    Reported by: dpetersen
    Patches:
          20100923__issue17803.diff.txt uploaded by tilghman (license 14)
    Tested by: dpetersen
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=289875

By: Digium Subversion (svnbot) 2010-10-01 23:54:14

Repository: asterisk
Revision: 289876

_U  trunk/
U   trunk/apps/app_voicemail.c

------------------------------------------------------------------------
r289876 | tilghman | 2010-10-01 23:54:13 -0500 (Fri, 01 Oct 2010) | 29 lines

Merged revisions 289875 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r289875 | tilghman | 2010-10-01 23:46:43 -0500 (Fri, 01 Oct 2010) | 22 lines
 
 Merged revisions 289874 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ................
   r289874 | tilghman | 2010-10-01 23:45:49 -0500 (Fri, 01 Oct 2010) | 15 lines
   
   Merged revisions 289873 via svnmerge from
   https://origsvn.digium.com/svn/asterisk/branches/1.4
   
   ........
     r289873 | tilghman | 2010-10-01 23:42:08 -0500 (Fri, 01 Oct 2010) | 8 lines
     
     When forwarding a message, a prepend means that the filesystem will always have a better copy.
     
     (closes issue ASTERISK-16514)
      Reported by: dpetersen
      Patches:
            20100923__issue17803.diff.txt uploaded by tilghman (license 14)
      Tested by: dpetersen
   ........
 ................
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=289876