[Home]

Summary:ASTERISK-16515: ACCEPT message should contain an FORMAT2 ie as well as a FORMAT ie
Reporter:Tim Panton (tpanton)Labels:
Date Opened:2010-08-05 12:35:46Date Closed:2010-08-17 15:09:29
Priority:BlockerRegression?No
Status:Closed/CompleteComponents:Channels/chan_iax2
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The new wider codec support in 1.8 uses a 64bit value to represent the possible codecs.
This value is sent in the FORMAT2 info element, along side the FORMAT ie (which is retained
for backwards compatibility).

The ACCEPT message should also contain the new ie - it doesn't.

Incoming calls supporting _only_ a codec in the upper 32 bits (e.g. testlaw) will fail
as the accept packet contains zero (no codec) in the FORMAT ie

****** ADDITIONAL INFORMATION ******

Rx-Frame Retry[ No] -- OSeqno: 000 ISeqno: 000 Type: IAX     Subclass: NEW    
 Timestamp: 00000ms  SCall: 00001  DCall: 00000 [192.67.4.33:57369]
 VERSION         : 2
 USERNAME        : webtest
 CAPABILITY      : 0
 CAPABILITY2     : testlaw
 CODEC_PREFS     : (unknown)
 CALLING NAME    : vtop
 CALLING NUMBER  : 01612884242
 CALLED NUMBER   : 600
 DNID            : 600
 CALLING PRESNTN : 0
 CALLING TYPEOFN : 0

Tx-Frame Retry[000] -- OSeqno: 000 ISeqno: 001 Type: IAX     Subclass: AUTHREQ
 Timestamp: 00016ms  SCall: 02224  DCall: 00001 [192.67.4.33:57369]
 AUTHMETHODS     : 3
 CHALLENGE       : \x36\x32\x36\x30\x34\x38\x30\x39\x35
 USERNAME        : webtest

Rx-Frame Retry[ No] -- OSeqno: 001 ISeqno: 001 Type: IAX     Subclass: AUTHREP
 Timestamp: 00000ms  SCall: 00001  DCall: 02224 [192.67.4.33:57369]
 MD5 RESULT      : 7424fc1cb162f516267273af75b7cf2f

  -- Accepting AUTHENTICATED call from 192.67.4.33:
> requested format = unknown,
> requested prefs = (unknown),
> actual format = testlaw,
> host prefs = (testlaw),
> priority = mine
  -- Executing [600@default:1] Playback("IAX2/webtest-2224", "demo-echotest") in new stack
Tx-Frame Retry[000] -- OSeqno: 001 ISeqno: 002 Type: IAX     Subclass: ACCEPT
 Timestamp: 00147ms  SCall: 02224  DCall: 00001 [192.67.4.33:57369]
 FORMAT          : 0
Comments:By: Digium Subversion (svnbot) 2010-08-17 14:34:05

Repository: asterisk
Revision: 282543

U   branches/1.8/include/asterisk/unaligned.h

------------------------------------------------------------------------
r282543 | dvossel | 2010-08-17 14:34:04 -0500 (Tue, 17 Aug 2010) | 4 lines

fixes truncated uint64_t value in put_unaligned_uint64_t() function

(issue ASTERISK-16515)

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282543
By: Digium Subversion (svnbot) 2010-08-17 14:34:50

Repository: asterisk
Revision: 282544

_U  trunk/
U   trunk/include/asterisk/unaligned.h

------------------------------------------------------------------------
r282544 | dvossel | 2010-08-17 14:34:50 -0500 (Tue, 17 Aug 2010) | 11 lines

Merged revisions 282543 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r282543 | dvossel | 2010-08-17 14:34:06 -0500 (Tue, 17 Aug 2010) | 4 lines
 
 fixes truncated uint64_t value in put_unaligned_uint64_t() function
 
 (issue ASTERISK-16515)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282544
By: Digium Subversion (svnbot) 2010-08-17 15:08:54

Repository: asterisk
Revision: 282545

U   branches/1.8/channels/chan_iax2.c

------------------------------------------------------------------------
r282545 | dvossel | 2010-08-17 15:08:54 -0500 (Tue, 17 Aug 2010) | 6 lines

ACCEPT message should respond with the new FORMAT2 ie

(closes issue ASTERISK-16515)
Reported by: tpanton


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282545
By: Digium Subversion (svnbot) 2010-08-17 15:09:28

Repository: asterisk
Revision: 282546

_U  trunk/
U   trunk/channels/chan_iax2.c

------------------------------------------------------------------------
r282546 | dvossel | 2010-08-17 15:09:28 -0500 (Tue, 17 Aug 2010) | 12 lines

Merged revisions 282545 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r282545 | dvossel | 2010-08-17 15:08:56 -0500 (Tue, 17 Aug 2010) | 6 lines
 
 ACCEPT message should respond with the new FORMAT2 ie
 
 (closes issue ASTERISK-16515)
 Reported by: tpanton
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=282546