[Home]

Summary:ASTERISK-16543: [patch] SIP domains automatically add 0.0.0.0 and :: for IPv6
Reporter:Olle Johansson (oej)Labels:
Date Opened:2010-08-11 04:58:27Date Closed:2010-09-07 17:23:34
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/chan_sip/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 17832-wildcard.diff
Description:With autodomain support in sip.conf, the 0.0.0.0 bind address is added as a domain. Previously, chan_sip complained that it could not add automatic domains for that IP... Something is buggy here. In any case, 0.0.0.0 should NOT be added to the domain list.


*CLI> sip show domains
Our local SIP domains:                   Context              Set by          
132.177.252.81                           (default)            [Configured]    
localhost                                (default)            [Configured]    
127.0.0.1                                (default)            [Configured]    
0.0.0.0                                  (default)            [Automatic]    
agave.local                              (default)            [Automatic]    
Comments:By: Olle Johansson (oej) 2010-08-11 05:00:00

On another system with IPv6:


build*CLI> sip show domains
Our local SIP domains:                   Context              Set by          
::                                       (default)            [Automatic]    


Equally buggy.
By: Olle Johansson (oej) 2010-08-11 08:36:22

When we have bindaddr = :: we should add both all IPv4 and all IPv6 addresses.
By: Jason Parker (jparker) 2010-08-26 15:47:45

This fixes it for me.  If it works for you (oej), I'll commit it.  Let me know.
By: Olle Johansson (oej) 2010-08-27 01:35:26

I'll test and report back to you.
By: Leif Madsen (lmadsen) 2010-09-07 16:12:12

Ping?
By: Russell Bryant (russell) 2010-09-07 16:13:34

I think this patch makes sense, ship it!
By: Digium Subversion (svnbot) 2010-09-07 17:22:15

Repository: asterisk
Revision: 285455

U   branches/1.8/channels/chan_sip.c

------------------------------------------------------------------------
r285455 | qwell | 2010-09-07 17:22:15 -0500 (Tue, 07 Sep 2010) | 8 lines

Don't automatically add domains for wildcard bindaddrs.

(closes issue ASTERISK-16543)
Reported by: oej
Patches:
     17832-wildcard.diff uploaded by qwell (license 4)
Tested by: qwell

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285455
By: Digium Subversion (svnbot) 2010-09-07 17:23:33

Repository: asterisk
Revision: 285456

_U  trunk/
U   trunk/channels/chan_sip.c

------------------------------------------------------------------------
r285456 | qwell | 2010-09-07 17:23:32 -0500 (Tue, 07 Sep 2010) | 15 lines

Merged revisions 285455 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
 r285455 | qwell | 2010-09-07 17:22:14 -0500 (Tue, 07 Sep 2010) | 8 lines
 
 Don't automatically add domains for wildcard bindaddrs.
 
 (closes issue ASTERISK-16543)
 Reported by: oej
 Patches:
       17832-wildcard.diff uploaded by qwell (license 4)
 Tested by: qwell
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=285456