| Summary: | ASTERISK-16596: Possible memory leak in originate | ||
| Reporter: | Olle Johansson (oej) | Labels: | |
| Date Opened: | 2010-08-20 03:51:34 | Date Closed: | 2010-09-19 11:12:09 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/ManagerInterface |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ||
| Description: | The originate action can be used with channel variables. These are allocated, but not freed. I am working with a patch that - copies variables to the fast-originate thread, so the thread can free them by itself - frees variables at the end of the originate action | ||
| Comments: | By: Olle Johansson (oej) 2010-08-20 05:50:21 Patch for 1.4 on reviewboard By: Olle Johansson (oej) 2010-08-20 05:52:39 The code is similar in trunk, so the same patch applies for all version from 1.4 to trunk. By: Matt Riddell (zx81) 2010-08-23 19:43:16 Just to get this straight, is this a leak on every call via originate? How long has it been in for? Seems crazy I haven't come across it! Same situation with Async? By: Olle Johansson (oej) 2010-08-24 00:35:53 It only happens when you have channel variables in the originate command. By: Olle Johansson (oej) 2010-09-11 13:15:49 Got SHIP it on reviewboard after some discussions. Time to commit. By: Digium Subversion (svnbot) 2010-09-19 10:56:50 Repository: asterisk Revision: 287469 U branches/1.4/main/manager.c ------------------------------------------------------------------------ r287469 | oej | 2010-09-19 10:56:50 -0500 (Sun, 19 Sep 2010) | 7 lines Make sure we always free variables properly in manager originate. (closes issue ASTERISK-16596) reported, solved and tested by oej Review: https://reviewboard.asterisk.org/r/869/ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=287469 By: Digium Subversion (svnbot) 2010-09-19 11:06:11 Repository: asterisk Revision: 287470 _U branches/1.6.2/ U branches/1.6.2/main/manager.c ------------------------------------------------------------------------ r287470 | oej | 2010-09-19 11:06:11 -0500 (Sun, 19 Sep 2010) | 14 lines Merged revisions 287469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r287469 | oej | 2010-09-19 17:56:50 +0200 (S?\195?\182n, 19 Sep 2010) | 7 lines Make sure we always free variables properly in manager originate. (closes issue ASTERISK-16596) reported, solved and tested by oej Review: https://reviewboard.asterisk.org/r/869/ ........ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=287470 By: Digium Subversion (svnbot) 2010-09-19 11:09:29 Repository: asterisk Revision: 287471 _U branches/1.8/ U branches/1.8/main/manager.c ------------------------------------------------------------------------ r287471 | oej | 2010-09-19 11:09:28 -0500 (Sun, 19 Sep 2010) | 21 lines Merged revisions 287470 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r287470 | oej | 2010-09-19 18:06:10 +0200 (S?\195?\182n, 19 Sep 2010) | 14 lines Merged revisions 287469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r287469 | oej | 2010-09-19 17:56:50 +0200 (S?\195?\182n, 19 Sep 2010) | 7 lines Make sure we always free variables properly in manager originate. (closes issue ASTERISK-16596) reported, solved and tested by oej Review: https://reviewboard.asterisk.org/r/869/ ........ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=287471 By: Digium Subversion (svnbot) 2010-09-19 11:12:08 Repository: asterisk Revision: 287472 _U trunk/ U trunk/main/manager.c ------------------------------------------------------------------------ r287472 | oej | 2010-09-19 11:12:08 -0500 (Sun, 19 Sep 2010) | 28 lines Merged revisions 287471 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ................ r287471 | oej | 2010-09-19 18:09:28 +0200 (S?\195?\182n, 19 Sep 2010) | 21 lines Merged revisions 287470 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.6.2 ................ r287470 | oej | 2010-09-19 18:06:10 +0200 (S?\195?\182n, 19 Sep 2010) | 14 lines Merged revisions 287469 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r287469 | oej | 2010-09-19 17:56:50 +0200 (S?\195?\182n, 19 Sep 2010) | 7 lines Make sure we always free variables properly in manager originate. (closes issue ASTERISK-16596) reported, solved and tested by oej Review: https://reviewboard.asterisk.org/r/869/ ........ ................ ................ ------------------------------------------------------------------------ http://svn.digium.com/view/asterisk?view=rev&revision=287472 | ||