[Home]

Summary:ASTERISK-16694: [patch] ACK tone not reliable on embedded platform with low CPU power
Reporter:Fred van Lieshout (lieshout)Labels:
Date Opened:2010-09-17 09:01:49Date Closed:2012-09-05 11:04:07
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_alarmreceiver
Versions:Frequency of
Occurrence
Related
Issues:
is related toASTERISK-16668 ACK tone interupted - Jitterbuffers do not function properly as AlarmReceiver App does not send RTP regularly
is related toASTERISK-18417 app_alarmreceiver hanging forever in send_tone_burst/ast_waitfor()
Environment:Attachments:( 0) 0001-Remove-proprietary-send_tone_burst-use-stock-asteris.patch
( 1) alarmreceiver.c.patch.txt
( 2) app_alarmreceiver_toneburstremoval.patch
Description:IMPORTANT: This problem only showed up on an embbeded device (router with the ADM5120 CPU running at 175 MHz).

Similar to issue ASTERISK-16668, the acknowledge tones (1400/2300Hz) are not properly played back. A trace with Wireshark reveals that there is too much time between the frames (for a jitter buffer mechanism to properly pick this up).


****** ADDITIONAL INFORMATION ******

A little experiment with using ast_playtones_ functions, instead of the application's proprietary send_tone_burst, seems to solve the problem (but I cannot explain why this is).
Comments:By: Leif Madsen (lmadsen) 2010-09-21 12:37:05

Marking this as Confirmed as there is a patched attached, but requires a review to see if the approach is sound. Others experiencing similar issues may wish to give this patch a shot to see if it helps with their problem.

By: Jean-Philippe Lord (jplord) 2011-04-06 18:47:16

I have retrofitted this patch into 1.4.40 and it fixed the bug. See 17982 for full comments.

By: Jean-Philippe Lord (jplord) 2012-03-30 16:15:14.529-0500

This is a patch for current SVN of asterisk 1.8

By: Jean-Philippe Lord (jplord) 2012-03-30 16:51:21.870-0500

Please consider applying. This patch is fixing issues for 2 more open issues. Thanks

By: Pedro Kiefer (pedrokiefer) 2012-08-16 09:17:15.359-0500

Updated patch, for applying after the ones on issues: ASTERISK-19435, ASTERISK-20157, ASTERISK-20158, ASTERISK-20224

I should probably redo all patchs once again, so that applying ASTERISK-19435 isn't needed.

By: Kostas Liakakis (frap) 2012-08-17 13:05:12.825-0500

I've been using this patch (well, the original version at least) reliably for almost a year now without any problem, whereas the stock code would hang on me ( ASTERISK-18417 ).

I am glad you seem close to apply this to mainstream so it can eventually be available from my preferred distro's repository.