[Home]

Summary:ASTERISK-16695: [patch] PickupChan() is not working with full channel name
Reporter:Bastian Schern (schern)Labels:
Date Opened:2010-09-17 22:05:06Date Closed:2010-10-05 14:57:32
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_directed_pickup
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_directed_pickup.c.2.patch
( 1) app_directed_pickup.c.patch
( 2) app_directed_pickup.c.trunk.patch
Description:PickupChan() is not working with full channel name. Currently it only works if the pickup channel contains channel type and extension (e.g. SIP/123).
If the full channel name is passed, e.g. SIP/123-0000000a, the pickup will fail.

****** STEPS TO REPRODUCE ******

This works:
exten => s,1,PickupChan(SIP/123)

This does not work:
exten => s,1,PickupChan(SIP/123-0000000a)

****** ADDITIONAL INFORMATION ******

I attached a very simple patch that fixes the problem for me.
Comments:By: Stefan Schmidt (schmidts) 2010-09-18 03:34:12

i see one problem with this. if you dont use the full name for pickup for example SIP/123 your patch would also pickup a call for SIP/123456. the original one wouldnt do this.

maybe you should add a check if the channel name has a "-" in it, if so compare the whole string, else add a "-" as its done by now.
By: Bastian Schern (schern) 2010-09-20 03:31:17

I added a new patch (app_directed_pickup.c.2.patch):
If the channel name does not contain a '-' it will be handled like before.
If the channel name contains a '-' it will no longer append at the end.
By: Leif Madsen (lmadsen) 2010-09-21 12:52:26

As this is a feature addition, it really needs to be created against Asterisk trunk.
By: Bastian Schern (schern) 2010-09-21 13:33:17

It's not really a feature I think it's maybe a bug. But I also uploaded a patch for the trunk version (r287927).
By: Leif Madsen (lmadsen) 2010-10-04 10:46:35

Russell and John agree this is more of a bug fix than a feature addition, so it'll go into the appropriate branches. Thanks!
By: Digium Subversion (svnbot) 2010-10-05 14:54:51

Repository: asterisk
Revision: 290375

U   branches/1.6.2/apps/app_directed_pickup.c

------------------------------------------------------------------------
r290375 | dvossel | 2010-10-05 14:54:51 -0500 (Tue, 05 Oct 2010) | 10 lines

Fixes PickupChan() not working with full channel name.

(closes issue ASTERISK-16695)
Reported by: schern
Patches:
     app_directed_pickup.c.2.patch uploaded by schern (license 995)
     app_directed_pickup.c.trunk.patch uploaded by schern (license 995)
Tested by: schern, dvossel


------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=290375
By: Digium Subversion (svnbot) 2010-10-05 14:56:30

Repository: asterisk
Revision: 290376

_U  branches/1.8/
U   branches/1.8/apps/app_directed_pickup.c

------------------------------------------------------------------------
r290376 | dvossel | 2010-10-05 14:56:30 -0500 (Tue, 05 Oct 2010) | 16 lines

Merged revisions 290375 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2

........
 r290375 | dvossel | 2010-10-05 14:54:50 -0500 (Tue, 05 Oct 2010) | 10 lines
 
 Fixes PickupChan() not working with full channel name.
 
 (closes issue ASTERISK-16695)
 Reported by: schern
 Patches:
       app_directed_pickup.c.2.patch uploaded by schern (license 995)
       app_directed_pickup.c.trunk.patch uploaded by schern (license 995)
 Tested by: schern, dvossel
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=290376
By: Digium Subversion (svnbot) 2010-10-05 14:57:31

Repository: asterisk
Revision: 290377

_U  trunk/
U   trunk/apps/app_directed_pickup.c

------------------------------------------------------------------------
r290377 | dvossel | 2010-10-05 14:57:31 -0500 (Tue, 05 Oct 2010) | 23 lines

Merged revisions 290376 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

................
 r290376 | dvossel | 2010-10-05 14:56:29 -0500 (Tue, 05 Oct 2010) | 16 lines
 
 Merged revisions 290375 via svnmerge from
 https://origsvn.digium.com/svn/asterisk/branches/1.6.2
 
 ........
   r290375 | dvossel | 2010-10-05 14:54:50 -0500 (Tue, 05 Oct 2010) | 10 lines
   
   Fixes PickupChan() not working with full channel name.
   
   (closes issue ASTERISK-16695)
   Reported by: schern
   Patches:
         app_directed_pickup.c.2.patch uploaded by schern (license 995)
         app_directed_pickup.c.trunk.patch uploaded by schern (license 995)
   Tested by: schern, dvossel
 ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=290377