Asterisk
  1. Asterisk
  2. ASTERISK-16741

Bad assumption in ast_ouraddrfor in chan_sip regarding extern IP and IPv6

    Details

    • Type: Bug Bug
    • Status: Closed
    • Severity: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Target Release Version/s: None
    • Component/s: Channels/chan_sip/IPv6
    • Labels:
      None
    • Mantis ID:
      18064
    • Regression:
      No

      Description

      The code says:

      if (ast_sockaddr_is_ipv6(&theirs)) {
      if (localaddr && !ast_sockaddr_isnull(externaddr))

      { ast_log(LOG_WARNING, "Address remapping activated in sip.conf " "but we're using IPv6, which doesn't need it. Please " "remove \"localnet\" and/or \"externaddr\" settings.\n"); }

      Which is definitely wrong. If you have "::" as a bind address, the IPv6 socket WILL listen to IPv4 and the externip/localnet settings might be needed on the IPv4 side of life.

        Issue Links

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

          Hide
          Mark Michelson added a comment -

          I may be misinterpreting the problem but I think you might be mistaken. The if statement is checking whether "theirs" is IPv6, not "us." If theirs is an IPv6 address, doesn't that guarantee that we'll be using IPv6 as well and so no such remapping is necessary?

          Or does the bug apply to a situation where the localnet uses IPv4 but the externip is IPv6?

          Show
          Mark Michelson added a comment - I may be misinterpreting the problem but I think you might be mistaken. The if statement is checking whether "theirs" is IPv6, not "us." If theirs is an IPv6 address, doesn't that guarantee that we'll be using IPv6 as well and so no such remapping is necessary? Or does the bug apply to a situation where the localnet uses IPv4 but the externip is IPv6?
          Hide
          Jeff Peeler (Inactive) added a comment -

          Closing this as it appears to not actually be a bug.

          Show
          Jeff Peeler (Inactive) added a comment - Closing this as it appears to not actually be a bug.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: